feat(datastore): add support for AppSync RTF #11000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #11000 +/- ##
==========================================
- Coverage 82.24% 82.15% -0.10%
==========================================
Files 193 193
Lines 19367 19507 +140
Branches 4185 4228 +43
==========================================
+ Hits 15928 16025 +97
- Misses 3151 3194 +43
Partials 288 288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpilch
reviewed
Feb 20, 2023
iartemiev
force-pushed
the
ds-sub-filtering
branch
2 times, most recently
from
8960f62 to
7b45c5a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
iartemiev
force-pushed
the
ds-sub-filtering
branch
2 times, most recently
from
c28e40d to
ac6e1de
Compare
iartemiev
force-pushed
the
ds-sub-filtering
branch
from
8f4881f to
4ad4899
Compare
|
FYI - tried to use "hide as resolved" for Richard's comment above, because I've updated the PR with the change he requested, but GH is just showing it as "hidden". |
svidgen
reviewed
Mar 2, 2023
iartemiev
force-pushed
the
ds-sub-filtering
branch
7 times, most recently
from
74c9913 to
a5b8ced
Compare
svidgen
requested changes
Mar 6, 2023
iartemiev
force-pushed
the
ds-sub-filtering
branch
from
e3baa9a to
a5f26ab
Compare
svidgen
previously approved these changes
Mar 6, 2023
Co-authored-by: Jon Wire <iambipedal@gmail.com>
iartemiev
force-pushed
the
ds-sub-filtering
branch
from
c8d75fc to
7f9b75a
Compare
svidgen
approved these changes
Mar 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add support for AppSync Enhanced Subscription Filtering (aka Runtime Filtering / RTF)
Adds compatibility with dynamic auth on list fields, e.g. "list of owners", "list of groups".
Allows DataStore selective sync predicates to be applied as a backend subscription filter, instead of receiving all authorized subscription messages and filtering them clientside as was done before this PR.
RTF has several service constraints (listed here), therefore the current clientside filtering behavior will remain as a fallback in case the service rejects the provided filter expression.
In order to keep this change non-breaking, if DataStore receives an RTF-specific error message from the service at connect time, it will retry the subscription without a filter argument, falling back to filtering the subscription messages in the client.
Additional fix
The selective sync -> DDB Query use case is currently broken in main, because the filter expression we send as a sync query param has a bunch of redundant
andgroups nested and the generated sync query request resolver isn't able to match the filter expression to a query expression. This PR flattens the resulting GQL filter to restore this use case (see predicateToGraphqlFilter)Issue #, if available
#7534
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.