Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify JS release #11045

Merged
merged 7 commits into from
Mar 6, 2023
Merged

Amplify JS release #11045

merged 7 commits into from
Mar 6, 2023

Conversation

elorzafe
Copy link
Contributor

@elorzafe elorzafe commented Mar 6, 2023

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

david-mcafee and others added 7 commits February 28, 2023 17:07
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
…or on models (#11009)

* starting with relevant changes from #10932

* add missing tabledef set to graphql fake

* fixed test expected field list

* test util for determining timestamp field names

* repro of issue

* timestamp fix

* chore: docstrings, re-enable all tests, remove integ testing from the branch

* remove cruft

* Update packages/datastore/src/datastore/datastore.ts

Co-authored-by: David McAfee <mcafd@amazon.com>

* updated for new nullish checks in tests from main

---------

Co-authored-by: David McAfee <mcafd@amazon.com>
Co-authored-by: Dane Pilcher <dppilche@amazon.com>
@elorzafe elorzafe requested review from a team as code owners March 6, 2023 19:53
@elorzafe elorzafe merged commit 604677f into release Mar 6, 2023
Copy link
Contributor

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants