Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed the XR package from aws-amplify #11055

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

jimblanc
Copy link
Contributor

@jimblanc jimblanc commented Mar 7, 2023

Description of changes

This change removes XR from the aws-amplify umbrella package to fix an issue where multiple versions of core were being included in the project.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review March 7, 2023 19:11
@jimblanc jimblanc requested a review from a team as a code owner March 7, 2023 19:11
@codecov-commenter
Copy link

Codecov Report

Merging #11055 (5c79807) into main (2f92869) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #11055   +/-   ##
=======================================
  Coverage   82.13%   82.14%           
=======================================
  Files         193      193           
  Lines       19507    19506    -1     
  Branches     4228     4228           
=======================================
+ Hits        16023    16024    +1     
+ Misses       3196     3194    -2     
  Partials      288      288           
Impacted Files Coverage Δ
packages/aws-amplify/src/index.ts 100.00% <ø> (ø)
...kages/amazon-cognito-identity-js/src/BigInteger.js 89.71% <0.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jimblanc jimblanc merged commit 2d071e6 into aws-amplify:main Mar 7, 2023
@jimblanc jimblanc deleted the xr/remove-umbrella branch March 7, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants