refactor(autoware_behavior_path_start_planner_module): move planner_data to method parameter #9788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…sary time_keeper parameter from pull-out planners Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…per parameter from pull-out planners Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…lization and parameter handling Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…r/lane_departure_checker/update_constructor Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
… out planners Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
force-pushed
the
refactor/start_planner/change_interface
branch
from
3d94c85 to
46ac842
Compare
…o refactor/start_planner/change_interface Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
github-actions
bot
added
the
component:control
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
includes following PRs change
#9827
#9791
The PRs from above need to be merged in order.
This PR refactors the pull-out planner interfaces by removing the planner_data member variable from the PullOutPlannerBase class and passing it as a method parameter instead.
This change:
The changes maintain the same functionality while making the code more maintainable.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.