refactor(autoware_behavior_path_start_planner_module): move planner_data to method parameter #9788
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jan 6, 2025 in 55s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.06 (5.63 -> 5.57)
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Brain Method shift_pull_out.cpp: ShiftPullOut::calcPullOutPaths
- Complex Method shift_pull_out.cpp: ShiftPullOut::plan
✅ Improving Code Health:
- Lines of Code in a Single File goal_planner_module.cpp 🔥
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Brain Method
ShiftPullOut::calcPullOutPaths is a brain method. A Brain Method -- aka a God Function -- is a large and complex function that centralizes the behavior of a module. Brain Methods are detected using a combination of the following code smells: Deeply Nested Logic + High Cyclomatic Complexity + Many Lines of Code + Many Function Arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
ShiftPullOut::plan already has high cyclomatic complexity, and now it increases in Lines of Code from 87 to 90. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Excess Number of Function Arguments
ShiftPullOut::calcPullOutPaths has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1878 to 1876, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Loading