Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gyro_odometer)!: prefix package and namespace with autoware #8340

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Aug 2, 2024

Description

This PR will add a autoware_ prefix to gyro_odometer.

Related links

Parent Issue:

How was this PR tested?

Checked it works with autoware sample-rosbag.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.85%. Comparing base (a7db560) to head (524ed5a).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8340      +/-   ##
==========================================
- Coverage   23.96%   23.85%   -0.11%     
==========================================
  Files        1382     1379       -3     
  Lines      102019   100829    -1190     
  Branches    38886    38207     -679     
==========================================
- Hits        24446    24055     -391     
+ Misses      75141    74300     -841     
- Partials     2432     2474      +42     
Flag Coverage Δ *Carryforward flag
differential 13.04% <ø> (?)
total 23.81% <ø> (-0.15%) ⬇️ Carriedforward from b189c8a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau force-pushed the mau/ref/localization/gyro_odometer branch from cd01521 to aa3926b Compare August 8, 2024 05:28
@a-maumau
Copy link
Contributor Author

a-maumau commented Aug 8, 2024

Resolved conflicts.

@SakodaShintaro
Copy link
Contributor

@a-maumau
Sorry, some conflicts occurred again. Please check .github/CODEOWNERS.

@a-maumau
Copy link
Contributor Author

a-maumau commented Aug 9, 2024

@SakodaShintaro I fixed the conflict.

@SakodaShintaro
Copy link
Contributor

The following error occurred:

+ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
tier4_localization_launch: Cannot locate rosdep definition for [gyro_odometer]

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau
Copy link
Contributor Author

a-maumau commented Aug 9, 2024

I fix the launch/tier4_localization_launch/package.xml, so I think the issue is fixed.

@SakodaShintaro
Copy link
Contributor

@a-maumau
Unfortunately, .github/CODEOWNERS conflicts again :(

@a-maumau
Copy link
Contributor Author

a-maumau commented Aug 22, 2024

I resolved the conflict in .github/CODEOWNERS.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well and the mean error against AWSIM GT is roughly the same as before (7.2cm -> 6.7cm)

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)

@SakodaShintaro SakodaShintaro merged commit cf6859e into autowarefoundation:main Aug 22, 2024
30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…utowarefoundation#8340)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add missing header

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* use target_include_directories instead

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…utowarefoundation#8340)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add missing header

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* use target_include_directories instead

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants