-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gyro_odometer)!: prefix package and namespace with autoware #8340
refactor(gyro_odometer)!: prefix package and namespace with autoware #8340
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8340 +/- ##
==========================================
- Coverage 23.96% 23.85% -0.11%
==========================================
Files 1382 1379 -3
Lines 102019 100829 -1190
Branches 38886 38207 -679
==========================================
- Hits 24446 24055 -391
+ Misses 75141 74300 -841
- Partials 2432 2474 +42
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
cd01521
to
aa3926b
Compare
Resolved conflicts. |
@a-maumau |
@SakodaShintaro I fixed the conflict. |
The following error occurred:
|
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
I fix the |
@a-maumau |
I resolved the conflict in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator works well and the mean error against AWSIM GT is roughly the same as before (7.2cm -> 6.7cm)
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
.
- Change the
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Search
…utowarefoundation#8340) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add missing header Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * use target_include_directories instead Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
…utowarefoundation#8340) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add missing header Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * use target_include_directories instead Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Description
This PR will add a
autoware_
prefix togyro_odometer
.Related links
Parent Issue:
How was this PR tested?
Checked it works with autoware sample-rosbag.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.