-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pose2twist)!: prefix package and namespace with autoware #8347
refactor(pose2twist)!: prefix package and namespace with autoware #8347
Conversation
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator and AWSIM work well.
I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Start
#ifndef
guards withAUTOWARE__
. - Add
autoware::
tonamespace
.
- Start
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Include
- Add
autoware
folder as necessary and update include statements accordingly. - Check for impacts on other packages.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
Looks Good To Me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8347 +/- ##
==========================================
- Coverage 23.77% 0.57% -23.20%
==========================================
Files 1379 27 -1352
Lines 101359 868 -100491
Branches 38530 111 -38419
==========================================
- Hits 24094 5 -24089
+ Misses 74801 863 -73938
+ Partials 2464 0 -2464
☔ View full report in Codecov by Sentry. |
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
67f455d
into
autowarefoundation:main
…towarefoundation#8347) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * use target_include_directories instead Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
…towarefoundation#8347) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * use target_include_directories instead Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com>
Description
This PR will add a
autoware_
prefix topose2twist
.Use
ros2 launch autoware_steer_offset_estimator steer_offset_estimator.launch.xml
for launching the node.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.