Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pose2twist)!: prefix package and namespace with autoware #8347

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Aug 5, 2024

Description

This PR will add a autoware_ prefix to pose2twist.

Use ros2 launch autoware_steer_offset_estimator steer_offset_estimator.launch.xml for launching the node.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator and AWSIM work well.

I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Start #ifndef guards with AUTOWARE__.
    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Include

    • Add autoware folder as necessary and update include statements accordingly.
    • Check for impacts on other packages.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

Looks Good To Me

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.57%. Comparing base (6fb8804) to head (6a47e58).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #8347       +/-   ##
==========================================
- Coverage   23.77%   0.57%   -23.20%     
==========================================
  Files        1379      27     -1352     
  Lines      101359     868   -100491     
  Branches    38530     111    -38419     
==========================================
- Hits        24094       5    -24089     
+ Misses      74801     863    -73938     
+ Partials     2464       0     -2464     
Flag Coverage Δ
differential 0.57% <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau
Copy link
Contributor Author

a-maumau commented Aug 6, 2024

Update the CMakeLists.txt. Same reason for #8340 (comment)

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro merged commit 67f455d into autowarefoundation:main Aug 7, 2024
29 of 30 checks passed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…towarefoundation#8347)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* use target_include_directories instead

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…towarefoundation#8347)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* use target_include_directories instead

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants