Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_projection_loader): add autoware prefix to map_projection_loader #93

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Aug 9, 2024

Description

This PR will add autoware_ prefix to map_projection_loader

Reflect the change of autowarefoundation/autoware.universe#8420

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro
Copy link
Contributor

SakodaShintaro commented Aug 22, 2024

@satoshi-ota
This PR should be merged at the same time as autowarefoundation/autoware.universe#8420, so could you please approve this PR?

@SakodaShintaro
Copy link
Contributor

@satoshi-ota friendly ping.

@SakodaShintaro SakodaShintaro merged commit bec6190 into autowarefoundation:main Aug 29, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants