-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map_projection_loader)!: prefix package and namespace with autoware #8420
refactor(map_projection_loader)!: prefix package and namespace with autoware #8420
Conversation
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8420 +/- ##
==========================================
- Coverage 24.02% 24.01% -0.02%
==========================================
Files 1385 1392 +7
Lines 102185 102293 +108
Branches 38950 38988 +38
==========================================
+ Hits 24555 24567 +12
- Misses 75167 75256 +89
- Partials 2463 2470 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request.
Please fix launch/tier4_map_launch/package.xml
🙏
+ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
tier4_map_launch: Cannot locate rosdep definition for [map_projection_loader]
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@SakodaShintaro Sorry for overlooking the |
@a-maumau Sorry, could you resolve some conflicts? |
@SakodaShintaro I have resolved the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator works well and the mean error is almost the same as before.
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Add
autoware::
tonamespace
. - Add
autoware
folder as necessary and update include statements accordingly.
- Add
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
@kosuke55 @takayuki5168 |
…utoware (autowarefoundation#8420) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
…utoware (autowarefoundation#8420) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Description
This PR will add the
autoware_
prefix tomap_projection_loader
.This PR will affect
Related links
Parent Issue:
How was this PR tested?
Confirmed with running sample-map.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.