Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): update params for dynamic parameter setting #616

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Apr 1, 2022

Description

Fix the bug caused by the following commit.
#609

  • Member variables were not initialized for dynamically parameters setting

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

mkuri and others added 11 commits March 30, 2022 21:51
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@mkuri mkuri closed this Apr 1, 2022
@mkuri mkuri deleted the feature/load-smoother-params-from-node-instances branch November 27, 2022 08:21
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jul 3, 2023
* feat(avoidance): add hysteresis to avoidance necessity check (autowarefoundation#3880)

* feat(avoidance): add hysteresis factor to avoid necessity check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance_by_lc): add hysteresis factor to avoid necessity check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(utils): use lambda

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve stop behavior under decel/jerk constraints option (autowarefoundation#3978)

* feat(avoidance): add option to decel within constraints

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add comments

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(utils): merge similar functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): can set stop/move judge threshold for each object class (autowarefoundation#3998)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): ignore behind unavoidable objects (autowarefoundation#4034)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve avoidance judgement logic for pedestrian & bicycle (autowarefoundation#4016)

* feat(avoidance): don't avoid pedestrian and bicycle on crosswalk

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): avoid pedestrian/bicycle near centerline

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(utils): use geometry distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add comment

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): ignore objects less than execution threshold (autowarefoundation#3595)

fix(avoidance): ignore objects whose shift length is less than execution threshold

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): not init rtc status at onProcessEntry (autowarefoundation#3804)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update logic to keep waiting approval (autowarefoundation#4059)

* revert "fix(avoidance): don't clear waiting approval if raw shift line exists (autowarefoundation#4012)"

This reverts commit 8577563.

* fix(avoidance): update logic to keep waiting approval

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix invalid cherry pick

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
doc: use GitHub instead of Github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant