-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity): add velocity smoother to behavior velocity #497
feat(behavior_velocity): add velocity smoother to behavior velocity #497
Conversation
@@ -162,6 +163,10 @@ BehaviorVelocityPlannerNode::BehaviorVelocityPlannerNode(const rclcpp::NodeOptio | |||
if (this->declare_parameter("launch_stop_line", true)) { | |||
planner_manager_.launchSceneModule(std::make_shared<StopLineModuleManager>(*this)); | |||
} | |||
// to calculate ttc it's better to be after stop line | |||
if (this->declare_parameter("launch_occlusion_spot", true)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move module order to insert stop line at the end before calculation of ttc.
3af159f
to
534936f
Compare
Codecov Report
@@ Coverage Diff @@
## main #497 +/- ##
==========================================
- Coverage 10.72% 10.68% -0.05%
==========================================
Files 729 730 +1
Lines 51118 51337 +219
Branches 6596 6596
==========================================
Hits 5484 5484
- Misses 41174 41393 +219
Partials 4460 4460
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
* Porting remote cmd selector (autowarefoundation#1286) * Feature/add remote cmd selector (autowarefoundation#1179) * Add in/out args of remote_cmd_converter.launch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change remote input topic of vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add msgs for remote_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_cmd_selector to external_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove VehicleCommand support in autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix porting miss Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix missing function * modify xml format * fix include guard * add callback group * modify remap name * Revert "modify remap name" This reverts commit 169cc8d28442825b1d61b0439b9892c913304527. * change topic name * use rclcpp_component * Remove autoware_debug_msgs from autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default mode of autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix ament (autowarefoundation#1307) * Ros2/create/external commands (autowarefoundation#1299) * add remote message * add remote commands * fix topic * remove unnecessary topic * remove unused topic * add external cmd instead * ToExternalComd * fix topic in joy con * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * suppress warnings for control packages (autowarefoundation#1892) * add Werror * add maybe unused * Add autoware api (autowarefoundation#1979) * Move launch file of external_cmd_selector (autowarefoundation#2017) * Move launch file of external_cmd_selector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add copyright Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use DeclareLaunchArgument Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix external command api name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Move common parameters Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030) * Use EmergencyState instead of deprecated EmergencyMode Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use stamped type Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Improve diagnostic tree for future extensions (autowarefoundation#2153) * change resource monitoring group * implement diagnostic tree proposal * rename v2x param file * add v2x to launch * add dummy analyzer to avoid format error * modify external control * rename vehicle_ecu_errors * fixup * remove num_items * fix error * add heartbeat to external command selector * Restore sensing/node_alive_monitoring * Update system/autoware_error_monitor/config/diagnostic_aggregator/sensing.param.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * add sensor_kit arg for diagnostic_agg * change sensor_kit's default value * add _ prefix to hide parameter file * delete dummy parameter * change to use update_functions * add extra_agg_config_file_vehicle * change initializer * remove line * Update system/autoware_error_monitor/config/diagnostic_aggregator/system.param.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * change hearbeat diag * add clock group * update sensing diag * Remove discard and v2x Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix heartbeat name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_control to external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename command_gate to control_command_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Simplify resource monitoring Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove sensing from autoware_error_monitor.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove trajectory_deviation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove vehicle specific settings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add blank lines Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore matching_score error Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove debug_data_logger Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add trajectory_validation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Specify children for performance_monitoring Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Comment out route_validation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Revert "Remove trajectory_deviation" This reverts commit 199132f1a6c7083440f0ef9a956b0663d45f4531. * Remove control_command_topic_status Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Disable some diagnostics for planning simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add TODO comment Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Enable /autoware/vehicle/node_alive_monitoring in planning simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix missing dependency of external_cmd_selector (autowarefoundation#2324) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port part of external_cmd_selector (autowarefoundation#497) * port part of external_cmd_selector Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * add convert function Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * port signal Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * Update control/external_cmd_selector/include/external_cmd_selector/external_cmd_selector_node.hpp Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix publisher in external_cmd_selector (autowarefoundation#676) Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
534936f
to
53fb95d
Compare
53fb95d
to
7d2b09b
Compare
69417f2
to
81f6e7f
Compare
…other to behavior velocity
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
81f6e7f
to
e11b4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked how the smoother is generated and how each member functions are used.
LGTM
…497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…utowarefoundation#497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…utowarefoundation#497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…ier4#497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…ier4#497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…ier4#497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
…ier4#497) * feat(behavior_velocity): add external velocity limit and velocity smoother to behavior velocity * feat(behavior_velocity): add smooth method Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): apply experimental feedback Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
* fix: fix typo vender -> vendor (#504) * chore: sync files (#497) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * fix: use hash for Autoware's Ansible Galaxy (#506) * chore: remove kvaser role (#491) * chore: remove kvaser roles (#145) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix: remove kvaser role (#146) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * chore: sync files (#507) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * Update ansible-galaxy-requirements.yaml Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…towarefoundation#497) * fix(transformPointCloud): use tier4_autoware_utils instead of pcl * Update ndt_scan_matcher_core.cpp * comment out
Related Issue(required)
#258
#383
Description(required)
move stop line module before occlusion spot here
chore: sync awf/autoware_launch tier4/autoware_launch#238
use velocity smoother in this PR
smooth method is below
pass_judge option is going to be enable for this PR "smooth_velocity" is available
Review Procedure(required)
Review Procedure(required)
with #497
occlusion-2022-03-16_11.49.23.mp4
occlusion-2022-03-16_11.58.45.mp4
Related PR(optional)
FYI: @TakaHoribe
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks