Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformPointCloud): use tier4_autoware_utils instead of pcl #497

Merged
merged 3 commits into from
May 24, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 19, 2023

Description

autowarefoundation#3359 のbackportとして、必要な部分をピックアップして適用する
なお、tier4_autoware_utilsのパッケージに手を加える場合影響範囲が膨大なため、修正が必要な箇所のみの対応とする

Related Links

https://tier4.atlassian.net/browse/AEAP-517

Tests performed

  • ビルドが問題ないこと
  • コード内に存在している pcl::transformPointCloudが tier4_autoware_utils::transformPointCloudに変更されていること
  • planning_simulatorで自己位置およびゴールを設定した際にbehavior_velocity_plannerが強制終了しないこと

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta force-pushed the fix/pcl_transform branch from 19b60cd to 9606698 Compare May 19, 2023 01:39
@h-ohta h-ohta force-pushed the fix/pcl_transform branch from d332787 to 17fd448 Compare May 19, 2023 03:44
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.16@79db463). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #497   +/-   ##
==============================================
  Coverage                ?   5.54%           
==============================================
  Files                   ?      79           
  Lines                   ?    6280           
  Branches                ?     576           
==============================================
  Hits                    ?     348           
  Misses                  ?    5714           
  Partials                ?     218           
Flag Coverage Δ
differential 5.54% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta h-ohta marked this pull request as ready for review May 19, 2023 08:47
Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • ビルドOK.
  • pcl::transformPointCloudのtier4_autoware_utils::transformPointCloudへの置き換えOK。
    • 残存するpcl::transformPointCloudはtier4_autoware_utils::transformPointCloudにてラッパーされているか、IGNOREされているモジュールであることを確認。
  • 修正前に発生していた以下のノード突然死が解消されており、自己位置設定から目的の到着までできること確認済。
    1684462951.7480030 [ERROR] [component_container_mt-24]: process has died [pid 405716, exit code -8, cmd '/opt/ros/humble/lib/rclcpp_components/component_container_mt --ros-args -r __node:=behavior_planning_container -r __ns:=/planning/scenario_planning/lane_driving/behavior_planning -p use_sim_time:=False -p wheel_radius:=0.258 -p wheel_width:=0.145 -p wheel_base:=1.335 -p wheel_tread:=0.955 -p front_overhang:=0.53 -p rear_overhang:=0.375 -p left_overhang:=0.0725 -p right_overhang:=0.0725 -p vehicle_height:=1.87 -p max_steer_angle:=0.64'].

@h-ohta h-ohta merged commit f70128b into beta/v0.3.16 May 24, 2023
@h-ohta h-ohta deleted the fix/pcl_transform branch May 24, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants