fix(tensor-rt): allow deprecated declarations for some tensorrt packages #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
xmfcx
requested review from
wep21,
a team,
yukke42 and
manato
as code owners
github-actions
bot
added
component:common
|
This is a very simple and non-destructive change PR, I'd appreciate if we can merge it soon. |
4 tasks
Codecov ReportBase: 11.29% // Head: 10.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
==========================================
- Coverage 11.29% 10.99% -0.30%
==========================================
Files 1168 1220 +52
Lines 81842 84007 +2165
Branches 20938 20938
==========================================
Hits 9240 9240
- Misses 62738 64903 +2165
Partials 9864 9864
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Dec 21, 2022
kenji-miyake
approved these changes
Dec 22, 2022
yukke42
approved these changes
Dec 22, 2022
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…ges (autowarefoundation#2559) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai
Description
Part of: #2330
Until we upgrade the packages, we can allow deprecated declarations in
CMakeLists.txtfiles of the respective packages.I've compiled all with latest TensorRT 8.5 and it compiles fine. I've also checked the
traffic_light_ssd_fine_detectorand it seems to be working just fine in latest version.I went for this quick fix because updating enqueueV2 to enqueueV3 was complicated for me, I didn't want to spend more time on it.
I was going to add updated and deprecated codes together like I did in #2325 but
enqueueV3part didn't work as I expected and I didn't want to spend more time on it.This simple fix should be ok until someone with better experience can take on the rest of issues.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.