Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt): update tensorrt code of traffic_light_classifier #2325

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 18, 2022

Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai

Description

Part of: #2330

Updating the code to compile with https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/ TensorRT version.

We can remove the deprecated code when we update the ansible installation to use native 22.04 cuda.

Updated TensorRT version is tensorrt-dev_8.5.1.7-1+cuda11.8 for now.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 18, 2022
@xmfcx xmfcx requested a review from kenji-miyake November 18, 2022 16:41
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 18, 2022

Currently compiles on my machine withtensorrt-dev_8.5.1.7-1+cuda11.8 from https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/

@kenji-miyake
Copy link
Contributor

@xmfcx Thank you for updating the interfaces!
How about labeling these PRs and create an issue for tracking?

@xmfcx xmfcx self-assigned this Nov 19, 2022
@xmfcx xmfcx added the ros:humble ROS Humble Hawksbill release. label Nov 19, 2022
@xmfcx xmfcx force-pushed the update-traffic-light-classifier-trt branch from 7932302 to cbb0fea Compare December 16, 2022 14:59
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 10.54% // Head: 10.54% // No change to project coverage 👍

Coverage data is based on head (825ef16) compared to base (ee9a389).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   10.54%   10.54%           
=======================================
  Files        1266     1266           
  Lines       87617    87617           
  Branches    20952    20952           
=======================================
  Hits         9242     9242           
  Misses      68512    68512           
  Partials     9863     9863           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.54% <0.00%> (ø) Carriedforward from bdfcbdb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the update-traffic-light-classifier-trt branch from cbb0fea to bdfcbdb Compare December 19, 2022 21:57
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 19, 2022

Screenshot from 2022-12-20 00-55-39

I've changed the code to support old and new versions.

Tested for the new TensorRT 8.5.2 version and it works.

Should work for the old version too, the changes are very minimal for this.

@xmfcx xmfcx marked this pull request as ready for review December 19, 2022 22:00
@xmfcx xmfcx requested review from yukkysaito and a team as code owners December 19, 2022 22:00
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 19, 2022

@yukkysaito could you review please? The changes are fairly small.

@yukkysaito
Copy link
Contributor

yukkysaito commented Dec 20, 2022

@xmfcx Thank you 👍
LGTM
cc @Mingyu1991 @miursh

@yukkysaito yukkysaito requested a review from miursh December 20, 2022 02:01
@xmfcx xmfcx enabled auto-merge (squash) December 20, 2022 07:18
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx disabled auto-merge December 20, 2022 07:40
@xmfcx xmfcx enabled auto-merge (squash) December 20, 2022 07:40
@xmfcx xmfcx merged commit 2be41d7 into main Dec 20, 2022
@xmfcx xmfcx deleted the update-traffic-light-classifier-trt branch December 20, 2022 07:50
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 22, 2022
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…warefoundation#2325)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) ros:humble ROS Humble Hawksbill release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants