Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt): update tensorrt code of lidar_centerpoint #2328

Closed
wants to merge 1 commit into from

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 18, 2022

Description

Part of: #2330

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 18, 2022
@xmfcx xmfcx force-pushed the update-lidar-centerpoint-trt branch from ebdb9dd to 078da41 Compare November 18, 2022 19:28
@xmfcx xmfcx self-assigned this Nov 19, 2022
@xmfcx xmfcx added the ros:humble ROS Humble Hawksbill release. label Nov 19, 2022
@xmfcx xmfcx force-pushed the update-lidar-centerpoint-trt branch from 078da41 to e43919e Compare December 16, 2022 15:00
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 11.29% // Head: 11.16% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (d8c5025) compared to base (9376697).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   11.29%   11.16%   -0.13%     
==========================================
  Files        1168     1196      +28     
  Lines       81842    82733     +891     
  Branches    20938    20938              
==========================================
  Hits         9240     9240              
- Misses      62738    63629     +891     
  Partials     9864     9864              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.29% <ø> (ø) Carriedforward from 9376697

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ude/lidar_centerpoint/network/tensorrt_wrapper.hpp 0.00% <ø> (ø)
...rception/lidar_centerpoint/lib/centerpoint_trt.cpp 0.00% <ø> (ø)
.../include/lidar_centerpoint/network/network_trt.hpp 0.00% <0.00%> (ø)
...ar_centerpoint/lib/preprocess/preprocess_kernel.cu 0.00% <0.00%> (ø)
...on/lidar_centerpoint/src/single_inference_node.cpp 0.00% <0.00%> (ø)
...ion/src/pointpainting_fusion/pointpainting_trt.cpp 0.00% <0.00%> (ø)
...ed_fusion/pointpainting_fusion/voxel_generator.hpp 0.00% <0.00%> (ø)
...oint/include/lidar_centerpoint/centerpoint_trt.hpp 0.00% <0.00%> (ø)
...on/lidar_centerpoint/lib/network/scatter_kernel.cu 0.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xmfcx xmfcx force-pushed the update-lidar-centerpoint-trt branch from e43919e to 9353626 Compare December 21, 2022 17:44
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the update-lidar-centerpoint-trt branch from 9353626 to d8c5025 Compare December 21, 2022 18:57
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 21, 2022

Same as #2326 (comment)

I've created this PR to be compatible with both versions. But as I was updating the code, I am stuck in updating enqueueV2 to enqueueV3 and updated version doesn't work.

Temporarily I've created #2559 to temporarily have it working. But I hope someone more experienced on TensorRT can help or take over this task.

More info on:

cc @wep21

@stale
Copy link

stale bot commented Feb 19, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 19, 2023
@xmfcx xmfcx closed this Jun 19, 2023
@xmfcx xmfcx deleted the update-lidar-centerpoint-trt branch June 25, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) ros:humble ROS Humble Hawksbill release. status:stale Inactive or outdated issues. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant