feat(tier4_localization_launch): pass pc container to localization #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
3 tasks
4 tasks
kaancolak
changed the title
YamatoAndo
added
the
component:localization
|
If it's okay for @YamatoAndo, I believe it's okay! |
|
@kaancolak Could you please update the |
|
@kaancolak Is it necessary to add |
3 tasks
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
4 tasks
YamatoAndo
reviewed
Nov 7, 2022
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Codecov ReportBase: 10.78% // Head: 10.78% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
=======================================
Coverage 10.78% 10.78%
=======================================
Files 1179 1179
Lines 84449 84449
Branches 19795 19795
=======================================
Hits 9104 9104
Misses 65853 65853
Partials 9492 9492
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
YamatoAndo
approved these changes
Nov 7, 2022
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…utowarefoundation#2114) * feature(tier4_localization_launch): pass pc container to localization Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * ci(pre-commit): autofix * feature(tier4_localization_launch): update util.launch.xml Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * feature(tier4_localization_launch): update use container param value Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…utowarefoundation#2114) * feature(tier4_localization_launch): pass pc container to localization Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * ci(pre-commit): autofix * feature(tier4_localization_launch): update util.launch.xml Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * feature(tier4_localization_launch): update use container param value Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…utowarefoundation#2114) * feature(tier4_localization_launch): pass pc container to localization Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * ci(pre-commit): autofix * feature(tier4_localization_launch): update util.launch.xml Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * feature(tier4_localization_launch): update use container param value Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaan Colak kcolak@leodrive.ai
Description
Make it possible to pass
pointcloud_containerto velodyne nodes.Under tier4_localization_launch utils, some preprocessor nodes uses velodyne container. If velodyne drivers use pointcloud_container use it, otherwise use default one
/sensing/lidar/top/pointcloud_preprocessor/pointcloud_containerThis issue must be merged after this PR : autowarefoundation/sample_sensor_kit_launch#48
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.