feat(sample_sensor_kit_launch): pass container to velodyne nodes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
kaancolak
force-pushed
the
feature/pass-container-to-velodyne-node
branch
from
1264c41 to
b1273fa
Compare
kaancolak
changed the title
4 tasks
3 tasks
|
Hello @mitsudome-r Mitsudome-san, Relevant PR was merged today: autowarefoundation/autoware.universe#2114 Could you review this PR? without these changes, localization will work own container. |
|
@mitsudome-r ping |
4 tasks
mitsudome-r
approved these changes
Dec 13, 2022
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Thanks, Mitsudome-san. I applied your suggestion. |
|
@kaancolak @YamatoAndo Are there any other issues before merging this PR? (Sorry if I couldn't catch up related discussions) |
3 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaan Colak kcolak@leodrive.ai
Description
Working with an individual container for each lidar increases network traffic and CPU utilization. Make it possible to pass
pointcloud_containerto Velodyne nodes.When working with logging_simulator.launch.xml, it decreased network utilization around ~30-40 MB/s .
When setting
launch_driver:=trueonlogging_simulator.launch.xmlorautoware.launch.xmlit looks working without problem, but needs to test with real device. I will test it to make sure multiple velodyne drivers working in the same container with different namespaces without any problems.Relevant issues and PR :
autowarefoundation/autoware.universe#1228
autowarefoundation/autoware.universe#2114
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.