[BEAM-121] Add DisplayData for IO transforms #123
Conversation
| @@ -326,6 +327,14 @@ | |||
| } | |||
|
|
|||
| @Override | |||
| public void populateDisplayData(DisplayData.Builder builder) { | |||
| builder.add("schema", type); | |||
There was a problem hiding this comment.
What happens here? type is a Class. Will it just get automatically converted to a String?
I would probably just drop the type. We aren't planning to specify the Coder for each transform as static metadata, are we?
There was a problem hiding this comment.
Class ends up being a common metadata type, so we support it first-class for display metadata. We'll use the class name (and shortName) for UI.
No, we aren't specifying a coder for each transform.
I had assumed the schema information is important-- is that true? If so, is this the best way to capture it?
There was a problem hiding this comment.
In this case, the schema is effectively the Coder. I would not include it unless you plan to include the coder.
swegner
force-pushed
the
displaydata-io
branch
3 times, most recently
from
1c4f9c4 to
1ecbe63
Compare
|
Ok, I believe I've addressed the feedback thusfar. @dhalperi, mind taking another look? |
swegner
force-pushed
the
displaydata-io
branch
2 times, most recently
from
b817a25 to
56306dd
Compare
|
Backported via GoogleCloudPlatform/DataflowJavaSDK#218 |
#! [euphoria-examples] Provide some more explanatory comments
* refactor: move generated client instantiation out of base class * feat: integrate microgen async client to client * feat: make collections call backed by async * fix: failing asyncmock assertion * refactor: remove unused install * fix: lint * refactor: shared functionality in client to base class * refactor: move AsyncMock to test helpers * fix: return type in client docs * feat: integrate microgen async client to collection * fix: lint * feat: integrate microgen async client to document * feat: integrate microgen async client to batch * fix: use AsyncMock for batch async tests: * fix: collection and document testing batch * feat: integrate microgen async client to transaction * fix: remove unused imports
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.