Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RunInference api into base #21792

Closed
wants to merge 2 commits into from

Conversation

yeandy
Copy link
Contributor

@yeandy yeandy commented Jun 10, 2022

Moving RunInference transform from api.py into base.py.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 10, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented Jun 10, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 10, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 10, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 10, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #21792 (a273b05) into master (0de9821) will increase coverage by 0.02%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master   #21792      +/-   ##
==========================================
+ Coverage   74.01%   74.04%   +0.02%     
==========================================
  Files         698      698              
  Lines       92224    92337     +113     
==========================================
+ Hits        68263    68373     +110     
- Misses      22710    22713       +3     
  Partials     1251     1251              
Flag Coverage Δ
python 83.62% <82.35%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...examples/inference/pytorch_image_classification.py 0.00% <0.00%> (ø)
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/__init__.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/ml/inference/base.py 94.24% <100.00%> (+0.54%) ⬆️
...thon/apache_beam/ml/inference/sklearn_inference.py 92.50% <100.00%> (ø)
...eam/transforms/py_dataflow_distribution_counter.py 91.42% <0.00%> (-4.87%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/utils/counters.py 85.39% <0.00%> (-1.36%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de9821...a273b05. Read the comment docs.

@yeandy yeandy closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants