-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark issues as triaged when they are assigned #21790
Mark issues as triaged when they are assigned #21790
Conversation
Can one of the admins verify this patch? |
4 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
@@ -32,6 +32,7 @@ jobs: | |||
echo "Assigning issue $ISSUE_NUMBER to $LOGIN" | |||
echo "Using the link: https://api.github.com/repos/$REPO/issues/$ISSUE_NUMBER/assignees" | |||
curl -H "Authorization: token $GITHUB_TOKEN" -d '{"assignees":["'"$LOGIN"'"]}' https://api.github.com/repos/$REPO/issues/$ISSUE_NUMBER/assignees | |||
curl -X DELETE -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/repos/$REPO/issues/$ISSUE_NUMBER/labels/awaiting%20triage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This might feel redundant since we're also assigning the issue, which might lead you to expect the other workflow to trigger and do this. That won't happen because GitHub doesn't trigger any events that were initiated by the github bot itself to infinite trigger loops.
R: @kennknowles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine. My first look at these files. Is shell script and curl really the best option for interacting here? Not a problem now but it raises the complexity bar for drop-in changes for a lot of people I think. Like python or javascript with a GH API library might be an option if things get any more complex?
Yeah, in general I agree (and that's what I've done for most actions things), for shorter ones like these bash is nice though because its one less layer of indirection. If we did anything beyond string matching and a curl request (which comes straight from the docs https://docs.github.com/en/rest/issues/labels#remove-a-label-from-an-issue), I'd want to move it out. FWIW, Javascript has a built in gh client that is pretty easy to use (e.g.
|
Codecov Report
@@ Coverage Diff @@
## master #21790 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 698 698
Lines 92224 92224
=======================================
Hits 68263 68263
Misses 22710 22710
Partials 1251 1251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This automatically marks issues that have been assigned as not awaiting triage. Example of this working and removing the label when it should, and not removing it when it shouldn't
Part of #21684
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.