-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JdbcIOIT, which seems to have never worked #21796
Conversation
Run Java JdbcIO Performance Test |
Running with 1000 rows: https://ci-beam.apache.org/job/beam_PerformanceTests_JDBC/6514/ |
Running with numrows parameter: https://ci-beam.apache.org/job/beam_PerformanceTests_JDBC/6515/ |
Run Java JdbcIO Performance Test |
2 similar comments
Run Java JdbcIO Performance Test |
Run Java JdbcIO Performance Test |
Run Java JdbcIO Performance Test |
Got
and then
|
@pabloem are you still working on this PR? |
2843ed2
to
816db93
Compare
Run Java JdbcIO Performance Test |
ok I'll try to drive this PR to be complete |
Thanks Pablo |
Run Java JdbcIO Performance Test |
1 similar comment
Run Java JdbcIO Performance Test |
Run Java JdbcIO Performance Test |
Run Java JdbcIO Performance Test |
Run Java PreCommit |
Run Java JdbcIO Performance Test |
Testing once more to check reliability |
Run Java JdbcIO Performance Test |
Run Java PreCommit |
r: @johnjcasey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
run java precommit |
LGTM |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.