Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JdbcIOIT, which seems to have never worked #21796

Merged
merged 8 commits into from
Oct 3, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Jun 10, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member Author

pabloem commented Jun 10, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Jun 10, 2022

@pabloem
Copy link
Member Author

pabloem commented Jun 10, 2022

Running with numrows parameter: https://ci-beam.apache.org/job/beam_PerformanceTests_JDBC/6515/

@pabloem
Copy link
Member Author

pabloem commented Jun 14, 2022

Run Java JdbcIO Performance Test

2 similar comments
@pabloem
Copy link
Member Author

pabloem commented Jun 14, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Jun 21, 2022

Run Java JdbcIO Performance Test

@pabloem pabloem closed this Jun 21, 2022
@pabloem pabloem reopened this Jun 21, 2022
@Abacn
Copy link
Contributor

Abacn commented Jul 14, 2022

Run Java JdbcIO Performance Test

@Abacn
Copy link
Contributor

Abacn commented Jul 14, 2022

Got

org.apache.beam.sdk.io.jdbc.JdbcIOIT > testWriteWithAutosharding FAILED
    java.lang.OutOfMemoryError: Java heap space

and then

org.apache.beam.sdk.io.jdbc.JdbcIOIT > testWriteThenRead FAILED
    java.lang.RuntimeException: Failed to create a workflow job: The size of the serialized JSON representation of the pipeline exceeds the allowable limit. For more information, please see the documentation on job submission:

@johnjcasey
Copy link
Contributor

@pabloem are you still working on this PR?

@pabloem
Copy link
Member Author

pabloem commented Sep 14, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2022

ok I'll try to drive this PR to be complete

@johnjcasey
Copy link
Contributor

Thanks Pablo

@pabloem
Copy link
Member Author

pabloem commented Sep 29, 2022

Run Java JdbcIO Performance Test

1 similar comment
@pabloem
Copy link
Member Author

pabloem commented Sep 29, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Sep 29, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Sep 29, 2022

Run Java JdbcIO Performance Test

@pabloem pabloem marked this pull request as ready for review September 30, 2022 00:11
@pabloem
Copy link
Member Author

pabloem commented Sep 30, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Sep 30, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Sep 30, 2022

Testing once more to check reliability

@pabloem
Copy link
Member Author

pabloem commented Sep 30, 2022

Run Java JdbcIO Performance Test

@pabloem
Copy link
Member Author

pabloem commented Sep 30, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Sep 30, 2022

r: @johnjcasey
feel free to review or delegate : )

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@johnjcasey
Copy link
Contributor

run java precommit

@johnjcasey
Copy link
Contributor

LGTM

@johnjcasey johnjcasey merged commit dc58a46 into apache:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants