-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hadoop Downloader Range not correct #21778
Conversation
* This fixes ValueError happens when reading a hdfs of file size larger than buffer size * Added related unit test
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #21778 +/- ##
==========================================
+ Coverage 74.03% 74.43% +0.40%
==========================================
Files 698 699 +1
Lines 92192 93717 +1525
==========================================
+ Hits 68252 69756 +1504
- Misses 22689 22710 +21
Partials 1251 1251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
retest this please |
R: @chamikaramj |
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the quick fix. I can merge when tests pass. |
Run Python PreCommit |
Run RAT PreCommit |
Run Python PreCommit |
1 similar comment
Run Python PreCommit |
* Fix Hadoop Downloader Range not correct * This fixes ValueError happens when reading a hdfs of file size larger than buffer size * Added related unit test * fix typo in comment
This fixes #20110
This fixes ValueError happens when reading a hdfs of file size larger than buffer size
Added related unit test
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.