Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading & docs #206

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Update heading & docs #206

merged 2 commits into from
Feb 9, 2021

Conversation

chris-gds
Copy link
Contributor

@chris-gds chris-gds commented Feb 8, 2021

What?

Update govspeak contact information to remove bold

Why?

Contact information should not be in bold. This is confusing as it looks like a heading but is not (WCAG 1.3.1). Also at present it is a h3 which wasn't always accurate in terms of a h2 always being before it in the context of the page

Visual Changes

Before (left) After (right)
image

Anything else?

govspeak is used by the gem there is a dependant PR here.

@chris-gds chris-gds requested a review from maxgds February 8, 2021 14:49
@chris-gds chris-gds marked this pull request as ready for review February 8, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants