Remove headline on govspeak #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-gds
force-pushed
the
update-to-govspeak
branch
9 times, most recently
from
dfd1080 to
d25af70
Compare
Changing h3 to p from Contact address while using govspeak as this could appear anywhere in the page and the h3 might not be in a logical order therefore causing an a11y issue + updating tests
chris-gds
force-pushed
the
update-to-govspeak
branch
from
d25af70 to
5d46e3c
Compare
injms
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Altering headline on Contact address while using
govspeakWhy?
This could appear anywhere in the page and therefore the heading tag might not be in a logical order causing an a11y issue.
How to test
On the Whitehall publisher App:
Integration Link
Dev link
Use something like:
u[Contact:1]in body to create a new Contact snippet and preview the result.Visuals
After > Before
Anything else?
Other examples appear here:
/world/organisations/british-antarctic-territory(Dev link)Before > After
Related PR