Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading & docs #206

Merged
merged 2 commits into from
Feb 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,8 @@ will output
```html
<div id="contact_123" class="contact">
<div class="content">
<h3>Government Digital Service</h3>
<div class="vcard contact-inner">
<p>Government Digital Service</p>
<div class="email-url-number">
<p class="email">
<span class="type">Email</span>
Expand Down
2 changes: 1 addition & 1 deletion lib/templates/contact.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
%>
<div id="contact_<%= contact.content_id %>" class="<%= ['contact', extra_class].flatten.join(' ') %>">
<div class="content">
<h3><%= contact.title %></h3>
<div class="vcard contact-inner">
<p><%= contact.title %></p>
chris-gds marked this conversation as resolved.
Show resolved Hide resolved
<% contact.post_addresses.each do |address| %>
<%= Govspeak::HCardPresenter.new(address).render %>
<% end %>
Expand Down
4 changes: 2 additions & 2 deletions test/govspeak_contacts_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def compress_html(html)
expected_html_output = %(
<div id="contact_4f3383e4-48a2-4461-a41d-f85ea8b89ba0" class="contact postal-address">
<div class="content">
<h3>Government Digital Service</h3>
<div class="vcard contact-inner">
<p>Government Digital Service</p>
<p class="adr">
<span class="street-address">125 Kingsway</span><br>
<span class="locality">Holborn</span><br>
Expand Down Expand Up @@ -106,8 +106,8 @@ def compress_html(html)
expected_html_output = %(
<div id="contact_4f3383e4-48a2-4461-a41d-f85ea8b89ba0" class="contact">
<div class="content">
<h3>Government Digital Service</h3>
<div class="vcard contact-inner">
<p>Government Digital Service</p>
<div class="email-url-number">
<p class="email">
<span class="type">Email</span>
Expand Down