Update contact heading #1909
Merged
Update contact heading #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove CSS, update docs
maxgds
approved these changes
Feb 9, 2021
alex-ju
added a commit
that referenced
this pull request
Feb 9, 2021
* Bump govuk-frontend from 3.10.2 to 3.11.0 ([PR #1911](#1911)) * Rescope Brexit CTA on contextual sidebar ([PR #1910](#1910)) * Update `govspeak` contact heading ([PR #1909](#1909)) * Remove `listenForCrossOriginMessages` from CookieBanner ([PR #1906](#1906)) * Further step by step nav sidebar design updates ([PR #1893](#1893)) * Add rel attribute option to document list ([PR #1903](#1903)) * BREAKING: Remove chevron banner component ([PR #1873](#1873)) * BREAKING: Retire gem-level SCSS variables ([PR #1881](#1881)) * BREAKING: Remove duplicate `lib/auto-track-event` script ([PR #1894](#1894)) * BREAKING: Remove copies of files ([PR #1878](#1878)) * BREAKING: Remove list stylesheet ([PR #1874](#1874))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update
govspeakcontact information to remove boldWhy?
Contact information should not be in bold. This is confusing as it looks like a heading but is not: (WCAG 1.3.1) Also at present it is a
h3which wasn't always accurate in terms of ah2always being before it in the context of the page.Visual Changes
Before (left) After (right)
Anything else?
The gem absorbs
govspeakthere is a dependant PR here.