Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Update contact headings #1048

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Update contact headings #1048

merged 1 commit into from
Mar 2, 2021

Conversation

chris-gds
Copy link
Contributor

@chris-gds chris-gds commented Feb 25, 2021

What?

Updating schemas to reflect work done on this PR alphagov/govspeak#206

Why?

Headings have been changed to paragraph copy within contact information due to a11y. They shouldn't be bold as it looks like a heading but is not also the h3 is not always correct when used in the flow of a document

Anything else?

Live Ref page
https://www.gov.uk/government/news/new-voluntary-calorie-guidelines-to-help-industry-tackle-obesity

image

image

<h3>s have been moved + changed to <p> within contact information due to a11y.  They shouldn't be bold and the h3 is not always correct when used in the flow of a document.
@chris-gds chris-gds force-pushed the update-govspeak-contact branch from 256bb0a to 4e77ce9 Compare February 25, 2021 13:15
@chris-gds chris-gds requested a review from alex-ju March 1, 2021 15:27
@chris-gds chris-gds marked this pull request as ready for review March 1, 2021 15:27
Copy link

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating these examples makes sense after updating govspeak to replace the heading with a paragraph.

However, I think there is a tradeoff with the change itself. I understand there were problems with the heading level, but with this change, people will find it harder to reach the contact details using the landmark navigation.

@chris-gds
Copy link
Contributor Author

chris-gds commented Mar 2, 2021

However, I think there is a tradeoff with the change itself. I understand there were problems with the heading level, but with this change, people will find it harder to reach the contact details using the landmark navigation.

🤔 I take your point, ideally this entire contact section needs something so a user can easily navigate to it. First thoughts are thinking <section> & <address> would aid with this. Will revisit.

@alex-ju
Copy link

alex-ju commented Mar 2, 2021

However, I think there is a tradeoff with the change itself. I understand there were problems with the heading level, but with this change, people will find it harder to reach the contact details using the landmark navigation.

🤔 I take your point, ideally this entire contact section needs something so a user can easily navigate to it. First thoughts are thinking <section> & <address> would aid with this. Will revisit.

Indeed, the contact section could be improved with semantic markup and microdata, but I'm not sure if it's in the scope of this work.

@chris-gds
Copy link
Contributor Author

Captured suggestions for prioritisation by PM

@chris-gds chris-gds merged commit b59aff1 into master Mar 2, 2021
@chris-gds chris-gds deleted the update-govspeak-contact branch March 2, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants