Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in current master 02-19-2018 #4

Merged
merged 355 commits into from
Feb 19, 2018
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jan 15, 2018

  1. Moved leadingpaddingnandborder function as a method on YGNode

    Reviewed By: emilsjolander
    
    Differential Revision: D6711991
    
    fbshipit-source-id: 41ad7191bf8df6fe3131106436dc0c87e9dee297
    priteshrnandgaonkar authored and facebook-github-bot committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    831a1bb View commit details
    Browse the repository at this point in the history
  2. Removed unused core from Image.android.js

    Summary: Trivial.
    
    Reviewed By: sahrens
    
    Differential Revision: D6721449
    
    fbshipit-source-id: 6ae001d4161167e0e86b1dc134c1621b3974b489
    shergin authored and facebook-github-bot committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    ce3146a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Exposing setDirtiedFunc as plain C function YGNodeSetDirtiedFunc

    Summary: Trivial. Those lines were lost during rebasing of the original commit.
    
    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D6717696
    
    fbshipit-source-id: a5dce25427c8977352b3ae7ea01e546a540e0c13
    shergin authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    6bb8617 View commit details
    Browse the repository at this point in the history
  2. Fix HMR syntax error messages (message instead of description)

    Summary:
    The code to display HMR errors on the client was reading the `description` field from Metro payloads. Metro does not include `description` in the body of its error payloads -- only in its `body.errors[]` items. This commit changes RN's HMR code to show `body.message` (set consistently with facebook/metro#124) instead of the non-existent `body.description`.
    
    Open a test RN app, enable HMR, and then introduce a syntax error in an app source file. See that the redbox provides information about the syntax error instead of just saying "TransformError undefined".
    
    - facebook/metro#124
    
    [GENERAL][ENHANCEMENT][HMR] - Fix display of syntax error messages when HMR is enabled
    Closes #17619
    
    Differential Revision: D6726516
    
    Pulled By: mjesun
    
    fbshipit-source-id: b1d1008d6f1aa8f88ff8a2aa1374724a305c773b
    ide authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    2b80cdf View commit details
    Browse the repository at this point in the history
  3. Revert D6704701: Refactor ReactViewGroup to reuse ReactViewBackground…

    …Manager
    
    Differential Revision: D6704701
    
    fbshipit-source-id: 01feb61a9c2c263f88cca4fea5978957c5e4767f
    mdvacca authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    1f5bb37 View commit details
    Browse the repository at this point in the history
  4. Remove SoLoaderShim, use SoLoader

    Summary:
    SoLoader is more stable on older versions of Android. Switching to it should fix recurring issues that we get such as `UnsatisfiedLinkError` and so on.
    
    CI + run showcase app.
    Closes facebook/fresco#1989
    
    Reviewed By: erikandre
    
    Differential Revision: D6556420
    
    Pulled By: foghina
    
    fbshipit-source-id: ffc3faef6452294b4d781258c64ef57e08d107b5
    foghina authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    fc6dd78 View commit details
    Browse the repository at this point in the history
  5. Fix for failing screenshot tests

    Reviewed By: emilsjolander
    
    Differential Revision: D6726745
    
    fbshipit-source-id: 99f91aabe2337b23953724545f97695238f2124e
    priteshrnandgaonkar authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    ee5c91c View commit details
    Browse the repository at this point in the history
  6. Removed broken link for 'Getting Help' in the README

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    I was going through the README and came across a broken link, so I needed to fix it.
    
    <!--
    (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
    -->
    <!--
    (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
    -->
    [ DOCS     ]   [ BROKEN LINK ]   [README.md]
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17620
    
    Differential Revision: D6727943
    
    Pulled By: hramos
    
    fbshipit-source-id: ef76d1e4847bc9b190a2076d64fa89a86ca9df93
    rickydam authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    b3a306a View commit details
    Browse the repository at this point in the history
  7. Use vector instead of linked list

    Reviewed By: emilsjolander
    
    Differential Revision: D6722959
    
    fbshipit-source-id: 4e81176802b9a9319bc5f385c824a06be14a83a2
    priteshrnandgaonkar authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    d0f7d4d View commit details
    Browse the repository at this point in the history
  8. Tweaking -[RCTSurface synchronouslyWaitForStage:]

    Summary: Waiting for layout is now available on main thread.
    
    Reviewed By: mmmulani
    
    Differential Revision: D6719836
    
    fbshipit-source-id: ef655095e999df5f77e69c5931459cce1aaeb1f0
    shergin authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    193a2bd View commit details
    Browse the repository at this point in the history
  9. Introduced -[RCTShadowView contentFrame]

    Summary:
    Another trivial sugar/helper to access computed by Yoga layout metrics.
    We will use it soon in the new Text render/layout engine.
    
    Reviewed By: mmmulani
    
    Differential Revision: D6671979
    
    fbshipit-source-id: d36933415c2fa50bae5cc171434d8f0b281955b7
    shergin authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    6882132 View commit details
    Browse the repository at this point in the history
  10. Add Bundle Splitting support for source code bundles

    Reviewed By: amnn
    
    Differential Revision: D6695431
    
    fbshipit-source-id: 76f4c09b7caadabad5b327af29c02afe61f31abd
    fromcelticpark authored and facebook-github-bot committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    9e34cbd View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. Upgrade connect dependency

    Reviewed By: cpojer
    
    Differential Revision: D6732727
    
    fbshipit-source-id: 80181ef184c90e3312789579034d70e2c3bcbf98
    rafeca authored and facebook-github-bot committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    709ede7 View commit details
    Browse the repository at this point in the history
  2. Update Jest to 22.1.2

    Differential Revision: D6736758
    
    fbshipit-source-id: fd6905e41abd1545b4847ad8ee6c12c7e5ce246e
    Miguel Jimenez Esun authored and facebook-github-bot committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    24e521c View commit details
    Browse the repository at this point in the history
  3. Move native accesses of array into one access instead of per-element

    Differential Revision: D6578349
    
    fbshipit-source-id: 84ebd66ed791a845e9cc0fbc7e12a377534aa903
    Kathy Gray authored and facebook-github-bot committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    5649aed View commit details
    Browse the repository at this point in the history
  4. move native accesses of map into two accesses instead of per-element

    Differential Revision: D6650192
    
    fbshipit-source-id: 0eb0719fd3b7813add33a3d4fe3fb70e6f375fd7
    Kathy Gray authored and facebook-github-bot committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    7891805 View commit details
    Browse the repository at this point in the history
  5. RN: Revert D6701597

    Reviewed By: mdvacca
    
    Differential Revision: D6735812
    
    fbshipit-source-id: 8144b72883150f9d7e2614ee0f238c1b8e44c6ab
    yungsters authored and facebook-github-bot committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    df2f335 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. Use boost-for-react-native CocoaPod

    Summary:
    Use the same header-only distribution of Boost that Android and the automatic ios-install-third-party.sh script uses. Greatly speeds up `pod install`, even when the distribution was already cached.
    
    The dependency tree looks like this:
    
    * React
      * cxxreact subspec
        * **Boost** (versioned, 1.63.0)
        * Folly
          * **Boost** (any version, will resolve to 1.63.0 from above)
    
    Alternative implementation of PR #16756. Fixes issue #16381.
    
    (same as #16756)
    * Install react-native via Cocoapods (or move a helloWorld react-native application over to use Cocoapods for dependency management)
    * Add CxxBridge instead of BatchedBridge to your Podfile
    * run pod install
    * run react-native run-ios
    
    [Add boost.podspec speed up download time & reduce size of the package](#16756)
    
    [IOS] [BUGFIX] [third-party-podspecs] - optimize CocoaPods installation (Boost distribution)
    Closes #17476
    
    Differential Revision: D6746095
    
    Pulled By: hramos
    
    fbshipit-source-id: 55b2b5a698691f7fca0bf4c31c4376c2b9eb5379
    CFKevinRef authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d40db3a View commit details
    Browse the repository at this point in the history
  2. metro: allow dynamic dependencies from within node_modules

    Summary: Tries to adress facebook/metro#65. We need a reasonnable workaround to support modules like `moment.js` that do dynamic requires but only in some cases. By replacing the call by a function that throws, we move the exception at runtime instead of happening at compile time. We don't want to do that for non-node_modules file because they are fixable directly, while `node_modules` are not fixable by people and they get completely blocked by the error at compile time.
    
    Reviewed By: rafeca
    
    Differential Revision: D6736989
    
    fbshipit-source-id: a6e1fd9b56fa83907400884efd8f8594018b7c37
    Jean Lauliac authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    b5e19ad View commit details
    Browse the repository at this point in the history
  3. make AnimatedValueXY constructor input value immutable

    Reviewed By: furdei
    
    Differential Revision: D6741521
    
    fbshipit-source-id: e8401982fbb3c3d6cd4bcc2581358fd4a5de12f9
    zjj010104 authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    52ffa5d View commit details
    Browse the repository at this point in the history
  4. Cleanup ReactHorizontalScrollView

    Reviewed By: achen1
    
    Differential Revision: D6693605
    
    fbshipit-source-id: e58425b2a5b0bf75ffb41ef3ab6fa7ad46222531
    mdvacca authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    71ec85f View commit details
    Browse the repository at this point in the history
  5. Add support for finding multiple views with NativeIds using a single …

    …listener
    
    Reviewed By: mdvacca
    
    Differential Revision: D6735460
    
    fbshipit-source-id: e038a68637a00fda7058fc82e253ae68cdf67c6e
    axe-fb authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    f5efc46 View commit details
    Browse the repository at this point in the history
  6. Stop crashing when open MP on android: Revert D6688488

    Reviewed By: achen1
    
    Differential Revision: D6750774
    
    fbshipit-source-id: 96f9e0bd244fdbf1a8784f77a74686d886424529
    Liubov Zvereva authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    63ce56f View commit details
    Browse the repository at this point in the history
  7. Update React.podspec for RCTText

    Summary:
    Some of the classes of RCTText are now in the subfolders, this will fix pod integration for texts
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    I have integrated React Native into my project with [this guide](https://facebook.github.io/react-native/docs/integration-with-existing-apps.html) and got the error `No component found for view with name RCTText`. Searching in the web did not give any useful information so I started to dig into the code and found out that there is now subfolders and pod taking only root classes. After making this change project started to compile again.
    
    Create empty project with pods integrated add `RCTText` subspec and in `.js` file add  some `<Text>` element
    
    Fixed `RCTText` subspec integration.
    Closes #17655
    
    Differential Revision: D6751039
    
    Pulled By: hramos
    
    fbshipit-source-id: f4538d1125af2b45f36e2fa535382e032dbc8f4e
    hovox authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    7e7d00a View commit details
    Browse the repository at this point in the history
  8. rename and extend new maintain visible content position feature

    Summary:
    Builds off of cae7179
    
    - Make the prop a dictionary for more configuration options
    - Rename `maintainPositionAtOrBeyondIndex` -> `maintainVisibleContentPosition` + `minIndexForVisible`
    - Add autoscroll threshold feature
    
    Given the async native of RN JS and background layout, there is no way to trigger the scrollTo from JS without risking a delay, so we add the feature in native code.
    
    == Test Plan ==
    ScrollViewExample:
    https://youtu.be/pmY8pxC9PRs
    
    Reviewed By: shergin
    
    Differential Revision: D6729160
    
    fbshipit-source-id: 70f9bae460ce84567857a4f696da78ce9b3b834c
    sahrens authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    65184ec View commit details
    Browse the repository at this point in the history
  9. Handle invalidation error in RCTObjcExecutor

    Differential Revision: D6748200
    
    fbshipit-source-id: eb98782c2ba080273c1f027846984f5f4caddf26
    fromcelticpark authored and facebook-github-bot committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    493f3e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2018

  1. Fix and re-enable "view flattening" optimizations for Marketplace

    Reviewed By: achen1
    
    Differential Revision: D6751078
    
    fbshipit-source-id: 32bfb9ac64f183fabbba85755be372016722afc6
    mdvacca authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    877f1cd View commit details
    Browse the repository at this point in the history
  2. Capture StackOverflowExceptions triggered when drawing a ReactViewGro…

    …up or ReactRootView
    
    Reviewed By: achen1
    
    Differential Revision: D6653395
    
    fbshipit-source-id: 849b1a2ed6ab9bc057414d451e97a673178c30dd
    mdvacca authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    1aac962 View commit details
    Browse the repository at this point in the history
  3. Allow to attach the HMR server to an external http server

    Reviewed By: BYK
    
    Differential Revision: D6752279
    
    fbshipit-source-id: 250255a3b1226f8aab6054e507cb3910cdcd6a85
    rafeca authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    8c6b816 View commit details
    Browse the repository at this point in the history
  4. Bump metro@0.24.5

    Reviewed By: BYK
    
    Differential Revision: D6759031
    
    fbshipit-source-id: b6ba1e2da77b944c8c73d229749f84d9c16035c7
    rafeca authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    0de470e View commit details
    Browse the repository at this point in the history
  5. Bump metro@0.24.6

    Reviewed By: arcanis, cpojer
    
    Differential Revision: D6761110
    
    fbshipit-source-id: b23536d639ed9e963893ef784c93aa0c6ab452a4
    rafeca authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    e8893a0 View commit details
    Browse the repository at this point in the history
  6. Adding JS hierarchy information when a StackOverflowException is thro…

    …wn in Dev mode
    
    Reviewed By: achen1
    
    Differential Revision: D6716309
    
    fbshipit-source-id: 23458cd126d13fec3aa9c09420f7cdd230ec8dd0
    mdvacca authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    4d3519c View commit details
    Browse the repository at this point in the history
  7. TouchableWithoutFeedback will use child's nativeID if specified

    Reviewed By: sahrens
    
    Differential Revision: D6733834
    
    fbshipit-source-id: 409acf8d33565aa1e6d4698fd5d2db046a6f9402
    elicwhite authored and facebook-github-bot committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    3c2bb3e View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. Remove internal utf8 utility

    Summary:
    As requested by davidaurelio in mathiasbynens/utf8.js#17 (comment), this makes it possible for developers to use the `utf8` package from npm in combination with React Native.
    
    Ref. mathiasbynens/utf8.js#17
    Closes #17146
    
    Differential Revision: D6765030
    
    Pulled By: hramos
    
    fbshipit-source-id: dda9b3255618470aea2e32c5ba3cf1325e2ec997
    mathiasbynens authored and facebook-github-bot committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    431670f View commit details
    Browse the repository at this point in the history
  2. Remove redundant config in AndroidManifest.xml

    Summary:
    * remove redundant version code, name, miniSdk, targetSdk, they now are configed in build.gradle
    * allowbackup = true is not a secure config
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Clean up redundant config and remove security risk config.
    
    test android template still works.
    
    none
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17596
    
    Differential Revision: D6768292
    
    Pulled By: hramos
    
    fbshipit-source-id: 9f32f17aebb9c1857d8b64d6687efe7c22e7bc79
    gengjiawen authored and facebook-github-bot committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    d7a9ca2 View commit details
    Browse the repository at this point in the history
  3. Fix dependencies

    Reviewed By: adamjernst
    
    Differential Revision: D6754488
    
    fbshipit-source-id: 49f2a45d024c7bd6b52f51f7705bcd167a499e47
    swolchok authored and facebook-github-bot committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    cec2e80 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. Make xplat react native files buildable

    Reviewed By: mzlee
    
    Differential Revision: D6605611
    
    fbshipit-source-id: baa33947319a27b95020924d177a9398a276dabe
    Jonathan Kim authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    4f2cc42 View commit details
    Browse the repository at this point in the history
  2. tighten EdgeInsetsPropType flow type

    Reviewed By: yungsters
    
    Differential Revision: D6767104
    
    fbshipit-source-id: 40b1a4f9f41ff4beae141b636738994ccfa96d37
    sahrens authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    6e7fb01 View commit details
    Browse the repository at this point in the history
  3. @allow-large-files @ignore-conflict-markers[i18n] translation auto-up…

    …date for i18n/adsmanager.config.json on master
    
    fbshipit-source-id: a0ba2333de9b635234aa56ccd080252fa400d534
    Build Service authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    c7846c4 View commit details
    Browse the repository at this point in the history
  4. @allow-large-files @ignore-conflict-markers[i18n] translation auto-up…

    …date for i18n/creatorapp.config.json on master
    
    fbshipit-source-id: 9ae5884ac23492feed039da32433cd8c08e2cc0e
    Build Service authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    bb6fcea View commit details
    Browse the repository at this point in the history
  5. @allow-large-files @ignore-conflict-markers[i18n] translation auto-up…

    …date for i18n/expresswifi.config.json on master
    
    fbshipit-source-id: 42904e404f11a205af8af486e9535a8dc52da81e
    Build Service authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    8bd00a2 View commit details
    Browse the repository at this point in the history
  6. @allow-large-files @ignore-conflict-markers[i18n] translation auto-up…

    …date for i18n/fb4a.config.json on master
    
    fbshipit-source-id: c7382ae9de4fb1697190bbc9fe385bd552973fdd
    Build Service authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    faa9519 View commit details
    Browse the repository at this point in the history
  7. @allow-large-files @ignore-conflict-markers[i18n] translation auto-up…

    …date for i18n/instagram-directapp.config.json on master
    
    fbshipit-source-id: ec880908d30772bf2047963013d184e01405de03
    Build Service authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    f49f793 View commit details
    Browse the repository at this point in the history
  8. Mark model fields final

    Reviewed By: emilsjolander
    
    Differential Revision: D6759564
    
    fbshipit-source-id: 810dc8a9730fb330760d2aedecafcea81cf25cb1
    passy authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    ff2658c View commit details
    Browse the repository at this point in the history
  9. xplat/js: asyncRequire: redirect async modules to control modules

    Reviewed By: davidaurelio
    
    Differential Revision: D6750305
    
    fbshipit-source-id: 4cf3f1b6e0adbe88a9e7afb6a1784d1528e131b2
    Jean Lauliac authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    5e11b88 View commit details
    Browse the repository at this point in the history
  10. Add flow typing to QuickPerformanceLogger

    Reviewed By: cwdick
    
    Differential Revision: D6613292
    
    fbshipit-source-id: 58e41507a3c7cf9fbc6b972e327ae76d294d6807
    alexeylang authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    bcfbdf4 View commit details
    Browse the repository at this point in the history
  11. Add extensibility point on react-native-xcode.sh script

    Summary:
    Original pull request: #12863
    
    Useful for generating source maps, for example.
    
    Feature parity with Android, that already have this extensibility point on `build.gradle`:
    ```
    project.ext.react = [
        extraPackagerArgs: [...]
    ]
    ```
    
    Xcode > Build Phases > Bundle React Native code and Images
    ```
    export NODE_BINARY=node
    export EXTRA_PACKAGER_ARGS="--sourcemap-output ${SRCROOT}/build/main.jsbundle.map"
    ../node_modules/react-native/scripts/react-native-xcode.sh
    ```
    
    [IOS] [FEATURE] [./react-native-xcode.sh] - Added $EXTRA_PACKAGER_ARGS extensibility point
    Closes #16933
    
    Differential Revision: D6771709
    
    Pulled By: yungsters
    
    fbshipit-source-id: a33614b45b1e3537daeb31504fdd3a402dc70ff0
    brunolemos authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    0d4ff1b View commit details
    Browse the repository at this point in the history
  12. Split folly/Memory out from headers-only targets

    Reviewed By: yfeldblum
    
    Differential Revision: D6732464
    
    fbshipit-source-id: 9d9498e0faa02c2003ab0e363444b7a2be51fd93
    mzlee authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    b8e79a7 View commit details
    Browse the repository at this point in the history
  13. Make the React Native HMR client extend from the generic metro HMR cl…

    …ient
    
    Reviewed By: BYK
    
    Differential Revision: D6752278
    
    fbshipit-source-id: 5c93cba3e9f3cee2119cb90a711909e0b4a5b835
    rafeca authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    9a19867 View commit details
    Browse the repository at this point in the history
  14. update npm cache key

    Summary: Closes #17708
    
    Differential Revision: D6775450
    
    Pulled By: hramos
    
    fbshipit-source-id: f8b04655dac942c84765ee01359c5f1589e00b76
    hramos authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    f50af7f View commit details
    Browse the repository at this point in the history
  15. Move JS Bundle build step into Android

    Summary:
    Current setup prevents Android signal from being obtained when JavaScript environment is affected.
    
    Proposed setup will configure Android build environment, surfacing any issues affecting Android even when a JavaScript bundle cannot be built.
    
    We cannot proceed with unit tests and instrumentation tests if JavaScript is affected, but we will at least still get some signal from running BUCK.
    Closes #17709
    
    Differential Revision: D6775966
    
    Pulled By: hramos
    
    fbshipit-source-id: e50916c39060ed4e8ca880fcecc2830a51539bbd
    hramos authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    17bd6c8 View commit details
    Browse the repository at this point in the history
  16. RN: Revive react-native-xcode.sh

    Reviewed By: mmmulani
    
    Differential Revision: D6775989
    
    fbshipit-source-id: da17748c373dd152a743aa1ed8a5f075074415d3
    yungsters authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    b8c86b8 View commit details
    Browse the repository at this point in the history
  17. Add back kwargs

    Summary:
    Originally added in #17551 by dryganets but lost when an internal diff consolidated files into ReactNative/DEFS
    Closes #17710
    
    Differential Revision: D6778242
    
    Pulled By: hramos
    
    fbshipit-source-id: 22bd3348feccf1ecb53d897c84e1ca704e51fc33
    hramos authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    f5975a9 View commit details
    Browse the repository at this point in the history
  18. ClassCastException fix: getText() returns CharSequence not Spanned.

    Summary:
    ClassCastException fix: getText() returns CharSequence not Spanned.
    From the other hand, EditTexts getText method returns Editable which extends Spanned.
    This commit fixes two similar bugs one in flat TextView and another in standard TextView.
    Also, it removes redundant checks in the ReactEditText.
    
    Application without this change sporadically crashes with the following stack trace:
    ```
    java.lang.ClassCastException: java.lang.String cannot be cast to android.text.Spanned
    	at com.facebook.react.views.text.ReactTextView.reactTagForTouch(ReactTextView.java:195)
    	at com.facebook.react.uimanager.TouchTargetHelper.getTouchTargetForView(TouchTargetHelper.java:269)
    	at com.facebook.react.uimanager.TouchTargetHelper.findTargetTagAndCoordinatesForTouch$58866680(TouchTargetHelper.java:101)
    	at com.facebook.react.uimanager.JSTouchDispatcher.handleTouchEvent(JSTouchDispatcher.java:77)
    	at com.facebook.react.ReactRootView.dispatchJSTouchEvent(ReactRootView.java:151)
    	at com.facebook.react.ReactRootView.onInterceptTouchEvent(ReactRootView.java:127)
    	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2110)
    
    ```
    Closes #15452
    
    Differential Revision: D6775986
    
    Pulled By: hramos
    
    fbshipit-source-id: 6de929937cbbb3e7bd98a708a40700f883cbaef0
    dryganets authored and facebook-github-bot committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    46cc490 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Added ScrollView support for React VR platform

    Reviewed By: sahrens
    
    Differential Revision: D6727393
    
    fbshipit-source-id: 261d5734d5de3b94fd9eaefb5beab0e2d3074b17
    MartinSherburn authored and facebook-github-bot committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    6fa039d View commit details
    Browse the repository at this point in the history
  2. Made logging logic dynamic to log string length

    Reviewed By: emilsjolander
    
    Differential Revision: D6784491
    
    fbshipit-source-id: 26e4520a84be355ff992b808297ce7a95b3d09e3
    priteshrnandgaonkar authored and facebook-github-bot committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    be8e7c6 View commit details
    Browse the repository at this point in the history
  3. Fix open source build load error

    Reviewed By: hramos
    
    Differential Revision: D6785610
    
    fbshipit-source-id: d50aab72aa51f8aa063f23fc1e328caf9c02de0c
    Jonathan Kim authored and facebook-github-bot committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    4f6c157 View commit details
    Browse the repository at this point in the history
  4. Check for nullptr when accessing isInspectable method

    Reviewed By: javache
    
    Differential Revision: D6785733
    
    fbshipit-source-id: 1bbb884746e671124b7d2d950a3419ea33d70522
    fromcelticpark authored and facebook-github-bot committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    70d23e8 View commit details
    Browse the repository at this point in the history
  5. Popups calling error callback instead of crashing if view with passed…

    … tagId not found
    
    Summary:
    The showPopup method has an error callback. For some reason, it is asserting in case the wrong tagId is passed instead of calling the error callback on Android.
    
    Pass not existing tagId to showPopup method and make sure it is receiving an error in js instead of crashing in native on Android.
    
    [ANDROID] [MINOR] showPopup method calls error callback instead of crashing on errors.
    Closes #17550
    
    Differential Revision: D6776014
    
    Pulled By: hramos
    
    fbshipit-source-id: 1d97b762818d1591018fd43556eb41c3fb491eb9
    dryganets authored and facebook-github-bot committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    0c18ec5 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Fix permissions on test script

    Reviewed By: yungsters
    
    Differential Revision: D6791810
    
    fbshipit-source-id: 849cffd3810eb53a6050e5e1a37d84a5e4ccb62a
    mzlee authored and facebook-github-bot committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    42c410a View commit details
    Browse the repository at this point in the history
  2. Backed out changeset 409acf8d3356

    Differential Revision: D6789941
    
    fbshipit-source-id: 30d431727a4615208f51293d071f9334584a2269
    elicwhite authored and facebook-github-bot committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    cd263a2 View commit details
    Browse the repository at this point in the history
  3. The New <Text> on iOS

    Summary:
    This is a complete rewrite of RCTText, the part of React Native which manages Text and TextInput components.
    
    Key points:
    
    * It's understandable now. It follows a simple architectural pattern, and it's easy to debug and iterate. Text flow layout is a first-class citizen in React Native layout system now, not just a wired special case. It also brings entirely new possibilities such as nested interleaving <Text> and <View> components.
    * All <Text>-specific APIs were removed from UIManager and co (it's about ~16 public methods which were used exclusively only by <Text>).
    * It relies on new Yoga measurement/cloning API and on-dirty handler. So, it removes built-in dirty propagation subsystem from RN completely.
    * It caches string fragments properly and granularly on a per-node basis which makes updating text-containing components more performant.
    * It does not instantiate UIView for virtual components which reduces memory utilization.
    * It drastically improves <TextInput> capabilities (e.g. rich text inside single line <TextInput> is now supported).
    
    Screenshots:
    https://cl.ly/2j3r1V0L0324
    https://cl.ly/3N2V3C3d3q3R
    
    Reviewed By: mmmulani
    
    Differential Revision: D6617326
    
    fbshipit-source-id: 35d4d81b35c9870e9557d0211c0e934e6072a41e
    shergin authored and facebook-github-bot committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    2716f53 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. @allow-large-files flow 0.64 release

    Reviewed By: gabelevi
    
    Differential Revision: D6800250
    
    fbshipit-source-id: 7c0902526cce77eb6931856ac24a0560c4fbbc88
    avikchaudhuri authored and facebook-github-bot committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    298f3bb View commit details
    Browse the repository at this point in the history
  2. Remove references to Travis

    Summary:
    react-native project is migrated travis to circleCI.
    but the document has some leavings.
    
    Only Docs Edited
    
    #16354
    #16364
    
    [ DOCS] Remove references to Travis
    changed Releases.md
    changed RNTester/RNTesterIntegrationTests/RNTesterSnapshotTests.m
    changed scripts/android-e2e-test.js
    Closes #17733
    
    Differential Revision: D6806336
    
    Pulled By: shergin
    
    fbshipit-source-id: 22d21995d718a89bb831f75ed2ff6074dd22c6fe
    philographer authored and facebook-github-bot committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    b9d058a View commit details
    Browse the repository at this point in the history
  3. babel-preset-react-native: only require plugins once

    Reviewed By: cpojer
    
    Differential Revision: D6795591
    
    fbshipit-source-id: 30b689e2cf72a4bf4bdae49113369ef536ed81d6
    davidaurelio authored and facebook-github-bot committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    df6c48c View commit details
    Browse the repository at this point in the history
  4. Continue wrapping functions as we prepare for skylark

    Differential Revision: D6808010
    
    fbshipit-source-id: f24e71558baed2c2da319e20e0faf66858eb27d5
    mzlee authored and facebook-github-bot committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    869866c View commit details
    Browse the repository at this point in the history
  5. Bump metro@0.24.7

    Summary: Releasing a new version of metro with an executable CLI
    
    Reviewed By: davidaurelio
    
    Differential Revision: D6808207
    
    fbshipit-source-id: 68f6522924ea8ad7b6f9aaa3e952ebcf23d2cf8b
    rafeca authored and facebook-github-bot committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    e9b83e6 View commit details
    Browse the repository at this point in the history
  6. Proper attributed strings comparsion in RCTBaseTextInputView

    Summary:
    Now, in the new model, we transfer text attributes with actual text via attributed text to a native text component,
    so previous text-only comparsion is not sufficient anymore.
    
    Depends on D6600685.
    
    Differential Revision: D6809833
    
    fbshipit-source-id: 475b7426cf3c6694781790d99ef32466606da2f2
    shergin authored and facebook-github-bot committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    46fd864 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Removed use of xip.io, as it's not needed.

    Summary:
    By default, when a react-native app launches in development mode on a physical iOS device, it attempts to load the JS bundle from a packager at `http://_your-local-ip-address_.xip.io:8081/`.
    
    This change removes the use of `xip.io`, which changes that url to: `http://_your-local-ip-address_:8081/`
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Background:
    The automatic IP detection feature (introduced [here](#8091)) is super handy. However, it’s use of `xip.io` has caused myself and others much grief.  Some routers do not allow or have intermittent errors when trying to resolve DNS names to local IP addresses. This prompted the introduction of a [DISABLE_XIP feature](#13326), which helps.
    
    However, I don’t believe the use of `xip.io` is needed at all.
    
    Based on [this comment](8c29a52#commitcomment-18224788), it appears the original reason for using `xip.io` was to “circumvent the numeric IP address limitation in ATS”.
    
    But, the reason you can’t create ATS exceptions for raw IP addresses is that ATS is not enforced for raw IP addresses _at all_. You can read the Apple documentation [here](https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html), the relevant portion is:
    
    > App Transport Security (ATS) applies only to connections made to public host names. The system does not provide ATS protection to connections made to:
    > * Internet protocol (IP) addresses
    > * Unqualified host names
    > * Local hosts employing the .local top-level domain (TLD)
    
    For example, in iOS, if you attempt to make an http request (note: _not_ https) to `http://www.google.com` you will get an error due to ATS.
    However, you can make the same request to `http://172.217.6.14/`  (which for me is the same server) and the request will succeed.
    
    And in fact, if an ATS exception _was_ needed, the DISABLE_XIP feature shouldn’t work at all, but it does.
    
    In short, using `xip.io` with ATS exceptions is unnecessary, causes some very annoying problems for some people, and I think it should just be removed.
    
    Run the app on a physical iOS device and verify that it can load the JS bundle from the host computer's IP.
    
    [Implemented automatic IP detection for iOS #8091](#8091)
    [Added option to disable xip #13326](#13326)
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
     [INTERNAL] [BUGFIX] [./scripts] - Removed use of xip.io
    Closes #17642
    
    Differential Revision: D6814609
    
    Pulled By: hramos
    
    fbshipit-source-id: f2faebd6a29b0b211d78cdfe8e195906307ab552
    Job Vranish authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    40a8434 View commit details
    Browse the repository at this point in the history
  2. Fix NPE in Android Switch during measure

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Fixes #16000
    
    see [Issue #16000](#16000)
    fix a null pointer exception while using higher version 'com.android.support:appcompat-v7'
    
    N/A
    
    [ANDROID][BUGFIX][Switch] - Fix NPE in Android Switch during measure
    Closes #16064
    
    Differential Revision: D6816122
    
    Pulled By: hramos
    
    fbshipit-source-id: ba9a6febad4884b8ab142d8c7142085367006904
    4ndroidev authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    7b1915e View commit details
    Browse the repository at this point in the history
  3. Give IInspector a virtual destructor for correct InspectorImpl destru…

    …ction
    
    Reviewed By: bnham
    
    Differential Revision: D6815637
    
    fbshipit-source-id: bfd3bd4a664ec51d5364df512bfc9bc366f516c1
    toulouse authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    2a3c37f View commit details
    Browse the repository at this point in the history
  4. Fixed a bug when <Text> does not redraw native view on relayout

    Summary: `contentFrame` is now always provided by shadow thread (with attributed string and embedded views), so we have to update it on every single relayout.
    
    Reviewed By: yungsters
    
    Differential Revision: D6817401
    
    fbshipit-source-id: c2a1f314f34a2187053eb11ce0744c935edbb8ae
    shergin authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    7d1ec7a View commit details
    Browse the repository at this point in the history
  5. RN: Add Missing Start/End Style Types

    Reviewed By: shergin
    
    Differential Revision: D6813953
    
    fbshipit-source-id: eed5dcaa2b6f4101f03d7fe1fca9d20c0f6a6429
    yungsters authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    3fc33bb View commit details
    Browse the repository at this point in the history
  6. Implement Blob support for XMLHttpRequest

    Summary:
    This PR is a followup to #11417 and should be merged after that one is merged.
    
      1. Add support for creating blobs from strings, not just other blobs
      1. Add the `File` constructor which is a superset of `Blob`
      1. Add the `FileReader` API which can be used to read blobs as strings or data url (base64)
      1. Add support for uploading and downloading blobs via `XMLHttpRequest` and `fetch`
      1. Add ability to download local files on Android so you can do `fetch(uri).then(res => res.blob())` to get a blob for a local file (iOS already supported this)
    
      1. Clone the repo https://github.com/expo/react-native-blob-test
      1. Change the `package.json` and update `react-native` dependency to point to this branch, then run `npm install`
      1. Run the `server.js` file with `node server.js`
      1. Open the `index.common.js` file and replace `localhost` with your computer's IP address
      1. Start the packager with `yarn start` and run the app on your device
    
    If everything went well, all tests should pass, and you should see a screen like this:
    
    ![screen shot 2017-06-08 at 7 53 08 pm](https://user-images.githubusercontent.com/1174278/26936407-435bbce2-4c8c-11e7-9ae3-eb104e46961e.png)!
    
    Pull to rerun all tests or tap on specific test to re-run it
    
      [GENERAL] [FEATURE] [Blob] - Implement blob support for XMLHttpRequest
    Closes #11573
    
    Reviewed By: shergin
    
    Differential Revision: D6082054
    
    Pulled By: hramos
    
    fbshipit-source-id: cc9c174fdefdfaf6e5d9fd7b300120a01a50e8c1
    satya164 authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    be56a3e View commit details
    Browse the repository at this point in the history
  7. Fix Xcode Archive task failing if project path contains whitespace

    Summary:
    Currently, Xcodebuild Archive task "Bundle React Native code and images" step fails if the project path contains whitespace characters. This is due to `react-native-xcode.sh` not escaping the local CLI path.
    
    Ideally, of course, folks would use sane directory names, but this affects people in the community. I have seen this at a beginner hackathon, as well as Stack Overflow, e.g. https://stackoverflow.com/questions/48209829/cannot-create-offline-bundle-for-react-native-ios
    
    ```
    mkdir Bad\ Name
    cd Bad\ Name
    react-native init TestProject
    cd TestProject
    open ios/TestProject.xcodeproj
    ```
    * Run `Build > Archive`
    * `cli.js bundle` command fails with "Cannot find module '.../Bad'"
    
    * Patch `/node_modules/react-native/scripts/react-native-xcode.sh` with changed file
    * Run `Build > Archive`
    * Build succeeds
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scrip] - Added thing to script that nobody will see
    -->
    
     [IOS] [MINOR] [scripts/react-native-xcode.sh] - Escape directory paths with spaces
    Closes #17628
    
    Differential Revision: D6806418
    
    Pulled By: hramos
    
    fbshipit-source-id: 7ef3943d91807d0086f0717e436e1988f9faf03d
    jevakallio authored and facebook-github-bot committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    8aa568e View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Prevents JS Debugger issues with CORS

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    See #17618
    
    On certain networks, `xip.io` is used, but as the debugger will always using localhost a change upstream has resulted in a CORS issue (see screenshots in #17618). This change ensures that the debugger will always open with whatever configuration.
    
    > This should be merged in as a patch of `0.52.x` as it affects current release, and `0.51.x` didn't have this issue.
    
    Tested locally, could do with the people having the same issue in #17618 testing it out prior to merging.
    
    (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [CLI] [BUGFIX] [local-cli/server/middleware/getDevToolsMiddleware.js] - Prevents JS Debugger issues with CORS
    Closes #17720
    
    Differential Revision: D6828205
    
    Pulled By: hramos
    
    fbshipit-source-id: 7e5d43db9faf7edc9444ba4214aca1a18e25dbd2
    Nico authored and facebook-github-bot committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    29f8354 View commit details
    Browse the repository at this point in the history
  2. Test and document Image resizeMode=center on iOS

    Summary:
    `<Image resizeMode="center">` already works on iOS (implemented in #8792), but is neither tested nor documented the way the other `resizeMode` values are.
    
    This PR primarily enables the relevant RNTester case on iOS, and secondarily copies over the doc comment from `Image.android.js` to `Image.ios.js`. A PR to `react-native-website` will follow shortly and it is there I will try and revise the wording a bit.
    
    Updated RNTester screenshot (iOS):
    
    <img src=https://user-images.githubusercontent.com/2246565/35470720-44b38282-0357-11e8-941c-1b3c5a1b2f3b.png width=300>
    
    react-native-website PR coming soon.
    
    [IOS] [MINOR] [Image] - Include resizeMode=center in RNTester
    Closes #17759
    
    Differential Revision: D6829051
    
    Pulled By: hramos
    
    fbshipit-source-id: c6e0000a75765e8bf3a1d0306aaafad002b14a58
    motiz88 authored and facebook-github-bot committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    be7037f View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. GLog fix on case sensitive APFS macOS

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    This will fix compile error on case sensitive APFS(Apple File System) macs.
    
    Integrate  RN on case sensitive formatted macOS via cocoa pods you will get compile errors on the include lines something like :
    ```
             ^~~~~~~~~~~~~~~~
    1 error generated.
    ** BUILD FAILED **
    ```
    
    If you change `#include <glog/logging.h>` into `#include <GLog/logging.h>` (replace `glog` with `GLog`) it will fix the build error. After fixing this you will get same kind of errors on a few other places.
    
    [IOS] [BUGFIX] [Framework] - `GLog` fix on case sensitive APFS macOS
    Closes #17697
    
    Differential Revision: D6832740
    
    Pulled By: shergin
    
    fbshipit-source-id: 0c7a01f33fde35dbc8004c5bb6e5b22f8f0ea369
    hovox authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    2fef1ba View commit details
    Browse the repository at this point in the history
  2. Make sure refreshControl shows up on initial render if specified

    Summary:
    [this commit](2e1707d) which was just a small refactor broke refreshControl behavior - if we render FlatList with refreshing=true, the refreshControl won't be visible on initial render.
    
    The problem is, the [previous beginRefreshing method](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeL51) was renamed to `beginRefreshingProgramatically` and the old call was left in one place [here](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeR47).
    
    Now, I am not sure what kind of jumping the mentioned commit was fixing, but since this fix only concerns the initial render, I believe it will not influence the jumping fix.
    
    I have tested this locally in my app, can provide a video if needed.
    
    none
    
     [IOS] [BUGFIX] [RefreshControl] - Make sure refreshControl shows up on initial render if specified
    Closes #17727
    
    Differential Revision: D6827402
    
    Pulled By: shergin
    
    fbshipit-source-id: 25849244e87af54f25d636b6ade7adcf88958980
    vonovak authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    ed5872e View commit details
    Browse the repository at this point in the history
  3. Removed outdated assertion in RCTShadowView related to breaking chang…

    …e in Yoga
    
    Summary: It's been more than two years; I think everyone already migrated and learned the new behavior.
    
    Reviewed By: emilsjolander
    
    Differential Revision: D6829885
    
    fbshipit-source-id: a86d56fb7235a137e9ce6e360d7ae2224b047313
    shergin authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    e3ff3cf View commit details
    Browse the repository at this point in the history
  4. Measure time to create ReactInstanceManager

    Reviewed By: fkgozali
    
    Differential Revision: D6591797
    
    fbshipit-source-id: 7345b7c772eb4ae35ad570082090fbdf704102d3
    alexeylang authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    6224ef5 View commit details
    Browse the repository at this point in the history
  5. Migrate DeviceInfoModule from RN Module to Native Function.

    Reviewed By: danzimm
    
    Differential Revision: D6750934
    
    fbshipit-source-id: f453801737e41632c6b84ff894e7f0eb66b575dc
    Dmitry Zakharov authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    429fcc8 View commit details
    Browse the repository at this point in the history
  6. Support sticky headers for inverted Lists

    Summary:
    Sticky headers for inverted lists should still stick at the top of the list instead of the bottom.
    
    Tested by adding the inverted prop to the SectionList example in RNTester.
    
    It does add a prop to ScrollView but it's very specific to the inverted list implementation, not sure if it should be documented.
    
    [GENERAL][ENHANCEMENT][LISTS] -  Support sticky headers for inverted Lists
    Closes #17762
    
    Differential Revision: D6830784
    
    Pulled By: sahrens
    
    fbshipit-source-id: 6841fdd46e04b30547659d85ff54c3a21c61a8a2
    janicduplessis authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    ecaca80 View commit details
    Browse the repository at this point in the history
  7. Nested virtualized lists should receive recordInteration events

    Summary:
    Right now when an interaction is recorded on a parent VirtualizedList, the interaction isn't passed on to its children. That means that if `waitForInteraction` is set to true for a child list's viewability helper, it will never trigger a VPV.
    
    This change adds forwarding of these events inside `onBeginScrollDrag`. It also forwards the interaction state of the parent list at register time, in case a child list is rendered mid-scroll.
    
    Reviewed By: sahrens
    
    Differential Revision: D6822091
    
    fbshipit-source-id: dfe300e42722d4285f65787ab2c1368f050c5577
    logandaniels authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    ae2d5b1 View commit details
    Browse the repository at this point in the history
  8. fixed issue with runIOS not being able to launch tvOS app

    Summary:
    Yes.
    
    Yes
    
    Environment:
    OS: MacOS X 10.12.6 (16G29)
    Node: 8.9.4
    Yarn: N/A
    npm: 5.4.2
    Watchman: Not Found
    Xcode: 9.2 (9C40b)
    Android Studio: N/A
    
    [CLI iOS runIOS] When using `react-native-cli` to try to launch the tvOS scheme the user get's an error because the current implementation for launching simulators ignores any simulator/device who's name does not start with `iOS`
    
    StackOverflow issue also found here :  https://stackoverflow.com/questions/48069690/how-to-select-project-to-run-tvos-version-with-npm-start
    
    Actual command line steps
    ```
    $npm i -g react-native-cli
    ...
    $react-native init CoolProject
    ...
    $cd CoolProject/
    $react-native run-ios --simulator "Apple TV"  --scheme "CoolProject-tvOS"
    
    Scanning folders for symlinks in /Users/jjiron/CoolProject/node_modules (7ms)
    Found Xcode project CoolProject.xcodeproj
    CoreData: annotation:  Failed to load optimized model at path '/Applications/Xcode.app/Contents/Applications/Instruments.app/Contents/Frameworks/InstrumentsPackaging.framework/Versions/A/Resources/XRPackageModel.momd/XRPackageModel 9.0.omo'
    
    Could not find Apple TV simulator
    ```
    
    The cli tool should launch the tvOS application on the simulator.
    
    The user get's an error message saying "Could not find Apple TV simulator"
    
    Don't ignore appletv simulators when looking for simulators to launch. Also use the correct application build when selecting which app to launch on the simulator/device.
    
    Added automated test for `findMatchingSimulator.js` to allow tvOS simulators
    
    [react-native-cli] Fixed issue where you cannot launch tvOS app on Apple TV simulator
    Closes #17660
    
    Differential Revision: D6806327
    
    Pulled By: hramos
    
    fbshipit-source-id: 1a4f37058f3c5d8223012a3e4050e7bbfaafa6c4
    Joey Jiron authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    afd988f View commit details
    Browse the repository at this point in the history
  9. React sync for revisions 9491dee...a7b9f98

    Reviewed By: sebmarkbage
    
    Differential Revision: D6834573
    
    fbshipit-source-id: 30829313053ecec54a891941fcf090021497ef8e
    Brian Vaughn authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    d676746 View commit details
    Browse the repository at this point in the history
  10. Add accessibilityElementsHidden prop

    Summary:
    Allow iOS to have similar accessibility functionality to Android. This PR exposes the `accessibilityElementsHidden` property on iOS which is similar to Android's `importantForAccessibility="no-hide-descendants"`
    
    I didn't see any existing examples for testing native props being passed through, but I did add an example to the RNTester app. I've attached some screenshots using the Accessibility Inspector to verify the property was correctly passed through.
    
    ![a](https://user-images.githubusercontent.com/603528/34998153-50e66776-faac-11e7-826d-1445a6813929.png)
    ![b](https://user-images.githubusercontent.com/603528/34998158-535a7420-faac-11e7-80d4-992fb7cd82dd.png)
    
    I've updated the website with appropriate documentation.
    
    facebook/react-native-website#141
    
    ![screen shot 2018-01-16 at 10 23 50](https://user-images.githubusercontent.com/603528/34998202-6f2f39a6-faac-11e7-8651-0cfe8e037a30.png)
    ![screen shot 2018-01-16 at 10 23 59](https://user-images.githubusercontent.com/603528/34998205-711d6f94-faac-11e7-974d-54340c72fce4.png)
    
    [IOS] [FEATURE] [View] - Added accessibilityElementsHidden property
    Closes #17627
    
    Differential Revision: D6806444
    
    Pulled By: hramos
    
    fbshipit-source-id: 50d31fdb92f4c59ae9355b019c422418b2e6cc24
    aputinski authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    3128816 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Trim docs that are already present in the open source docs site

    Summary:
    A lot of these docs are already present in https://github.com/facebook/react-native-website.
    Closes #17776
    
    Differential Revision: D6839783
    
    Pulled By: hramos
    
    fbshipit-source-id: 945fde22afb8f181d0463617d224d3f3429faa24
    hramos authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    28d60b6 View commit details
    Browse the repository at this point in the history
  2. Typos in code

    Summary:
    To fix typos
    
    No testing required, changed only internal things names
    
    No
    
    addtionalStyles -> additionalStyles
    occured -> occurred
    recomendedType -> recommendedType
    markDirtyAndPropogate -> markDirtyAndPropagate
    targetting -> targeting
    RCTApplyTranformationAccordingLayoutDirection -> RCTApplyTransformationAccordingLayoutDirection (tranform -> transform)
    Closes #17587
    
    Differential Revision: D6832696
    
    Pulled By: shergin
    
    fbshipit-source-id: 452287e5ce82df5c6b87126cb21889b7bd9d73c1
    ss18 authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    8ffc16c View commit details
    Browse the repository at this point in the history
  3. Add minify flag to react-native bundle command

    Summary:
    We have found that it is useful to work with production rather than dev bundles when working on e.g. performance and animation tuning.
    
    For a larger app, `react-native bundle` with `--dev false` can get very slow due to minification - in our case, this was especially true of library code (e.g. the AWS SDK taking nearly 15 secs to minify on a top-spec MBP 15"). This is fine when just building every now and then, but when making frequent changes and rebuilding, it becomes quite painful.
    
    Currently there is no way to perform a release (non-dev) build, with minification disabled. This PR adds an optional `--minify` flag to enable developers to disable minification, reducing build times significantly for our use case.
    
    Checked output bundle size, to ensure behaviour stays the same as the existing default when `--minify` is not specified, and that the `minify` flag gets passed through to Metro bundler correctly if specified.
    
    N/A
    
    [GENERAL] [ENHANCEMENT] [Bundler] - Added optional --minify flag to bundler
    Closes #17702
    
    Differential Revision: D6806356
    
    Pulled By: shergin
    
    fbshipit-source-id: c466a2dea692561f8b2002118662c3affc71b991
    tomduncalf authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    3f969cb View commit details
    Browse the repository at this point in the history
  4. Synced ReactFabric render

    Reviewed By: fkgozali, sebmarkbage
    
    Differential Revision: D6839001
    
    fbshipit-source-id: 47b8278e883c33ca1f359dd16614f86c292e972d
    Brian Vaughn authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    c7ed03a View commit details
    Browse the repository at this point in the history
  5. Add support annotations dependency

    Summary:
    Should fix current test-android error in Circle CI.
    Closes #17774
    
    Differential Revision: D6837326
    
    Pulled By: hramos
    
    fbshipit-source-id: a53464d3abb52248c6565dee68e7e7f9be9a313f
    hramos authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9643204 View commit details
    Browse the repository at this point in the history
  6. Pass hasteImplModulePath to JestHasteMap and everywhere else

    Reviewed By: jeanlauliac
    
    Differential Revision: D6641294
    
    fbshipit-source-id: 36ebec95e69fe920c6cc10addd96406521cb4b82
    voideanvalue authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    619a8c9 View commit details
    Browse the repository at this point in the history
  7. Stub for clearButtonMode prop in RCTUITextView

    Summary: Even if we don't support this prop yet, we have to expose this in RCTUITextView to conform the contract between ViewManager and ShadowView.
    
    Reviewed By: sahrens
    
    Differential Revision: D6842304
    
    fbshipit-source-id: 7ea26974f595eba6a3c06df06ca01e46af2e63df
    shergin authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    ef4214a View commit details
    Browse the repository at this point in the history
  8. Add back ability to customise OkHttp client

    Summary:
    Prior to 0a71f48, users could customise the OkHttp client used by React Native on Android by calling replaceOkHttpClient in OkHttpClientProvider.
    
    This functionality has a variety of legitimate applications from changing connection timeouts or pool size to Stetho integration. The challenge is to add back support for replacing the client without causing a breaking change or reintroducing the problems olegbl sought to address in his original commit.
    
    Introducing a client factory archives these aims, it adds a new, backwards compatible interface and is called each time a client is requested rather than re-using the same instance (unless you explicitly want this behaviour, in which case you could replicate it using a static class property inside your custom factory).
    
    A number of PRs have been opened to add this functionality: #14675, #14068.
    
    I don't have a lot of Java experience so I'm open to better/more idiomatic ways to achieve this :)
    
    Create React Native application and set a custom factory in the constructor, e.g.  `OkHttpClientProvider.setOkHttpClientFactory(new CustomNetworkModule());`
    
    Where a custom factory would look like:
    
    ```
    class CustomNetworkModule implements OkHttpClientFactory {
        public OkHttpClient createNewNetworkModuleClient() {
            return new OkHttpClient.Builder().build();
        }
    }
    ```
    
    Remove the existing replace client method to prevent accident use and alert existing users that its functionality has changed: #16972
    
    [Android] [Minor] [Networking] - | Provide interface for customising the OkHttp client used by React Native |
    Closes #17237
    
    Differential Revision: D6837734
    
    Pulled By: hramos
    
    fbshipit-source-id: 81e63df7716e6f9039ea12e99233f6336c6dd7ef
    cdlewis authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    22efd95 View commit details
    Browse the repository at this point in the history
  9. Allow substituting a default font handler

    Reviewed By: nscoding
    
    Differential Revision: D6798995
    
    fbshipit-source-id: 541b4391428d1ee9c0b394033182dc232536c864
    Mehdi Mulani authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a9c684a View commit details
    Browse the repository at this point in the history
  10. Switch to yarn

    Summary:
    Switch to Yarn in order to more closely match internal Facebook environment.
    Closes #17193
    
    Differential Revision: D6572337
    
    Pulled By: hramos
    
    fbshipit-source-id: 331b1f331937e8ce3b787d48561e2e655d4a1cc9
    hramos authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    da8bec9 View commit details
    Browse the repository at this point in the history
  11. Fixing clowntown in RCTSurfaceRootShadowView

    Summary: Obvious.
    
    Reviewed By: mmmulani
    
    Differential Revision: D6829844
    
    fbshipit-source-id: 6c49be990fbcc3be2b5595866c3d1fd42a3eb3e9
    shergin authored and facebook-github-bot committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    5fba82d View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. Link both iOS and tvOS libraries with react-native link (fix #13783)

    Summary:
    Fix issues with the react-native CLI when linking iOS and tvOS libraries to a project created with `react-native init`. (#13783)
    
    Verified the changes against test project at https://github.com/dlowder-salesforce/react-native-link-test.  Both `react-native link react-native-svg` and `react-native unlink react-native-svg` work correctly on this project.  Added new unit test for the new file added to `local-cli/link/ios`.
    
    [CLI] [BUGFIX] `react-native link` has been fixed to correctly link iOS and tvOS targets.
    [IOS] [BUGFIX] `react-native link` has been fixed to correctly link iOS and tvOS targets.
    Closes #17231
    
    Differential Revision: D6837567
    
    Pulled By: hramos
    
    fbshipit-source-id: 234d3d3966ae1b89cd16a37c95d303553f7ba5f5
    douglowder authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    a63fd37 View commit details
    Browse the repository at this point in the history
  2. Udated create-react-class to version 15.6.3

    Reviewed By: acdlite
    
    Differential Revision: D6849403
    
    fbshipit-source-id: 8a04eab540edd902e1aa36a74b2596088201ae65
    Brian Vaughn authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    74f3866 View commit details
    Browse the repository at this point in the history
  3. Text: Enabling RCTVirtualText for iOS

    Summary:
    Without this change native RCTVirtualText module is unactive on iOS.
    This can cause bags in Text rendering because failback module (RCTVirtualText) does not popagate dirty status upward.
    
    Depends on D6842304.
    
    Reviewed By: yungsters, AaaChiuuu
    
    Differential Revision: D6854770
    
    fbshipit-source-id: ab8b7acd67309b7351c0074293ee6515a55385ce
    shergin authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    0009909 View commit details
    Browse the repository at this point in the history
  4. Synchronize map access

    Summary:
    We want applying deltas to be an atomic operation, from incrementing the delta message ID to updating the relevant maps.
    This is a simple approach to synchronize the corrsponding method.
    
    We will probably need to go with a more sophisticated approach, that makes sure that deltas are applied in order. That would also allow us to lock only on writes.
    
    Reviewed By: kathryngray
    
    Differential Revision: D6846560
    
    fbshipit-source-id: 175a80b4e39223883e397d75e20109fc12a2a878
    davidaurelio authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    e756251 View commit details
    Browse the repository at this point in the history
  5. Better handling exception in loadScript()

    Differential Revision: D6856807
    
    fbshipit-source-id: 36c527ee00eef56a5912ad6e4233d6cd61cb5170
    dcaspi authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    3fbf785 View commit details
    Browse the repository at this point in the history
  6. Implementing space-evenly

    Summary:
    So in v0.52.0 space-evenly is introduced but not yet implemented (1050e0b by woehrl01). This pull request implements the space-evenly.
    
    Manual Testing.
    ![notes marker](https://i.imgur.com/IXmezVY.png)
    
    [IOS] [FEATURE] [Yoga] Adding space-evenly on justify-content in iOS
    [ANDROID] [FEATURE] [Yoga] - Adding space-evenly on justify-content in Android
    Closes #17805
    
    Differential Revision: D6858294
    
    Pulled By: shergin
    
    fbshipit-source-id: 7a705ca05f58603ef4588e1bfd16c16a78f8a390
    gedeagas authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    b1cdb7d View commit details
    Browse the repository at this point in the history
  7. Measure touch events from nearest "root view"

    Summary:
    This makes RCTTouchHandler follow the same logic when sending touch event
    coordinates as `UIManager.measure`.
    This is important as UIManager.measure is used in `Touchable.js` aka the mother
    of all touch events in RN.
    
    In particular, this will make touch events correctly handled for places where RN is embedded into other screens.
    
    Reviewed By: shergin
    
    Differential Revision: D6838102
    
    fbshipit-source-id: 70cad52606ea931cb637d8aa2d4845818eea0647
    Mehdi Mulani authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    a70fdac View commit details
    Browse the repository at this point in the history
  8. Generate JUnit test reports for iOS builds

    Summary: Closes #17794
    
    Differential Revision: D6850015
    
    Pulled By: hramos
    
    fbshipit-source-id: bd230a5aa6fe14fb760f7b0c5f0989bf6ee1e8ea
    hramos authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    a2f3ba8 View commit details
    Browse the repository at this point in the history
  9. Fixed typo in RCTSurfaceRootShadowView

    Summary:
    Trivial.
    Special thanks to janicduplessis
    
    Created from Diffusion's 'Open in Editor' feature.
    
    Reviewed By: fkgozali
    
    Differential Revision: D6863932
    
    fbshipit-source-id: d40a30271adc5c8d47149ab920e2ac11158ab756
    shergin authored and facebook-github-bot committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    d74ff6f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Move danger to bots directory

    Summary:
    No logic change here. Part of a plan to consolidate CI-only files amongst .circleci and bots/ directories.
    Closes #17807
    
    Differential Revision: D6865976
    
    Pulled By: hramos
    
    fbshipit-source-id: 48607a80dcf8cac1c3c033c18bf5d6dd4cd8e6bf
    hramos authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    22a2553 View commit details
    Browse the repository at this point in the history
  2. Run more checks in parallel

    Summary: Closes #17808
    
    Differential Revision: D6866937
    
    Pulled By: hramos
    
    fbshipit-source-id: 34c9aa93a5274b57da81eb5bbece2ce3e5296846
    hramos authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    365a4d4 View commit details
    Browse the repository at this point in the history
  3. Use delete instead of free

    Reviewed By: richardjrossiii
    
    Differential Revision: D6866064
    
    fbshipit-source-id: a44828cedb5045b6c97179fb30ffd8c8dafcbfbe
    ryu2 authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    9f57ded View commit details
    Browse the repository at this point in the history
  4. Implement bundle sync status

    Reviewed By: pakoito
    
    Differential Revision: D6807480
    
    fbshipit-source-id: d71f2cecd882c47e79bb71dfb9d03d3597fa4068
    rayshih authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    88980f2 View commit details
    Browse the repository at this point in the history
  5. Remove release from ReadableNativeArray and Map

    Reviewed By: mhorowitz
    
    Differential Revision: D6846268
    
    fbshipit-source-id: 2f750a05ee63a744e7f64b3fe67736df3614ef3d
    Kathy Gray authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    28be33a View commit details
    Browse the repository at this point in the history
  6. Update build-js-bundle run step

    Summary:
    Always build the JavaScript bundle, to ensure failures here are surfaced regardless of failures that may happen earlier in this workflow
    Closes #17824
    
    Differential Revision: D6872794
    
    Pulled By: hramos
    
    fbshipit-source-id: bab3b9cfa6cecb578e9a3cffae27e1ce355588d2
    hramos authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    9227ba7 View commit details
    Browse the repository at this point in the history
  7. Stub for caretHidden prop in RCTUITextView

    Summary:
    Even if we don't support this prop yet, we have to expose this in RCTUITextView to conform the contract between ViewManager and ShadowView.
    Same story as D6842304.
    Depends on D6842304.
    
    Reviewed By: fmoo
    
    Differential Revision: D6869750
    
    fbshipit-source-id: 9b35f1a38040319ec66f1ec12f97ac739f8b204f
    shergin authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    74963eb View commit details
    Browse the repository at this point in the history
  8. use scrollview for lightbox on ios

    Reviewed By: wwalser
    
    Differential Revision: D6858376
    
    fbshipit-source-id: a9ff9c71cb4ad56a4f5af73a4e86de52ddf75700
    sahrens authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    e485cde View commit details
    Browse the repository at this point in the history
  9. React sync for revisions a7b9f98...4eed18d

    Reviewed By: gaearon
    
    Differential Revision: D6875052
    
    fbshipit-source-id: 516f46f1b78bd8ca3323ba119d3afda491d76497
    Brian Vaughn authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    1382975 View commit details
    Browse the repository at this point in the history
  10. Keep the ignored files during the upgrade process

    Summary:
    This PR fixes the issue #12237 relative to react-native-git-upgrade.
    
    When the user adds new files to the .gitignore file, those files are deleted during the upgrade process because it starts by creating a fresh .gitignore file without user's modification, so the user's ignored files are no longer ignored and they are deleted during the upgrading process.
    
    The best solution I've found to keep the user's ignored files... ignored, consists in appending the content of the .gitignore file in the `<TEMP DIR>/.git-rn/info/exclude` file.
    The user's ignored files are now ignored at the repository level, they no longer interfere with the upgrade process.
    
    Reminder: The tool uses a temporary local Git repository generated on the fly, so we can do whatever we want in it.
    
    - Publish react-native-git-upgrade to sinopia
    - `npm install -g react-native-git-upgrade`
    - Init a new project with an old version: `react-native init MyApp --version=0.50.0`
    - Create a new file named `dummy-ignored-file.json` in the project's root
    - Append `dummy-ignored-file.json` to the `.gitignore` file
    - Run `react-native-git-upgrade`
    
    👉 The `dummy-ignored-file.json` is not deleted.
    
    [CLI][BUGFIX][react-native-git-upgrade] - Keep the user's ignored files while upgrading
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17393
    
    Differential Revision: D6839856
    
    Pulled By: hramos
    
    fbshipit-source-id: e4e9d759b59790e3cbc52408cef8314bf0a9c772
    ncuillery authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    7492860 View commit details
    Browse the repository at this point in the history
  11. Fixed double onChange event triggering from <TextInput> on iOS

    Summary:
    The problem was recently introduced in the last refactoring of the Text module.
    There are two problem actually:
    (1) Compare this current code with stable version.
    In the stable version the event is only triggered here:
    https://github.com/facebook/react-native/blob/0.52-stable/Libraries/Text/RCTTextField.m#L132-L140
    In the new version the event is triggered in two places (which is obviously wrong).
    
    (2) Executing `[_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange:...]` and _onChange() actually do the same thing.
    Historically, the single-line <TextInput> used the first approach and multi-line used second one. When we unify the logic, mixed both of them, which was apparenly wrong.
    So, we have to remove another call of `[_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange:...]`.
    The the future we have to completly remove usage of `_eventDispatcher` from this component.
    
    Depends on D6854770.
    
    Reviewed By: fkgozali
    
    Differential Revision: D6869678
    
    fbshipit-source-id: 6705ee8dda2681ae184ef6716238cc8b62efeff1
    shergin authored and facebook-github-bot committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    d7fa81f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2018

  1. Improved documentation for <TextInput caretHidden=...>

    Summary:
    Documentation only.
    
    Created from Diffusion's 'Open in Editor' feature.
    
    Reviewed By: sahrens
    
    Differential Revision: D6878890
    
    fbshipit-source-id: 23f58246625ab6664bc3dcd4490f24ee50e410c8
    shergin authored and facebook-github-bot committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    6c4ef28 View commit details
    Browse the repository at this point in the history
  2. RN: Add NativeImageSource Flow Type

    Reviewed By: TheSavior
    
    Differential Revision: D6869985
    
    fbshipit-source-id: 836134ae0919d49b161d1a75d5743e977e6eb3f4
    yungsters authored and facebook-github-bot committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    d99ba70 View commit details
    Browse the repository at this point in the history
  3. Uses findMetroConfig and fetchMetroConfig in the internal RN cli

    Reviewed By: davidaurelio
    
    Differential Revision: D6819226
    
    fbshipit-source-id: 6436855cc5dce9ce7922d89df99c3cb90abb095e
    Maël Nison authored and facebook-github-bot committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    752427b View commit details
    Browse the repository at this point in the history
  4. Remove the use of legacy flag and log the diff if its used

    Reviewed By: emilsjolander
    
    Differential Revision: D6856812
    
    fbshipit-source-id: e4724d80702cc75c1894e348e137b24e663573d2
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    9f7cedb View commit details
    Browse the repository at this point in the history
  5. Improved documentation for <TextInput clearButtonMode=...>

    Summary:
    Documentation only. Actual behaviour was never changed.
    
    Created from Diffusion's 'Open in Editor' feature.
    
    Reviewed By: sahrens
    
    Differential Revision: D6869466
    
    fbshipit-source-id: 6e964433bb2b04b288736a3f01244285bc8c3fe8
    shergin authored and facebook-github-bot committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    ebc9884 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2018

  1. Fix initialScrollIndex for Android

    Reviewed By: sahrens
    
    Differential Revision: D6885608
    
    fbshipit-source-id: c153fcb5c2552982481d8af8b9755ae035e9b293
    olegbl authored and facebook-github-bot committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    ef596de View commit details
    Browse the repository at this point in the history
  2. Added progress updates for all XMLHttpRequest upload types / fix cras…

    …h on closed connection
    
    Summary:
    This PR includes the same changes made in #16541, for addressing issues #11853/#15724. It adds upload progress updates for uploads with any request body type, and not just form-data.
    
    Additionally, this PR also includes a commit for fixing an `IllegalStateException` when a user's connection gets closed or times out (issues #10423/#11016). Since this exception was occurring within the progress updates logic, it started being thrown more frequently as a result of adding progress updates to all uploads, which was why the original PR was reverted.
    
    To test the upload progress updates, run the following JS to ensure events are now being dispatched:
    ```
    const fileUri = 'file:///my_file.dat';
    const url = 'http://my_post_url.com/';
    const xhr = new XMLHttpRequest();
    
    xhr.upload.onprogress = (event) => {
        console.log('progress: ' + event.loaded + ' / ' + event.total);
    }
    
    xhr.onreadystatechange = () => {if (xhr.readyState === 4) console.log('done');}
    
    console.log('start');
    
    xhr.open('POST', url);
    
    // sending a file (wasn't sending progress)
    xhr.setRequestHeader('Content-Type', 'image/jpeg');
    xhr.send({ uri: fileUri });
    
    // sending a string (wasn't sending progress)
    xhr.setRequestHeader('Content-Type', 'text/plain');
    xhr.send("some big string");
    
    // sending form data (was already working)
    xhr.setRequestHeader('Content-Type', 'multipart/form-data');
    const formData = new FormData(); formData.append('test', 'data');
    xhr.send(formData);
    ```
    
    To test the crash fix:
    In the RN Android project, before this change, set a breakpoint at `mRequestBody.writeTo(mBufferedSink);` of `ProgressRequestBody`, and wait a short while for a POST request with a non-null body to time out before resuming the app. Once resumed, if the connection was closed (the `closed` variable will be set to true in `RealBufferedSink`), an `IllegalStateException` will be thrown, which crashes the app. After the changes, an `IOException` will get thrown instead, which is already being properly handled.
    
    As mentioned above, includes the same changes as #16541, with an additional commit.
    
    [ANDROID] [BUGFIX] [XMLHttpRequest] - Added progress updates for all XMLHttpRequest upload types / fix crash on closed connection
    
    Previously, only form-data request bodies emitted upload progress updates. Now, other request body types will also emit updates. Also, Android will no longer crash on certain requests when user has a poor connection.
    
    Addresses issues: 11853/15724/10423/11016
    Closes #17312
    
    Differential Revision: D6712377
    
    Pulled By: mdvacca
    
    fbshipit-source-id: bf5adc774703e7e66f7f16707600116f67201425
    allengleyzer authored and facebook-github-bot committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    9e436d1 View commit details
    Browse the repository at this point in the history
  3. Update react-devtools@3.1.0 in prep for React 16.3

    Reviewed By: gaearon
    
    Differential Revision: D6886480
    
    fbshipit-source-id: 09ca9ea8e20bc050ba30ae4e5f73495cace426f5
    Brian Vaughn authored and facebook-github-bot committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    8235a49 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Moved out logic to calculate size consumed on a line into seperate fu…

    …nction
    
    Reviewed By: emilsjolander
    
    Differential Revision: D6797640
    
    fbshipit-source-id: ad9757e7d603c0ce57f452b1e5c404037605bed9
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    34b7ec8 View commit details
    Browse the repository at this point in the history
  2. Replaced first pass with a function

    Reviewed By: emilsjolander
    
    Differential Revision: D6819719
    
    fbshipit-source-id: e5e77c21d1dca2255433da3388887d9db3f7b642
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    fda861a View commit details
    Browse the repository at this point in the history
  3. Seperate function for second pass

    Reviewed By: emilsjolander
    
    Differential Revision: D6833635
    
    fbshipit-source-id: 7680a67db8bfe22f8fb86407159888882f3a3353
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    ca91f0e View commit details
    Browse the repository at this point in the history
  4. Made a separate function for resolving flexible length

    Reviewed By: emilsjolander
    
    Differential Revision: D6834269
    
    fbshipit-source-id: 954bc7fe8eb9256d353cdda27e5c64c076808e25
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    d4517dd View commit details
    Browse the repository at this point in the history
  5. Do not expose BundleDownloader from DevServerHelper

    Summary:
    Adds `downloadBundleFromURL` as a delegating method to `DevServerHelper` rather than exposing the underlying `BundleDownloader`.
    
    The additional encapsulation will allow futher factoring of `BundleDownloader` to make logic for different delta bundler clients easier to implement and maintain.
    
    Reviewed By: pakoito
    
    Differential Revision: D6871225
    
    fbshipit-source-id: 6adcab5e69869a234baf38f1f1e60abd34d6b555
    davidaurelio authored and facebook-github-bot committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    108f966 View commit details
    Browse the repository at this point in the history
  6. Delete RCTBatchedBridge

    Summary:
    I've talked to several major community users, and they're all ok with deleting this
    code.  There's several doc fixes which will make it easier for third
    party developers which should land about the same time this will.
    
    Also buried along with it is RCTJSCExecutor.
    
    Reviewed By: javache
    
    Differential Revision: D6880781
    
    fbshipit-source-id: b4cb1143def6fd23a96290e478fa728adbedacd3
    mhorowitz authored and facebook-github-bot committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    816d417 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Bump metro@0.25.0

    Reviewed By: davidaurelio
    
    Differential Revision: D6878299
    
    fbshipit-source-id: cde26c9c9e56ee9a052f1915ad7772ae475b5e41
    rafeca authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    ce50f25 View commit details
    Browse the repository at this point in the history
  2. processUpdatedProperties & collectUpdatedProperties was removed f…

    …rom RCTShadowView
    
    Summary: This is leftovers from last <Text> reimplementation; nobody uses it and it does not hooked up with UIManager.
    
    Reviewed By: fkgozali
    
    Differential Revision: D6887795
    
    fbshipit-source-id: 9e2e29af4ba959270096eeb494666d1cacaeba32
    shergin authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    0f9fc4b View commit details
    Browse the repository at this point in the history
  3. Removed [ShadowView collectUpdatedFrames:]

    Summary: Another juicy leftover from old Text implementation.
    
    Reviewed By: fkgozali
    
    Differential Revision: D6887942
    
    fbshipit-source-id: d0363d06d566554c03d0ae3293597daf9c387028
    shergin authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    9dfa2e7 View commit details
    Browse the repository at this point in the history
  4. [RCTShadowView isHidden] was removed

    Summary:
    It's unused.
    Use `display` prop instead to control visiblity of the view.
    
    Reviewed By: fkgozali
    
    Differential Revision: D6888104
    
    fbshipit-source-id: dd37a365033ec36bdfcfa305ec6a965a10dec2cd
    shergin authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    c19bc79 View commit details
    Browse the repository at this point in the history
  5. Removing our own implementation of round-to-pixel algorithm

    Summary:
    > Okay, I don't remember where we first met
    > But hey, admitting is the first step
    
    This issue has a looong history.
    The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
    The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
    For now, the vision is clear:
     * The basic algorithm should live in Yoga for unification and performance reasons.
     * We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
     * We have to enable it in RN eventually.
    
    So, this is the first step: Removing old, broken code which we don't plan to fix and use.
    
    Make React Native crisp again!
    
    Reviewed By: fkgozali
    
    Differential Revision: D6888662
    
    fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
    shergin authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    ceb1d1c View commit details
    Browse the repository at this point in the history
  6. Enabling round-to-pixel Yoga feature for RN (iOS)

    Summary:
    This change enables built-in Yoga mechanism which rounds producing layout metrics to closest "pixel" values.
    See previous diff for more context.
    
    Reviewed By: fkgozali
    
    Differential Revision: D6889762
    
    fbshipit-source-id: bc2eea44704db4b377e2e14fab9f67be8c935719
    shergin authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    114c258 View commit details
    Browse the repository at this point in the history
  7. Fixed failing snapshot test

    Reviewed By: emilsjolander
    
    Differential Revision: D6901242
    
    fbshipit-source-id: 7391d6a34fa28e9f92f4ff834755a89dd876fdad
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    9658d9f View commit details
    Browse the repository at this point in the history
  8. Moved out main axis justification logic to seperate function

    Reviewed By: emilsjolander
    
    Differential Revision: D6845997
    
    fbshipit-source-id: fdb64e00de39427ce1d66d4fbfd06c23c0d32bcf
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    9daa174 View commit details
    Browse the repository at this point in the history
  9. Moved trailing padding and border function as a method on YGNode

    Reviewed By: emilsjolander
    
    Differential Revision: D6899571
    
    fbshipit-source-id: 7f686e8771d5a94aae502191516557b20c557d7c
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    1475fc4 View commit details
    Browse the repository at this point in the history
  10. Moved margin axis function as a method in YGNode

    Reviewed By: emilsjolander
    
    Differential Revision: D6900003
    
    fbshipit-source-id: a42da3bcd3126bf8c432c6740987b5ec0b572172
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    62d0100 View commit details
    Browse the repository at this point in the history
  11. Rename workflow steps

    Summary:
    Trivial - shorten the workflow steps to ease reading of current status when looking at workflows dashboard.
    Closes #17874
    
    Differential Revision: D6912599
    
    Pulled By: hramos
    
    fbshipit-source-id: c4bb08923eb790960b883a7a5f6e4652663982d8
    hramos authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    613afba View commit details
    Browse the repository at this point in the history
  12. Switch e2e to yarn

    Summary:
    Addresses CI build failures due to use of scoped packages by metro.
    Closes #17878
    
    Differential Revision: D6914937
    
    Pulled By: hramos
    
    fbshipit-source-id: e6ce97561035f4deb128cd1e30d81ab4edea3e4c
    hramos authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    fa11fae View commit details
    Browse the repository at this point in the history
  13. Ignore dangerfile

    Summary: Closes #17880
    
    Differential Revision: D6915622
    
    Pulled By: hramos
    
    fbshipit-source-id: 1dff643575c206e51d7486b4bebfd9a6a23e0c14
    hramos authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    1ea3065 View commit details
    Browse the repository at this point in the history
  14. Consolidate bundle URL creation

    Summary:
    `DevServerHelper` had multiple places that created bundle URLs.
    This consolidates that logic into a single place, and uses an enum for different "bundle types" (bundle, bundle deltas, source maps).
    
    Reviewed By: pakoito
    
    Differential Revision: D6900906
    
    fbshipit-source-id: 64ed9360ea85dc5755308d822d5fc55fe8cb5a55
    davidaurelio authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    644123a View commit details
    Browse the repository at this point in the history
  15. Clean up DevServerHelper

    Summary:
    - Makes methods private that are not used elsewhere
    - Moves a method to `DevSupportManagerImpl`
    - Removes unused methods
    
    Reviewed By: pakoito
    
    Differential Revision: D6900907
    
    fbshipit-source-id: c8d9f748effd396fe610f0d4d87e0bc388e155d6
    davidaurelio authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    6e44356 View commit details
    Browse the repository at this point in the history
  16. Extract delta client

    Summary: Extracts the delta client from the bundle downloader. This will allow us to extract an interface, and provide a different implementation for C++ delta bundling (where we will pass deltas directly to native code).
    
    Reviewed By: pakoito
    
    Differential Revision: D6900904
    
    fbshipit-source-id: 358705615eecc15afa0de3e50478468ad840d250
    davidaurelio authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    1019bda View commit details
    Browse the repository at this point in the history
  17. Remove unused method

    Summary: Removes `BundleDownloader#cancelDownloadBundleFromURL`
    
    Reviewed By: pakoito
    
    Differential Revision: D6900903
    
    fbshipit-source-id: d9297344d6296d79a984aeecb3e014c9ed23a165
    davidaurelio authored and facebook-github-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    f88c9d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. Declare HMRClient module to fix Flow issues in OSS

    Summary: Closes #17881
    
    Differential Revision: D6918186
    
    Pulled By: hramos
    
    fbshipit-source-id: ebcdbde1623eab497062fb50bccb393734b3578f
    hramos authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    a1c479f View commit details
    Browse the repository at this point in the history
  2. Support non-integer modulus in ModulusAnimatedNode on Android

    Summary:
    `Animated.modulo(value, modulus)` supports a non-integer modulus in the iOS and JS implementations but crashes on Android when `useNativeDriver` is set to `true`.
    
    Unfortunately, I'm not fluent enough with this codebase to add a Java test for this fix - especially as I couldn't find any analogous tests to extrapolate from. However, the fix itself seems straightforward enough.
    
    None needed
    
    [ANDROID] [BUGFIX] [Animated] - Support non-integer modulus in .modulo()
    Closes #17860
    
    Differential Revision: D6918799
    
    Pulled By: hramos
    
    fbshipit-source-id: 8d15e4bc881ed41a4123c6f811c0c72119f67be0
    motiz88 authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    6c38972 View commit details
    Browse the repository at this point in the history
  3. Fix adjustsFontSizeToFit to only shrink, not grow, text

    Reviewed By: shergin
    
    Differential Revision: D6913407
    
    fbshipit-source-id: 3fdeeee1a28917f623fc9f804c1b28216cba5375
    sahrens authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    8a882fe View commit details
    Browse the repository at this point in the history
  4. Added ReactFabric shim

    Summary:
    A simple shim just like ReactNative.js
    Plus a fork of renderApplication that exclusively will call ReactFabric.
    
    Reviewed By: mdvacca
    
    Differential Revision: D6919080
    
    fbshipit-source-id: 5807105a6c45dd99584eb92a5570c6076e2d56b9
    fkgozali authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    94dac23 View commit details
    Browse the repository at this point in the history
  5. iOS: Added scaffolding for FabricUIManager native module

    Summary: Experimental scaffolding for FabricUIManager.
    
    Reviewed By: mdvacca
    
    Differential Revision: D6908587
    
    fbshipit-source-id: 646fcc72f54dce736378a7777e5753ed56efc2f6
    fkgozali authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    b1e5c01 View commit details
    Browse the repository at this point in the history
  6. Convert intent_binary_defs to Skylark

    Reviewed By: ttsugriy
    
    Differential Revision: D6910777
    
    fbshipit-source-id: b661be9f2383ca93b940dc7b625f46ae9725ebd7
    Jakub Grzmiel authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    d3db764 View commit details
    Browse the repository at this point in the history
  7. Inline format strings in DevServerHelper

    Summary: Having format strings and values to interpolate separated makes reading the respective calls difficult. It has also led to situations where format strings were reused with slightly different values, instead of creating a parameterized method.
    
    Reviewed By: pakoito
    
    Differential Revision: D6900905
    
    fbshipit-source-id: 68b56af6a86c0b46bc8cf9c44fbe0fb93ee151ac
    davidaurelio authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    06d8f96 View commit details
    Browse the repository at this point in the history
  8. Native Modules -> Native Extensions

    Reviewed By: danzimm
    
    Differential Revision: D6887988
    
    fbshipit-source-id: 475c05f60a2e1ddcfaa9263ab363bff8a528236a
    Dmitry Zakharov authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    0c49c1f View commit details
    Browse the repository at this point in the history
  9. Upgrade Jest to v22.2.1

    Reviewed By: rafeca
    
    Differential Revision: D6923664
    
    fbshipit-source-id: 0751ee6f0eb72193b0b22bb38d0398b3d83592a3
    Miguel Jimenez Esun authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    46f4d3e View commit details
    Browse the repository at this point in the history
  10. Fix screenshot test due main axis justification refactor

    Reviewed By: emilsjolander
    
    Differential Revision: D6923178
    
    fbshipit-source-id: d8f81b06d9127c75daecffb73b5e6c5abbad8ade
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    64d530b View commit details
    Browse the repository at this point in the history
  11. Bump metro@0.25.1

    Reviewed By: cpojer
    
    Differential Revision: D6924028
    
    fbshipit-source-id: f643bd912b201a5333778f124b0c21acf84814df
    rafeca authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    9e6f3b8 View commit details
    Browse the repository at this point in the history
  12. textinput: Maintain cursor position when secureTextEntry toggles.

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    On current [master](https://github.com/facebook/react-native/tree/8235a49a33cc8e84cd4ba1cc15bc09eed6712b4c), text input cursor resets to start when `secureTextEntry` prop toggles on Android. This motivate me to maintain position when `secureTextEntry ` prop toggles for better user experience.
    
    On current [master](https://github.com/facebook/react-native/tree/8235a49a33cc8e84cd4ba1cc15bc09eed6712b4c)
    ![ezgif com-video-to-gif-3](https://user-images.githubusercontent.com/18511177/35776882-bdc3b182-09ca-11e8-8f4e-218fae0a24a1.gif)
    
    On this PR
    ![ezgif com-video-to-gif-4](https://user-images.githubusercontent.com/18511177/35776883-be082d94-09ca-11e8-9424-6164110bdf03.gif)
    
    [ANDROID] [BUGFIX] [TextInput] - Fix: cursor positions resets to start on toggling `secureTextEntry` prop.
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17851
    
    Differential Revision: D6925711
    
    Pulled By: hramos
    
    fbshipit-source-id: 6d53ad2dbed2dca20cd21e5b1b0578be13a91aad
    jainkuniya authored and facebook-github-bot committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    09b43e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. call margin method on child instead of node

    Reviewed By: emilsjolander
    
    Differential Revision: D6918367
    
    fbshipit-source-id: cee90e015f9e45a717a7307f59fd3b9ef6f399b6
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    f75e21f View commit details
    Browse the repository at this point in the history
  2. @allow-large-files [flow] upgrade to v0.65.0

    Reviewed By: gabelevi
    
    Differential Revision: D6927764
    
    fbshipit-source-id: 1cb21c6bf27e12624c23387485b263ee8e77f5e0
    mroch authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    7aba456 View commit details
    Browse the repository at this point in the history
  3. FIGCardHeader updates

    Reviewed By: TheSavior
    
    Differential Revision: D6914352
    
    fbshipit-source-id: 7ee12999d19d665509e225d15cb263cbafafe258
    sahrens authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    d37cdd9 View commit details
    Browse the repository at this point in the history
  4. Remove fbobjc's RN copy

    Reviewed By: mzlee
    
    Differential Revision: D6748752
    
    fbshipit-source-id: 95a646948e4daa43d2e812782e0c8c3a88efe986
    Jonathan Kim authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    af0c863 View commit details
    Browse the repository at this point in the history
  5. Expose a function which marks all descendants dirty

    Reviewed By: emilsjolander
    
    Differential Revision: D6911869
    
    fbshipit-source-id: e0a3abcf5653f921297edfdca473d83b947cc627
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    528bbac View commit details
    Browse the repository at this point in the history
  6. Migrate SourceCode from Native Module to a Native Extension.

    Reviewed By: danzimm
    
    Differential Revision: D6848275
    
    fbshipit-source-id: c50305018aa2bdf014f5f665f370f65866197c3b
    Dmitry Zakharov authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    47fe523 View commit details
    Browse the repository at this point in the history
  7. Revert PR #17312 due to buck failures in continuous integration tests

    Summary:
    Circle is currently failing on the `android` step due to a dependency issue introduced by the aforementioned PR. I am currently waiting for an internal diff to be reviewed which will restore this PR alongside the necessary dependency.
    Closes #17902
    
    Differential Revision: D6937173
    
    Pulled By: hramos
    
    fbshipit-source-id: f732a397521cc5df36f503e618318ef6d69aeaa6
    hramos authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    2f02dd4 View commit details
    Browse the repository at this point in the history
  8. Add CountingOutputStream

    Reviewed By: mdvacca
    
    Differential Revision: D6932872
    
    fbshipit-source-id: 226f30833a786d0c03564f25ec8c4f43d94c48f4
    hramos authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    a5e135a View commit details
    Browse the repository at this point in the history
  9. Skylarkify RN defs.

    Reviewed By: adamjernst
    
    Differential Revision: D6934209
    
    fbshipit-source-id: 59f50b739482a53473c157f9e0183024dc88dc67
    ttsugriy authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    79a63d0 View commit details
    Browse the repository at this point in the history
  10. Enable platforms to configure CLI commands

    Summary:
    This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories.
    
    (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
    
    - All jest tests, including new tests, pass.
    - `link` and `unlink` commands are successful on iOS and Android.
    
    (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
    
    microsoft/react-native-windows#1601
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig.
    [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command.
    [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command.
    Closes #17745
    
    Differential Revision: D6883558
    
    Pulled By: hramos
    
    fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b
    rozele authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    a40bfa7 View commit details
    Browse the repository at this point in the history
  11. always create debugger websocket connection

    Reviewed By: Hypuk, pakoito
    
    Differential Revision: D6918269
    
    fbshipit-source-id: 3175c75d4e8459a61d7907555ab9bd4e95002853
    bnham authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    fa334ce View commit details
    Browse the repository at this point in the history
  12. Ran rename-unsafe-lifecycles codemod on xplat/js

    Reviewed By: trueadm
    
    Differential Revision: D6889214
    
    fbshipit-source-id: e815cda4b09f3650ae3b0b9a44ae6f5fcb48fe25
    Brian Vaughn authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    6f007e8 View commit details
    Browse the repository at this point in the history
  13. Convert fb_xplat_cxx to Skylark

    Reviewed By: ttsugriy
    
    Differential Revision: D6937683
    
    fbshipit-source-id: 472c95b393d054c29413a46b86bf03559aff8741
    Jakub Grzmiel authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    a8c95d2 View commit details
    Browse the repository at this point in the history
  14. Consolidate checkout and yarn steps

    Summary:
    Add checkout steps to reduce number of checkout/yarn calls
    
    Tested on Circle CI.
    Closes #17915
    
    Differential Revision: D6942564
    
    Pulled By: hramos
    
    fbshipit-source-id: 72aff33eb099e24d63a80ec7d0630afedc21b630
    hramos authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    4f078d3 View commit details
    Browse the repository at this point in the history
  15. Move approval to separate deploy workflow

    Summary: Closes #17916
    
    Differential Revision: D6943605
    
    Pulled By: hramos
    
    fbshipit-source-id: 0e86f01aa38c15e5bc179c5e517f079eb34d495f
    hramos authored and facebook-github-bot committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    40b1792 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2018

  1. Checkout code prior to deploy

    Summary: Closes #17917
    
    Differential Revision: D6944553
    
    Pulled By: hramos
    
    fbshipit-source-id: 013f5e75bd61d939fe650729c9c388a78bede330
    hramos authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    2ef9b7f View commit details
    Browse the repository at this point in the history
  2. Restore copyright header

    Summary:
    Restoring the copyright header on some files, in order to fix an internal lint failure that is raised whenever these files are edited on open source.
    Closes #17912
    
    Differential Revision: D6938189
    
    Pulled By: hramos
    
    fbshipit-source-id: 6447d8ad6d7ecce0ef5f1821f63e44957bbf6d15
    hramos authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    4f883bd View commit details
    Browse the repository at this point in the history
  3. Introduce new Fabric API in RNAndroid

    Summary: Introduce new Fabric FabricUIManagerModule RNAndroid
    
    Reviewed By: achen1
    
    Differential Revision: D6833154
    
    fbshipit-source-id: 9ab7ff8bf0c407d833c512eb3455969573f138da
    mdvacca authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    2d35bde View commit details
    Browse the repository at this point in the history
  4. call into native FabricUIManager from JS

    Reviewed By: mdvacca
    
    Differential Revision: D6945104
    
    fbshipit-source-id: ac66c6105c0d18bef003cdd08d06dbb49c61e669
    fkgozali authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    fa0ac92 View commit details
    Browse the repository at this point in the history
  5. fixed blobmanager inserting nil when there's no mime type

    Summary:
    Upon handling symbolication response when a redbox occurs, the blob manager inserted `nil` mime type because the response header doesn't specify any. This crashed the app with exception:
    
    ```
    *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[4]'
    terminating with uncaught exception of type NSException
    ```
    
    Reviewed By: shergin
    
    Differential Revision: D6945632
    
    fbshipit-source-id: 9298bd2674447106763c73e1a5035417bd30f29c
    fkgozali authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    854c233 View commit details
    Browse the repository at this point in the history
  6. JSIExecutor Bundle Splitting Support

    Reviewed By: mhorowitz
    
    Differential Revision: D6847638
    
    fbshipit-source-id: d9ae3d182d6f07bcac81cfd06dcc19f8139bb1e4
    fromcelticpark authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    1a1a956 View commit details
    Browse the repository at this point in the history
  7. Fix memory leak by not duplicating the YGConfig

    Reviewed By: emilsjolander
    
    Differential Revision: D6945022
    
    fbshipit-source-id: 5fd3c3e2ac1cd94d459d5aa06e0daa8f107779ac
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    400a29e View commit details
    Browse the repository at this point in the history
  8. Add flag in YGConfig for running experiments

    Reviewed By: emilsjolander
    
    Differential Revision: D6948702
    
    fbshipit-source-id: 009fe2d64b6098f8c3a0289f0e6939dea5ce0d37
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    fdef378 View commit details
    Browse the repository at this point in the history
  9. Added progress updates for all XMLHttpRequest upload types / fix cras…

    …h on closed connection
    
    Reviewed By: mdvacca
    
    Differential Revision: D6937754
    
    fbshipit-source-id: 89b963e16adf1bd3200806fd7374d28aa618b62f
    hramos authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    27b6348 View commit details
    Browse the repository at this point in the history
  10. Removed ReactNativeFeatureFlags

    Reviewed By: flarnie
    
    Differential Revision: D6938455
    
    fbshipit-source-id: 1ad08ebf01dcae76f50b26fb993425233da1ae16
    Brian Vaughn authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    e701034 View commit details
    Browse the repository at this point in the history
  11. Namespace custom ESLint rules through eslint-plugin-lint

    Reviewed By: mzlee
    
    Differential Revision: D6934651
    
    fbshipit-source-id: 3cb0c3550ad628e3b5c0bdaec8cde9d5579ea0af
    zertosh authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    488b682 View commit details
    Browse the repository at this point in the history
  12. Stop using GitHub bot commands for now

    Summary: Closes #17929
    
    Differential Revision: D6953331
    
    Pulled By: hramos
    
    fbshipit-source-id: d7b50b18a2c2e5826ed2af5f5ef08ed9aa2878bf
    hramos authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    b973fe4 View commit details
    Browse the repository at this point in the history
  13. Fixing Prepack model for latest global.nativeExtensions changes.

    Differential Revision: D6943293
    
    fbshipit-source-id: cb67b063b77e8f89712fb437fc5471b7f874c482
    NTillmann authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    01a58d1 View commit details
    Browse the repository at this point in the history
  14. Use ConcurrentHashMap for handling concurrent Android websockets, and…

    Summary:
    … prevent unknown websocket IDs from crashing on Android (show warning on development builds instead)
    
    This PR addresses #3346; an unknown websocket ID should produce a warning during development, but not cause crashes in production RN apps. This PR was created by satya164's request, and was inspired by tanthanh289's suggestion on #3346's thread.
    
    On Android, create a websocket using a service like Pusher (`pusher-js` npm package) or manually, and then induce removal of its websocket ID. Result should be a red warning screen during development, and no crash in the app's release variant.
    
     [ANDROID] [BUGFIX] [WebSocket] - Prevent unknown websocket IDs from crashing on Android
    Closes #17884
    
    Differential Revision: D6954038
    
    Pulled By: hramos
    
    fbshipit-source-id: b346d80d7568996b8819c0de54552abb534cbfae
    sunweiyang authored and facebook-github-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    1a790f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2018

  1. Clean up unused macros after consolidation

    Reviewed By: mzlee
    
    Differential Revision: D6954781
    
    fbshipit-source-id: 0ec78e6f7f2780951ac008e9b12f41cfd5441ed5
    Jonathan Kim authored and facebook-github-bot committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    e233646 View commit details
    Browse the repository at this point in the history
  2. React sync for revisions 4eed18d...467b103

    Reviewed By: bvaughn
    
    Differential Revision: D6953225
    
    fbshipit-source-id: f96e3cec57cce397d46d49115dd3734a33427992
    hramos authored and facebook-github-bot committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    5e80d95 View commit details
    Browse the repository at this point in the history
  3. bump Android cache key

    Summary: Closes #17934
    
    Differential Revision: D6956755
    
    Pulled By: hramos
    
    fbshipit-source-id: 518171156638effc279f17b38c379e029ed23ba0
    hramos authored and facebook-github-bot committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    51b6749 View commit details
    Browse the repository at this point in the history
  4. Upgrade to ESLint v4.17.0 (plus update related deps)

    Reviewed By: adamjernst
    
    Differential Revision: D6956725
    
    fbshipit-source-id: d223aa238dbb67190a1c244c7d482fc95005ccb0
    zertosh authored and facebook-github-bot committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    bba19e8 View commit details
    Browse the repository at this point in the history
  5. Fix ESLint upgrade "parsing error"

    Reviewed By: adamjernst
    
    Differential Revision: D6959356
    
    fbshipit-source-id: 77c61998f23a6acd7cdfe2c87d8760a23d957800
    zertosh authored and facebook-github-bot committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    9d21496 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Update DevLoadingView to Support iPhone X

    Summary:
    The current implementation of DevLoadingView for iPhone currently gives a static height of `22` and does not take into account iPhoneX screen dimensions.
    
    Devices: All iPhone devices currently available with Xcode v9.2
    SDK: 8.1, 9, 10, 11
    
    Validate resize only occurs on iPhone X devices and others remain consistent.
    
    Before:
    ![feb-10-2018 12-30-20](https://user-images.githubusercontent.com/1743953/36065313-7b41f2ea-0e5e-11e8-87f2-928e26536077.gif)
    
    After:
    ![feb-10-2018 12-28-15](https://user-images.githubusercontent.com/1743953/36065317-848e4f7e-0e5e-11e8-8aab-70cb5db32f31.gif)
    
    [GENERAL][ENHANCEMENT][{React}] - Improvements to DevLoadingView for iPhone X
    Closes #17936
    
    Differential Revision: D6962962
    
    Pulled By: shergin
    
    fbshipit-source-id: e11d9386544fe19a9195e22a03e12f64e934cad7
    mrtnrst authored and facebook-github-bot committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    47b36d3 View commit details
    Browse the repository at this point in the history
  2. Reimagining of RCTShadowView layout API

    Summary:
    This is reimagining of interoperability layer between Yoga and ShadowViews (at least in Yoga -> RN part).
    Goals:
     * Make it clear and easy.
     * Make clear separation between "what layout what", now parent always layout children, noone layout itself.
     * Make possible to interleave Yoga layout with custom imperative layout (may be used in SafeAreaView, Text, Modal, InputAccessoryView and so on).
    
    Reviewed By: mmmulani
    
    Differential Revision: D6863654
    
    fbshipit-source-id: 5a6a933874f121d46f744aab99a31ae42ddd4a1b
    shergin authored and facebook-github-bot committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    f91f7d9 View commit details
    Browse the repository at this point in the history
  3. Broken publish step on CI

    Summary:
    Every `job` is run in a separate container and so, `checkout` step is required for the Git host to be added to `~/.ssh/known_hosts`. Without this step, it will timeout after 10 minutes waiting for you to add (yes) or reject (no) from known hosts (we get this prompt when we checkout from a host for the very first time).
    Closes #17956
    
    Differential Revision: D6968130
    
    Pulled By: hramos
    
    fbshipit-source-id: 6d62166fd375f8f408cf5f18b188f841d035d97f
    grabbou authored and facebook-github-bot committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    f7729a5 View commit details
    Browse the repository at this point in the history
  4. React sync for revisions 467b103...a634e53

    Reviewed By: flarnie
    
    Differential Revision: D6965585
    
    fbshipit-source-id: 48c20d0010f4daf83272a36b3bdaca94493ab8fa
    Brian Vaughn authored and facebook-github-bot committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    bedaaa1 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. Fix localization crash in DevSettingsActivity

    Differential Revision: D6970534
    
    fbshipit-source-id: da1df549b6157e5ec684cf4eed5f411740a73ed0
    ayc1 authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    427e464 View commit details
    Browse the repository at this point in the history
  2. Add UTFSequence module for common unicode usage

    Summary:
    A collection of Unicode sequences for various characters and emoji.
    
      - More explicit than using the sequences directly in code.
      - Source code should be limitted to ASCII.
      - Less chance of typos.
    
    Reviewed By: TheSavior
    
    Differential Revision: D6969065
    
    fbshipit-source-id: c11ec96b74f5dfa7c624a3c53f3c29f6284a82b3
    sahrens authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    54870e0 View commit details
    Browse the repository at this point in the history
  3. Add FDSStoryHeader

    Reviewed By: TheSavior
    
    Differential Revision: D6945233
    
    fbshipit-source-id: 9630a72e4a7c88ca282392c374ca88326f282713
    sahrens authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    4d0ee37 View commit details
    Browse the repository at this point in the history
  4. Fix duplicate var name declaration

    Reviewed By: rafeca
    
    Differential Revision: D6965150
    
    fbshipit-source-id: 332c8202f350e2014fedb9790f3d895222fb4f8d
    Peter van der Zee authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    6893a26 View commit details
    Browse the repository at this point in the history
  5. Uses a single code path to link and unlink all platforms

    Summary:
    This commit removes special cases for linking iOS and Android platforms.
    
    A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case.
    
    - Added jest tests related to the link command.
    - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes.
    
    #17745
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android.
    Closes #17961
    
    Differential Revision: D6975951
    
    Pulled By: hramos
    
    fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363
    rozele authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    1673c57 View commit details
    Browse the repository at this point in the history
  6. Bump metro@0.26.0

    Reviewed By: cpojer
    
    Differential Revision: D6976161
    
    fbshipit-source-id: 0cf20f4b2372997a8aac41cc07a9bdd641a93ad4
    rafeca authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    b1d8af4 View commit details
    Browse the repository at this point in the history
  7. Forward VM version to inspector

    Reviewed By: bnham
    
    Differential Revision: D6938018
    
    fbshipit-source-id: c79853ddf835acab86a16ebd539874d29d3aa60a
    pakoito authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    ad2d9e7 View commit details
    Browse the repository at this point in the history
  8. Add disabled tests to CircleCI config

    Summary:
    These tests have not run for one reason or another since the migration from Travis. They are not passing, and are commented out to avoid flagging new PRs as breaking. These tests need to be fixed and re-enabled ASAP.
    Closes #17959
    
    Differential Revision: D6976781
    
    Pulled By: hramos
    
    fbshipit-source-id: 712a09877d0597c12cafa741779b471680b7d2db
    hramos authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    cc6d093 View commit details
    Browse the repository at this point in the history
  9. ✨ Colorize filenames with conflicts when upgrading

    Summary:
    Visually show files merged with conflicts when running `react-native-git-upgrade`.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    After running `react-native-git-upgrade`, files with conflicts are not immediately recognised visually. With this patch, files with conflicts are highlighted in red.
    
    ![image](https://user-images.githubusercontent.com/771989/36086385-fc183baa-1006-11e8-8862-0867b82b7ec1.png)
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [CLI] [ENHANCEMENT] [react-native-git-upgrade/cliEntry.js] - Print files with conflicts in red.
    Closes #17947
    
    Differential Revision: D6977042
    
    Pulled By: hramos
    
    fbshipit-source-id: 3c67561ea3acbee227a7a0cf42857af4fb75c75c
    alvinthen authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    e53a8f7 View commit details
    Browse the repository at this point in the history
  10. RNTester http_server send cookie fix

    Summary:
    Signed-off-by: Evan J Brunner <ej3@appitto.me>
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Motivation can be found in #17899
    
    This `RNTester/js/http_test_server.js` is part of a internal websocket test suite / devtool.
    
    Can be tested with `curl -D - localhost:5556` observing that the `Set-Cookie: wstest=OK; Path=\` header is present, and the service throws no exceptions.. etc
    
    [INTERNAL][MINOR][./RNTester/js/http_test_server.js] - fixed set cookie with connect framework
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17900
    
    Differential Revision: D6977087
    
    Pulled By: hramos
    
    fbshipit-source-id: af6205343fccf69c57e0c26a85a5b04d61288a23
    ej3 authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    03e6d3e View commit details
    Browse the repository at this point in the history
  11. Extend Navigation to support "is_fabric" param from native

    Reviewed By: fkgozali
    
    Differential Revision: D6955828
    
    fbshipit-source-id: 1a77b652a7e372acf961a0b0772ae93a999b90b1
    mdvacca authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    331cc79 View commit details
    Browse the repository at this point in the history
  12. Fix: incorrect line-height calculation

    Summary:
    There seems to be a rounding error in the android code for line height, so that for some fonts and at some combinations of line height and font size the actual height of the elements seems to be slightly too short.
    
    I've identified one issue that I mentioned here #10712 (comment) that could at least explain some of the problem. That when the line-height minus the original sum of the absolute value of top  and bottom from the metrics, happens to be an odd number, the division by two causes a rounding error of 1, so that the actual line height is 1pt less than it should.
    
    The fix uses floating point division instead of integer division, and rounds (arbitrarily) the negative values up and the positive values down so that the total is still the correct for odd numbers.
    
    It turns out that only ascent and descent is used to give the actual line-height between lines in the same text-element. The top and bottom values are only used for padding the top and bottom of the text. So when the line-height is greater than the font size and the extra padding this PR sets the ascent and descent to the same value as the top and bottom respectively.
    
    I've renamed the shouldIncreaseAllMetricsProportionally test to evenLineHeightShouldIncreaseAllMetricsProportionally and added an extra assertion to check that bottom-top still equals the line height.
    
    Added another test oddLineHeightShouldAlsoWork that is similar but uses an odd number for the line height to test that it still works with odd numbers. This test only uses the sum of the values so that it's indifferent to what value the implementation chooses to round up or down.
    
    Improvement on #16448
    
    Fix line-height calculation on Android.
    
    | Before        | After           |
    | ------------- |-------------|
    | ![without fix](https://user-images.githubusercontent.com/2144849/36150230-4404a0cc-10c3-11e8-8880-4ab84339c741.png)      | ![actual fix](https://user-images.githubusercontent.com/2144849/36156620-eb496d0e-10d7-11e8-8bd1-1cb536a38fbf.png) |
    
    (All three columns have font size 16 and lineHeight: 32. The first one is has fixed height 9*32, the second is 9 Text elements, the last is one text element with lots of text limited to 9 lines, so they should be the same height. )
    Closes #17952
    
    Differential Revision: D6980333
    
    Pulled By: hramos
    
    fbshipit-source-id: 0a501358cfbf7f139fca46056d0d972b1daf6ae3
    strindhaug authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    74e54cb View commit details
    Browse the repository at this point in the history
  13. Freeze UTFSequence

    Summary:
    Don't want anyone accidentally mutating it.
    
    Also make deepFreezeAndThrowOnMutationInDev easier to use with nice flow typing.
    
    Reviewed By: yungsters
    
    Differential Revision: D6974089
    
    fbshipit-source-id: 0f90e7939cb726893fa353a4f2a6bbba701205bc
    sahrens authored and facebook-github-bot committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    d220118 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Bundle download progress on Android

    Summary:
    Android equivalent of #15066
    
    Tested that download progress shows up properly when reloading the app.
    
    [ANDROID] [FEATURE] [DevSupport] - Show bundle download progress on Android
    Closes #17809
    
    Differential Revision: D6982823
    
    Pulled By: hramos
    
    fbshipit-source-id: da01e42b8ebb1c603f4407f6bafd68e0b6b3ecba
    janicduplessis authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    d06e143 View commit details
    Browse the repository at this point in the history
  2. add BULLET and BULLET_SP

    Reviewed By: TheSavior
    
    Differential Revision: D6983446
    
    fbshipit-source-id: c8ce4b1c7836654910db84c9cd4b6d0bcec8ae27
    sahrens authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    4761d5a View commit details
    Browse the repository at this point in the history
  3. allow installing extra JS binding via the bridge

    Reviewed By: mdvacca
    
    Differential Revision: D6957397
    
    fbshipit-source-id: 172905861fbb1c9ed45149e33b406c28ad616cd7
    fkgozali authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    e165d0d View commit details
    Browse the repository at this point in the history
  4. Add JS binding for FabricUIManager - iOS

    Reviewed By: sebmarkbage
    
    Differential Revision: D6934518
    
    fbshipit-source-id: 1f626f79a74fb199925644e8b16238aa17d40e1f
    fkgozali authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    1aeb925 View commit details
    Browse the repository at this point in the history
  5. iOS: allow getting an instance of a js-bound module via the bridge

    Reviewed By: sebmarkbage
    
    Differential Revision: D6982785
    
    fbshipit-source-id: 7bbcc5416e1d1a3a577328349a7c18af5c0f8577
    fkgozali authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    5f48bd8 View commit details
    Browse the repository at this point in the history
  6. Fixed a bug with positioning of nested views inside <Text>

    Summary:
    Fixing of recent regression in layout system.
    Conseptually, a superview should define frames of child views.
    
    Reviewed By: mmmulani
    
    Differential Revision: D6980128
    
    fbshipit-source-id: e267e966fd46af28db1d3d40939110040b74e33f
    shergin authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    7d20de4 View commit details
    Browse the repository at this point in the history
  7. Verify that the component passed to createAnimatedComponent is not fu…

    …nctional
    
    Summary:
    Stateless functional components don't support refs and we need that for the component to work, it used to crash with this error message: `undefined is not an object (evaluating 'this._component.getScrollableNode')`. This makes it clear what the issue is.
    
    Fixes some of the errors in #10635, not sure if it fixes all the cases described in the issue though.
    
    **Test plan**
    Tested that passing a component with createClass or extends Component works but passing a function causes an error.
    
    [GENERAL] [ENHANCEMENT] [Animated] - Verify that the component passed to createAnimatedComponent is not functional
    Closes #15019
    
    Differential Revision: D6988096
    
    Pulled By: sahrens
    
    fbshipit-source-id: ec0ffa763245e786f44b4a1d56c0738876c25782
    janicduplessis authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    10b642a View commit details
    Browse the repository at this point in the history
  8. Pass port when running on device (fix #17973)

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Building for iOS device `react-native run-ios --device [id]` fails since port is not passed. This is a blocker for us and prevents us from updating to latest React Native stable.
    
    I've tested this in our app and also in fresh app using RN master and verified that it works.
    
    None.
    
    [CLI] [BUGFIX] [local-cli/runIOS/runIOS.js] - Pass metro port when running on device
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17983
    
    Differential Revision: D6988299
    
    Pulled By: hramos
    
    fbshipit-source-id: 5169706600f87f13b9c9c105eb7d6db7a40194f1
    jozan authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    f8fee0a View commit details
    Browse the repository at this point in the history
  9. Fix enableBabelRCLookup option in new CLI + global cache script

    Reviewed By: BYK
    
    Differential Revision: D6977885
    
    fbshipit-source-id: 50245e046c7639f9fb4022a9cc5974d50831524c
    rafeca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    96ec2dc View commit details
    Browse the repository at this point in the history
  10. Pass cacheVersion param via the new API

    Reviewed By: BYK
    
    Differential Revision: D6980337
    
    fbshipit-source-id: 72c01136b6720390ffec8593f0375c8756dc1d4a
    rafeca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    828cd78 View commit details
    Browse the repository at this point in the history
  11. Support resumes without overriding the back handler

    Differential Revision: D6982515
    
    fbshipit-source-id: 5483f6c677c6653e51f6311386f31f5be6ed0e00
    ayc1 authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    c281f7a View commit details
    Browse the repository at this point in the history
  12. Expose methods of persistent yoga for Java

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D6918605
    
    fbshipit-source-id: e424c78680c04e21154ebe21405671c4e90f6529
    mdvacca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    ecc08ad View commit details
    Browse the repository at this point in the history
  13. Allow installing JS binding via the RN Android bridge

    Reviewed By: fkgozali
    
    Differential Revision: D6979072
    
    fbshipit-source-id: 8b4ac3769496a6a6fe3dd9ee2aac64b66604c413
    mdvacca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    db391a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Make Java YogaNode cloneable

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D6935971
    
    fbshipit-source-id: a2008f1eb849b5074585b48699b7de56d5ac90d4
    mdvacca authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    51def5e View commit details
    Browse the repository at this point in the history
  2. Upgrade Jest to 22.3.0

    Reviewed By: BYK
    
    Differential Revision: D6978514
    
    fbshipit-source-id: 3c6be52d38fedbe849dee6319bb2e4d7a97297c9
    Miguel Jimenez Esun authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    991b7ab View commit details
    Browse the repository at this point in the history
  3. Extract polyfillGlobal from InitializeCore

    Reviewed By: jeanlauliac
    
    Differential Revision: D6987657
    
    fbshipit-source-id: 8762732de671418520376a98bdd724bbb24e4e36
    fromcelticpark authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f7f5dc6 View commit details
    Browse the repository at this point in the history
  4. Fix main size calculation from the aspect ratio

    Summary:
    When the following conditions are met, the main size become smaller by the margins in the main axis.
    * The aspect ratio is defined
    * The main size is not defined
    * The cross size is defined
    * The main margin is defined
    
    This is because the main margin size is not included when calculating the main size from the aspect ratio.
    Closes facebook/yoga#715
    
    Reviewed By: emilsjolander
    
    Differential Revision: D6998988
    
    Pulled By: priteshrnandgaonkar
    
    fbshipit-source-id: f6f69c47ece17bd7c5e41517b96032bf0c149356
    Yuichi ONO authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f751c34 View commit details
    Browse the repository at this point in the history
  5. Fold .eslintrc's into the root eslintrc

    Reviewed By: TheSavior
    
    Differential Revision: D6997050
    
    fbshipit-source-id: 81e45d24343cca8336adb0de43bd766899ff03b6
    zertosh authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    59401f8 View commit details
    Browse the repository at this point in the history
  6. Create JNI wrapper for Fabric

    Reviewed By: fkgozali
    
    Differential Revision: D6989838
    
    fbshipit-source-id: f092901cacc0c3eb89b08c6ac0384c4d5f6e6cfe
    mdvacca authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c82b9f7 View commit details
    Browse the repository at this point in the history
  7. Extend installFabric method to access UIFabricModule from C++

    Reviewed By: sebmarkbage
    
    Differential Revision: D7001974
    
    fbshipit-source-id: a49c6e634ac710805fb37a50a61c2cf2e248b8a7
    mdvacca authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ad4f54f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Demo illustrated base-line metric exposure

    Summary:
    A demo illustrated `base-line` metric exposure to layout system was added to RNTester.
    And currently it shows that we don't support it at all.
    
    https://cl.ly/1F0B0D430U3e
    
    Reviewed By: sahrens
    
    Differential Revision: D6957056
    
    fbshipit-source-id: 28776300fc8e11950ac5ba1a5416f68d31d4e9fb
    shergin authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    7630a61 View commit details
    Browse the repository at this point in the history
  2. base-line metric exposure for <Text>

    Summary:
    Now <Text> exposes base-line metric to Yoga.
    
    Before:
    https://cl.ly/1F0B0D430U3e
    
    After:
    https://cl.ly/0G1Q29450O0y
    
    Reviewed By: yungsters
    
    Differential Revision: D6957055
    
    fbshipit-source-id: 04c1df693915e294b54e3c33e0aea21611dcc232
    shergin authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    51b3529 View commit details
    Browse the repository at this point in the history
  3. base-line metric exposure for <TextInput>

    Summary:
    Now <TextInput> (both bersions) exposes base-line metric to Yoga.
    Before:
    https://cl.ly/0G1Q29450O0y
    After:
    https://cl.ly/2X103V3O0322
    
    Reviewed By: yungsters
    
    Differential Revision: D6957054
    
    fbshipit-source-id: d76d96f56720d710a4230c53beafdb0b2521e8a9
    shergin authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    0dbe183 View commit details
    Browse the repository at this point in the history
  4. Use only native robolectric_test rules.

    Reviewed By: adamjernst
    
    Differential Revision: D6997829
    
    fbshipit-source-id: 5f8d41a6126f02c9fb9d0fb90d89df28eeea9653
    ttsugriy authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    574c70e View commit details
    Browse the repository at this point in the history
  5. Support for animated tracking in native driver

    Summary:
    This PR adds support for Animated tracking to Animated Native Driver implementation on Android and iOS.
    
    Animated tracking allows for animation to be started with a "dynamic" end value. Instead of passing a fixed number as end value we can pass a reference to another Animated.Value. Then when that value changes, the animation will be reconfigured to drive the animation to the new destination point. What is important is that animation will keep its state in the process of updating "toValue". That is if it is a spring animation and the end value changes while the previous animation still hasn't settled the new animation will start from the current position and will inherit current velocity. This makes end value transitions very smooth.
    
    Animated tracking is available in JS implementation of Animated library but not in the native implementation. Therefore until now, it wasn't possible to utilize native driver when using animated tracking. Offloading animation from JS thread turns out to be crucial for gesture driven animations. This PR is a step forward towards feature parity between JS and native implementations of Animated.
    
    Here is a link to example video that shows how tracking can be used to implement chat heads effect: https://twitter.com/kzzzf/status/958362032650244101
    
    In addition this PR fixes an issue with frames animation driver on Android that because of rounding issues was taking one extra frame to start. Because of that change I had to update a number of Android unit tests that were relying on that behavior and running that one additional animation step prior to performing checks.
    
    As a part of this PR I'm adding three unit tests for each of the platforms that verifies most important aspects of this implementation. Please refer to the code and look at the test cases top level comments to learn what they do.
    
    I'm also adding a section to "Native Animated Example" screen in RNTester app that provides a test case for tracking. In the example we have blue square that fallows the red line drawn on screen. Line uses Animated.Value for it's position while square is connected via tracking spring animation to that value. So it is ought to follow the line. When user taps in the area surrounding the button new position for the red line is selected at random and the value updates. Then we can watch blue screen animate to that position.
    
    You can also refer to this video that I use to demonstrate how tracking can be linked with native gesture events using react-native-gesture-handler lib: https://twitter.com/kzzzf/status/958362032650244101
    
    [GENERAL][FEATURE][Native Animated] - Added support for animated tracking to native driver. Now you can use `useNativeDriver` flag with animations that track other Animated.Values
    Closes #17896
    
    Differential Revision: D6974170
    
    Pulled By: hramos
    
    fbshipit-source-id: 50e918b36ee10f80c1deb866c955661d4cc2619b
    kmagiera authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b48f7e5 View commit details
    Browse the repository at this point in the history
  6. Dirty text shadow nodes on UIManager queue after multiplier changes

    Summary: Letting them fire on whatever queue we get the notification from throws an assert.
    
    Reviewed By: shergin
    
    Differential Revision: D7002789
    
    fbshipit-source-id: 669474af1a07f0df6784b69b54afe0152c1ba3c4
    Mehdi Mulani authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    cff522d View commit details
    Browse the repository at this point in the history
  7. Disable font scaling when an explicit font handler is set

    Reviewed By: sahrens
    
    Differential Revision: D7003464
    
    fbshipit-source-id: f36ff344c50a9c63af6c852138041c1c918259c8
    Mehdi Mulani authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    f96dfb9 View commit details
    Browse the repository at this point in the history
  8. Extend the FabricUIManagerModule class to integrate with JSI/JSC in A…

    …ndroid
    
    Reviewed By: sebmarkbage
    
    Differential Revision: D7005419
    
    fbshipit-source-id: 6e65be5a922ddb29fde965f5df779cc92a996ecf
    mdvacca authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    1f7a48f View commit details
    Browse the repository at this point in the history
  9. Bump buck to v2018.02.16.01

    Summary:
    This should fix our current Android test failures.
    Closes #18002
    
    Differential Revision: D7014218
    
    Pulled By: hramos
    
    fbshipit-source-id: 2933baf9fd05f3ad33306c3ca7b62da8af568db0
    hramos authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    617362b View commit details
    Browse the repository at this point in the history
  10. Exclude jsbundle files from VCS

    Summary:
    jsbundle files can be generated, and are quite large and therefore, I think should be excluded from being committed to the repo.
    
    [ GENERAL ][ MINOR ][local-cli/templates/_gitignore] - Included a new entry to ignore jsbundle files
    Closes #17888
    
    Differential Revision: D6977064
    
    Pulled By: hramos
    
    fbshipit-source-id: 9c7803004f3f4ec59cba3017213f68fba8225dbf
    aneophyte authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    2123108 View commit details
    Browse the repository at this point in the history
  11. tvOS: TV nav event emitter should check for bridge

    Summary:
    When running with the packager in the tvOS simulator, reloading from the packager hits an assert in `RCTEventEmitter`, causing a crash.  The solution is for `RCTTVNavigationEventEmitter` to check for the existence of the bridge before attempting to send an event.
    
    Manual testing.
    
    [IOS] [BUGFIX] [RCTTVNavigationEventEmitter.m] - Fix crash when reloading in tvOS
    Closes #17797
    
    Differential Revision: D7014975
    
    Pulled By: hramos
    
    fbshipit-source-id: 0bf766e87267ca8592ff0cc0b3cb4621a8e8f9b5
    douglowder authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    3a3d884 View commit details
    Browse the repository at this point in the history
  12. Change irrelevant Products path in ./local-cli/runIOS/runIOS.js

    Summary:
    #7308
    and many of the same
    
    Seems like xcode cli tool isn't create ./build directory any more but place Products
    right inside ./Build (may check while creating single view ios application
    in XCode)
    
    * edit hardcoded path to {appName}.app
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Command `$ react-native run-ios` is often lead to `Entry, ":CFBundleIdentifier", Does Not Exist`
    I find out how to fix it in current version of RN and Xcode cli tools
    
    Just try to do `$ react native init {appName}` and then `$ react native run-ios` if everything fine it means my approach is right :)
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17963
    
    Differential Revision: D7014984
    
    Pulled By: hramos
    
    fbshipit-source-id: da62f130e6ebf7d3acd09d36525838d5c9684e75
    blackneck authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    5447ca6 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. Better Android Gradle Plugin 3.x integration

    Summary:
    Better integration with the Android Gradle-based build process, especially the changes introduced by the [Android Gradle Plugin 3.x and AAPT2](https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html).
    
    Fixes #16906, the `android.enableAapt2=false` workaround is no longer required.
    
    Bases the task generation process on the actual application variants present in the project. The current manual process of iterating build types and product flavors could break down when more than one dimension type is present (see https://developer.android.com/studio/build/build-variants.html#flavor-dimensions).
    
    This also exposes a very basic set of properties in the build tasks, so that other tasks can more reliably access them:
    
    ```groovy
    android.applicationVariants.all { variant ->
        // This is the generated task itself:
        def reactBundleTask = variant.bundleJsAndAssets
        // These are the outputs by type:
        def resFileCollection = reactBundleTask.generatedResFolders
        def assetsFileCollection = reactBundleTask.generatedAssetsFolders
    }
    ```
    
    I've tested various combinations of product flavors and build types ([Build Variants](https://developer.android.com/studio/build/build-variants.html)) to make sure this is consistent. This is a port of what we're currently deploying to our CI process.
    
    [ ANDROID ] [ BUGFIX ] [ react.gradle ] - Support Android Gradle Plugin 3.x and AAPT2
    [ ANDROID ] [ FEATURE ] [ react.gradle ] - Expose the bundling task and its outputs via ext properties
    Closes #17967
    
    Differential Revision: D7017148
    
    Pulled By: hramos
    
    fbshipit-source-id: e52b3365e5807430b9caced51349abf72332a587
    CFKevinRef authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    d16ff3b View commit details
    Browse the repository at this point in the history
  2. Fix pinch crash in touch-responsive views.

    Summary:
    Fork and rebase of gillessed's PR #13166 which has gotten stale.
    
    From original PR:
    
    Motivation (required)
    
    Multiple react native developer (including myself) have run into a crash with the react-native-photo-view library (and possibly others). The common solution to this problem lies in the underlying java code, and thus requires a change in the react native source.
    
    The stack trace I am getting is the same as listed here alwx/react-native-photo-view#15.
    
    There was a PR to fix this (#12085) but it was closed. In response to the comments there, in my PR, I do log the exceptions. I don't think we can get any closer to the exception because in the next level of the stack trace, we are in the android sdk code.
    
    Looking at some stack overflow pages and the android bug tracker, it seems that this is the common solution to this bug, and does not cause any impact any functionality.
    
    https://code.google.com/p/android/issues/list?can=1&q=pointerindex+out+of+range&colspec=ID+Status+Priority+Owner+Summary+Stars+Reporter+Opened&cells=tiles
    
    Test Plan (required)
    
    I have manually tested this by compiling react native android from source and have confirmed the exception still gets hit and logged, but does not cause the app to terminate.
    Closes #17167
    
    Differential Revision: D7014296
    
    Pulled By: hramos
    
    fbshipit-source-id: 06b4a31062a591b726d2021e877d16f49881dcfd
    tobycox authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    67c3ad4 View commit details
    Browse the repository at this point in the history
  3. Update license headers for MIT license

    Summary:
    Includes React Native and its dependencies Fresco, Metro, and Yoga. Excludes samples/examples/docs.
    
    find: ^(?:( *)|( *(?:[\*~#]|::))( )? *)?Copyright (?:\(c\) )?(\d{4})\b.+Facebook[\s\S]+?BSD[\s\S]+?(?:this source tree|the same directory)\.$
    replace: $1$2$3Copyright (c) $4-present, Facebook, Inc.\n$2\n$1$2$3This source code is licensed under the MIT license found in the\n$1$2$3LICENSE file in the root directory of this source tree.
    
    Reviewed By: TheSavior, yungsters
    
    Differential Revision: D7007050
    
    fbshipit-source-id: 37dd6bf0ffec0923bfc99c260bb330683f35553e
    sophiebits authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    1490ab1 View commit details
    Browse the repository at this point in the history
  4. Update to MIT license

    Summary: Manual changes.
    
    Reviewed By: TheSavior, yungsters
    
    Differential Revision: D7012152
    
    fbshipit-source-id: de7459be3db13c687868b45059856f125c4f2eb1
    sophiebits authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    26684cf View commit details
    Browse the repository at this point in the history
  5. @allow-large-files Upgrade xplat/js to Flow v0.66

    Reviewed By: gabelevi
    
    Differential Revision: D7016717
    
    fbshipit-source-id: 2bd2fd67074ba5d405ecd63a1aeb37354f8634c9
    Caleb Meredith authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    da3424c View commit details
    Browse the repository at this point in the history
  6. Fix #17610, Add fixtures to metro blacklist

    Summary:
    Include a default blacklist into the build settings to prevent
    processing of incorrect fixture files by Metro.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Fix #17610 issue, preventing metro from processing fixture files
    
    1. Have a working demo
    2. Install https://github.com/oblador/react-native-vector-icons
    3. Use in a component
    4. Start the app
    5. The app starts successfully and display the icons
    
    [ GENERAL  ]  [ BUGFIX ]  [local-cli/util/Config.js] - Add default file blacklist
    Closes #17672
    
    Differential Revision: D7014627
    
    Pulled By: hramos
    
    fbshipit-source-id: 20974e6fdd0977eeeb1048c29c9d621c803c26e9
    t4deu authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    54dc11a View commit details
    Browse the repository at this point in the history