Typos in code #17587
Closed
Typos in code #17587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onAccordingLayoutDirection (tranform -> transform)
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
CLA Signed
janicduplessis
suggested changes
Jan 20, 2018
ReactCommon/yoga/yoga/YGNode.cpp
Outdated
| @@ -553,12 +553,12 @@ void YGNode::cloneChildrenIfNeeded() { | |||
| } | |||
| } | |||
|
|
|||
| void YGNode::markDirtyAndPropogate() { | |||
| void YGNode::markDirtyAndPropagate() { | |||
There was a problem hiding this comment.
The changes in the yoga folder need to be made to https://github.com/facebook/yoga then they are synced here.
There was a problem hiding this comment.
@jacobrosenthal in my prev PR it was done automatically #17578
There was a problem hiding this comment.
also Yoga has been changed, why not do the same in this PR?
There was a problem hiding this comment.
If the changes were applied to the yoga repo they’ll eventually make their way to RN sometime.
|
@ss18 Could you please resolve conflicts? |
hramos
added
GH Review: needs-revision
and removed
CLA Signed
* master: (91 commits) Fix Xcode Archive task failing if project path contains whitespace Implement Blob support for XMLHttpRequest RN: Add Missing Start/End Style Types Fixed a bug when <Text> does not redraw native view on relayout Give IInspector a virtual destructor for correct InspectorImpl destruction Fix NPE in Android Switch during measure Removed use of xip.io, as it's not needed. Proper attributed strings comparsion in RCTBaseTextInputView Bump metro@0.24.7 Continue wrapping functions as we prepare for skylark `babel-preset-react-native`: only require plugins once Remove references to Travis @allow-large-files flow 0.64 release The New <Text> on iOS Backed out changeset 409acf8d3356 Fix permissions on test script Popups calling error callback instead of crashing if view with passed tagId not found Check for nullptr when accessing isInspectable method Fix open source build load error Made logging logic dynamic to log string length ... # Conflicts: # React/Base/Surface/RCTSurface.mm
|
@shergin done. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 29, 2018
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ss18 I am sorry, could you please remove all Yoga changes from the PR. Apparently, it's public API and it's impossible to land without massive codemod across internal FB codebase. I will address it separately later. |
|
@shergin done! |
facebook-github-bot
approved these changes
Jan 30, 2018
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Jan 30, 2018
Summary: To fix typos No testing required, changed only internal things names No addtionalStyles -> additionalStyles occured -> occurred recomendedType -> recommendedType markDirtyAndPropogate -> markDirtyAndPropagate targetting -> targeting RCTApplyTranformationAccordingLayoutDirection -> RCTApplyTransformationAccordingLayoutDirection (tranform -> transform) Closes facebook/react-native#17587 Differential Revision: D6832696 Pulled By: shergin fbshipit-source-id: 452287e5ce82df5c6b87126cb21889b7bd9d73c1
Plo4ox
pushed a commit
to Plo4ox/react-native
that referenced
this pull request
Feb 17, 2018
Summary: To fix typos No testing required, changed only internal things names No addtionalStyles -> additionalStyles occured -> occurred recomendedType -> recommendedType markDirtyAndPropogate -> markDirtyAndPropagate targetting -> targeting RCTApplyTranformationAccordingLayoutDirection -> RCTApplyTransformationAccordingLayoutDirection (tranform -> transform) Closes facebook#17587 Differential Revision: D6832696 Pulled By: shergin fbshipit-source-id: 452287e5ce82df5c6b87126cb21889b7bd9d73c1
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Mar 1, 2018
Summary: To fix typos No testing required, changed only internal things names No addtionalStyles -> additionalStyles occured -> occurred recomendedType -> recommendedType markDirtyAndPropogate -> markDirtyAndPropagate targetting -> targeting RCTApplyTranformationAccordingLayoutDirection -> RCTApplyTransformationAccordingLayoutDirection (tranform -> transform) Closes facebook/react-native#17587 Differential Revision: D6832696 Pulled By: shergin fbshipit-source-id: 452287e5ce82df5c6b87126cb21889b7bd9d73c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix typos
Test Plan
No testing required, changed only internal things names
Related PRs
No
Release Notes
addtionalStyles -> additionalStyles
occured -> occurred
recomendedType -> recommendedType
markDirtyAndPropogate -> markDirtyAndPropagate
targetting -> targeting
RCTApplyTranformationAccordingLayoutDirection -> RCTApplyTransformationAccordingLayoutDirection (tranform -> transform)