Remove redundant config in AndroidManifest.xml #17596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove redundant version code, name, miniSdk, targetSdk, they now are configed in build.gradle * allowbackup = true is not a secure config
facebook-github-bot
added
CLA Signed
|
@facebook-github-bot label Android Generated by 🚫 dangerJS |
janicduplessis
suggested changes
Jan 20, 2018
| <application | ||
| android:name=".MainApplication" | ||
| android:allowBackup="true" |
There was a problem hiding this comment.
According to https://stackoverflow.com/questions/12648373/what-is-androidallowbackup this will cause a lint warning if not set. I think we could just set it to false by default.
There was a problem hiding this comment.
@janicduplessis fixed.
There was a problem hiding this comment.
Wouldn't it be beneficial to most app users to have automatic backups? Developers who aren't android savvy will not know to change this setting; and malicious user's can root their phone and get the data regardless. At the very least, there should be RN documentation about it.
https://developer.android.com/guide/topics/data/autobackup.html#EnablingAutoBackup
|
Thanks! @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 20, 2018
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
janicduplessis
approved these changes
Jan 20, 2018
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: * remove redundant version code, name, miniSdk, targetSdk, they now are configed in build.gradle * allowbackup = true is not a secure config <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Clean up redundant config and remove security risk config. test android template still works. none <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Closes facebook/react-native#17596 Differential Revision: D6768292 Pulled By: hramos fbshipit-source-id: 9f32f17aebb9c1857d8b64d6687efe7c22e7bc79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clean up redundant config and remove security risk config.
Test Plan
test android template still works.
Related PRs
none
Release Notes