Test and document Image resizeMode=center on iOS #17759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the existing comment for Android.
facebook-github-bot
added
CLA Signed
This was referenced Jan 27, 2018
|
Thanks! 👍 @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 27, 2018
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Should we fix a screenshot test now? |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Mar 1, 2018
Summary: `<Image resizeMode="center">` already works on iOS (implemented in #8792), but is neither tested nor documented the way the other `resizeMode` values are. This PR primarily enables the relevant RNTester case on iOS, and secondarily copies over the doc comment from `Image.android.js` to `Image.ios.js`. A PR to `react-native-website` will follow shortly and it is there I will try and revise the wording a bit. Updated RNTester screenshot (iOS): <img src=https://user-images.githubusercontent.com/2246565/35470720-44b38282-0357-11e8-941c-1b3c5a1b2f3b.png width=300> react-native-website PR coming soon. [IOS] [MINOR] [Image] - Include resizeMode=center in RNTester Closes facebook/react-native#17759 Differential Revision: D6829051 Pulled By: hramos fbshipit-source-id: c6e0000a75765e8bf3a1d0306aaafad002b14a58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
<Image resizeMode="center">already works on iOS (implemented in #8792), but is neither tested nor documented the way the otherresizeModevalues are.This PR primarily enables the relevant RNTester case on iOS, and secondarily copies over the doc comment from
Image.android.jstoImage.ios.js. A PR toreact-native-websitewill follow shortly and it is there I will try and revise the wording a bit.Test Plan
Updated RNTester screenshot (iOS):
Related PRs
react-native-website PR coming soon.
Release Notes
[IOS] [MINOR] [Image] - Include resizeMode=center in RNTester