Issue: java.lang.IllegalArgumentException: pointerIndex out of range #12085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2017 14:08
…receive a pointerIndex error
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
mkonicek
reviewed
Jan 30, 2017
| return true; | ||
| } | ||
| } catch (Exception e) { | ||
| // Swallow error |
There was a problem hiding this comment.
We should handle the error close to the place where it occurs - either prevent it from happening or log it. Never swallow exceptions.
Please use 2 spaces for indentation.
|
I'll close this for now but please feel free to open a new PR that fixes the root cause or handles the error at the exact line where it's happening and logs it. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2018
Summary: Fork and rebase of gillessed's PR #13166 which has gotten stale. From original PR: Motivation (required) Multiple react native developer (including myself) have run into a crash with the react-native-photo-view library (and possibly others). The common solution to this problem lies in the underlying java code, and thus requires a change in the react native source. The stack trace I am getting is the same as listed here alwx/react-native-photo-view#15. There was a PR to fix this (#12085) but it was closed. In response to the comments there, in my PR, I do log the exceptions. I don't think we can get any closer to the exception because in the next level of the stack trace, we are in the android sdk code. Looking at some stack overflow pages and the android bug tracker, it seems that this is the common solution to this bug, and does not cause any impact any functionality. https://code.google.com/p/android/issues/list?can=1&q=pointerindex+out+of+range&colspec=ID+Status+Priority+Owner+Summary+Stars+Reporter+Opened&cells=tiles Test Plan (required) I have manually tested this by compiling react native android from source and have confirmed the exception still gets hit and logged, but does not cause the app to terminate. Closes #17167 Differential Revision: D7014296 Pulled By: hramos fbshipit-source-id: 06b4a31062a591b726d2021e877d16f49881dcfd
Plo4ox
pushed a commit
to Plo4ox/react-native
that referenced
this pull request
Feb 17, 2018
Summary: Fork and rebase of gillessed's PR facebook#13166 which has gotten stale. From original PR: Motivation (required) Multiple react native developer (including myself) have run into a crash with the react-native-photo-view library (and possibly others). The common solution to this problem lies in the underlying java code, and thus requires a change in the react native source. The stack trace I am getting is the same as listed here alwx/react-native-photo-view#15. There was a PR to fix this (facebook#12085) but it was closed. In response to the comments there, in my PR, I do log the exceptions. I don't think we can get any closer to the exception because in the next level of the stack trace, we are in the android sdk code. Looking at some stack overflow pages and the android bug tracker, it seems that this is the common solution to this bug, and does not cause any impact any functionality. https://code.google.com/p/android/issues/list?can=1&q=pointerindex+out+of+range&colspec=ID+Status+Priority+Owner+Summary+Stars+Reporter+Opened&cells=tiles Test Plan (required) I have manually tested this by compiling react native android from source and have confirmed the exception still gets hit and logged, but does not cause the app to terminate. Closes facebook#17167 Differential Revision: D7014296 Pulled By: hramos fbshipit-source-id: 06b4a31062a591b726d2021e877d16f49881dcfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
Explain the motivation for making this change. What existing problem does the pull request solve?
Currently when implementing a Carousel in React Native ScrollView when you add pinch-to-zoom or some other type of touch handler, functionality the onTouchEvent can crash sometimes on Android.
see:
alwx/react-native-photo-view#15
alwx/react-native-photo-view#22
https://code.google.com/p/android/issues/detail?id=18990
Baseflow/PhotoView#293
Baseflow/PhotoView#81