Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to loose cookies2 #4251

Closed
wants to merge 38 commits into from
Closed

Add types to loose cookies2 #4251

wants to merge 38 commits into from

Conversation

AtomsForPeace
Copy link
Contributor

@AtomsForPeace AtomsForPeace commented Oct 21, 2019 •
edited
Loading

What do these changes do?

Add tests as requested for types that update cookies accept. Adds two more accepted types to LooseCookies.

Are there changes in behavior for the user?

Nope.

Related issue number

#4205

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

asvetlov and others added 30 commits October 10, 2019 02:40
@asvetlov
[3.6] Fix spelling (#4164) (#4167)
72b9b58 
(cherry picked from commit ca0d11a)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov
[3.6] Apply towncrier to check changelog correctness (#4165) (#4170)
e101187 
(cherry picked from commit 9c77d18)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov @svenfuchs
[3.6] Use version: ~> 1.0, remove conditions: v1 (#4162) (#4166)
21208f9 
The version requirement `= 0` advertised in early development stages was an unfortunate choice, as this is going to be the opt-out once the new build config validation feature will be rolled out further. Please use `~> 1.0` instead.

The conditions version `v1` is now the default, so this key can be removed.
(cherry picked from commit f104e75)

Co-authored-by: Sven Fuchs <me@svenfuchs.com>
@asvetlov
[3.6] Run Azure CI on backport branch also (#4172) (#4173)
b8abc6f 
(cherry picked from commit 0a9c4ba)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov
[3.6] Don't use docstring in tests. (#4163) (#4168)
9cee65f 
1. Test code is not a part of public API
2. Test runners displays test docstring instead of test function if present,
   it complicates the code navigation, e.g. opening a failed test in editor etc..
(cherry picked from commit 1864880)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov
[3.6] Enable windows CI (#4176). (#4183)
d0eabc2 
(cherry picked from commit bbaf125)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov
Fix typo
50b0fce
@dependabot-preview @asvetlov
[3.6] Bump attrs from 19.2.0 to 19.3.0 (#4187)
c020893 
Bumps [attrs](https://github.com/python-attrs/attrs) from 19.2.0 to 19.3.0.
- [Release notes](https://github.com/python-attrs/attrs/releases)
- [Changelog](https://github.com/python-attrs/attrs/blob/master/CHANGELOG.rst)
- [Commits](python-attrs/attrs@19.2.0...19.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@asvetlov @codepr
[3.6] Update docs/client_reference.rst timeout line (#4194) (#4206)
7db4a2e 
Specify the unit of measure of the timeout.
(cherry picked from commit 32ce31c)

Co-authored-by: Andrea Giacomo Baldan <a.g.baldan@gmail.com>
@asvetlov
Backport 04a519b 3.6 (#4217)
d5e2bea 
* Drop Travis CI and Appveyor from build matrix (#4184)

(cherry picked from commit 04a519b)

* [3.6] Drop Travis CI and Appveyor from build matrix (#4184).
(cherry picked from commit 04a519b)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov @JenSte
[3.6] Fix the string representation of ServerDisconnectedError (#4188…
89a30d2 
…) (#4208)

(cherry picked from commit a54956d)

Co-authored-by: JenSte <jens.steinhauser@protonmail.com>
@dependabot-preview @asvetlov
[3.6] Bump aiohttp-theme from 0.1.5 to 0.1.6 (#4210)
267edd6 
Bumps [aiohttp-theme](https://github.com/aio-libs/aiohttp-theme) from 0.1.5 to 0.1.6.
- [Release notes](https://github.com/aio-libs/aiohttp-theme/releases)
- [Changelog](https://github.com/aio-libs/aiohttp-theme/blob/master/docs/changelog.rst)
- [Commits](aio-libs/aiohttp-theme@v0.1.5...v0.1.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @asvetlov
[3.6] Bump cryptography from 2.7 to 2.8 (#4211)
53c6446 
Bumps [cryptography](https://github.com/pyca/cryptography) from 2.7 to 2.8.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst)
- [Commits](pyca/cryptography@2.7...2.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @asvetlov
[3.6] Bump mypy from 0.720 to 0.740 (#4202)
ee85a27 
* [3.6] Bump mypy from 0.720 to 0.740

Bumps [mypy](https://github.com/python/mypy) from 0.720 to 0.740.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.720...v0.740)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Fix types
@asvetlov @detroyejr
[3.6] Add docs for nginx + gunicorn + ssl (#4201) (#4207)
447261a 
(cherry picked from commit 993d6e7)

Co-authored-by: Jonathan De Troye <detroyejr@outlook.com>
@dependabot-preview
[3.6] Bump mypy-extensions from 0.4.2 to 0.4.3 (#4220)
011ca1f
@asvetlov @AtomsForPeace
[3.6] add more types to LooseCookies #4205 (#4218) (#4222)
d51badb 
* add more types to LooseCookies #4205

* predefine the Union types for LooseCookies

* add CHANGES fragment
(cherry picked from commit e048934)

Co-authored-by: Adam Bannister <adam.p.bannister@gmail.com>
@hynek @asvetlov
Backport fix of noop in least invasive way (#4213)
60f01cc 
The coroutine-style definition of noop causes a warning on Python 3.8.

On master, it has been fixed and noop2 removed. This is the least invasive
way to get rid of the warning in 3.6.
@sunitdev @asvetlov
Clientsession timeout property (#4193)
c0a36b2
@asvetlov
Document ClientSession.timeout property
7b86839
@asvetlov
Fix type declaration
609990b
@asvetlov
Fix mypy checker task name
4fbcfd5
@asvetlov
Remove unused type: ignore
e81f6dd
@asvetlov
Update CI badges
2d8f62b
@asvetlov
[3.6] Apply Azure badge everywhere (#4226) (#4228)
5952461 
(cherry picked from commit f79f513)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov @rbialon
[3.6] Implement BaseRequest.get_extra_info() (#4196) (#4231)
529e760 
Add versionadded to get_extra_info() documentation
(cherry picked from commit fbc9cf6)

Co-authored-by: Raphael Bialon <rbialon@users.noreply.github.com>
@asvetlov
[3.6] Refactor the test to fail instead of hanging (#4225) (#4229)
c7eb6cf 
(cherry picked from commit c7d841d)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov @zlatsic
[3.6] UrlDispatcher - add_routes returns a list of AbstractRoutes (#4141
62ebaa2 
) (#4233)

Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>.
(cherry picked from commit 60e6c22)

Co-authored-by: Zlatan <zlatan.sicanica@gmail.com>
@asvetlov
[3.6] Drop unused anymore tool scripts (#4227). (#4230)
e873709 
(cherry picked from commit 36bb09d)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov
[3.6] Fix docs markup (#4232) (#4234)
c43ae74 
(cherry picked from commit 2cdabe2)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov and others added 8 commits October 19, 2019 13:46
@asvetlov @polcak
[3.6] Fix issue #4190 (#4197). (#4235)
78ea83f 
(cherry picked from commit 564d9cc)

Co-authored-by: polcak <ipolcak@fit.vutbr.cz>
@asvetlov
[3.6] Increate test timeout to satisfy slow CI box (#4236) (#4237)
b2ceae8 
(cherry picked from commit 3cf4104)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov @paulefoe
[3.6] Added properties of default ClientSession params to ClientSessi…
0dbf937 
…on class (#4240) (#4242)

* [3.6] Added properties of default ClientSession params to ClientSession class (#4240)
(cherry picked from commit 5f291b0)

Co-authored-by: Pavel Filatov <triksrimer@gmail.com>
@dependabot-preview
[3.7] Bump tox from 3.13.2 to 3.14.0 (#4244)
d8ffad8
@AtomsForPeace
add tests for accepted LooseCookies types
c7c2c98
@AtomsForPeace
add more types for LooseCookies
a8b8c85
@AtomsForPeace
add changes file to describe changes made
a508ffb
@AtomsForPeace
add myself to CONTRIBUTORS.txt
abf2382
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AtomsForPeace @asvetlov @hynek @sunitdev