Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/client_reference.rst timeout line #4194

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

codepr
Copy link
Contributor

@codepr codepr commented Oct 16, 2019

Specify the unit of measure of the timeout.

What do these changes do?

Updated the unit of measure of the total parameter on aiohttp.ClientTimeout class, in order to avoid ambiguity.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Specify the unit of measure of the timeout.
@asvetlov
Copy link
Member

Thanks!

@asvetlov asvetlov merged commit 32ce31c into aio-libs:master Oct 17, 2019
asvetlov pushed a commit that referenced this pull request Oct 17, 2019
Specify the unit of measure of the timeout.
(cherry picked from commit 32ce31c)

Co-authored-by: Andrea Giacomo Baldan <a.g.baldan@gmail.com>
asvetlov added a commit that referenced this pull request Oct 17, 2019
Specify the unit of measure of the timeout.
(cherry picked from commit 32ce31c)

Co-authored-by: Andrea Giacomo Baldan <a.g.baldan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants