-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Mention that timeouts are in seconds #4190
Labels
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
Hacktoberfest
We think it's good for https://hacktoberfest.digitalocean.com/
Comments
asvetlov
added
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
Hacktoberfest
We think it's good for https://hacktoberfest.digitalocean.com/
labels
Oct 16, 2019
Pull request is welcome! |
Hello, thanks for the great work with the library, addressed the issue on #4194 . |
polcak
added a commit
to polcak/aiohttp
that referenced
this issue
Oct 16, 2019
Fixed I guess |
asvetlov
pushed a commit
that referenced
this issue
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
Hacktoberfest
We think it's good for https://hacktoberfest.digitalocean.com/
The docs such as https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientTimeout does not mention what are the units for the timeout, are these second, miliseconds, minutes?
Looking at https://docs.aiohttp.org/en/stable/client_quickstart.html#aiohttp-client-timeouts I figured out that timeouts are specified as seconds but only after reading to the very botom. Even there the units are not mentioned but rather the docs mention "By default aiohttp uses a total 5min timeout" and "Thus the default timeout is: aiohttp.ClientTimeout(total=5*60, connect=None,
sock_connect=None, sock_read=None)"
Expected behaviour
Please specify the units explicitely, e.g.: "Total number of seconds for the whole request." rather than "Total timeout for the whole request."
The text was updated successfully, but these errors were encountered: