[3.6] Implement BaseRequest.get_extra_info() (#4196) #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add get_extra_info for BaseRequest `BaseRequest.get_extra_info()` provides a shortcut for accessing extra information from the underlying protocols' transport * Add get_extra_info default value test * Add return type annotation to BaseRequest.get_extra_info() * Remove async from BaseRequest.get_extra_info() * Rewrite get_extra_info test, cover all branches * Add news entry to CHANGES for #4189 * Add Raphael Bialon to CONTRIBUTORS.txt * Add documentation for BaseRequest.get_extra_info() * Update web_reference.rst Add versionadded to get_extra_info() documentation (cherry picked from commit fbc9cf6) Co-authored-by: Raphael Bialon <rbialon@users.noreply.github.com>
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## 3.6 #4231 +/- ##
==========================================
+ Coverage 97.97% 97.97% +<.01%
==========================================
Files 44 44
Lines 8874 8882 +8
Branches 1390 1392 +2
==========================================
+ Hits 8694 8702 +8
Misses 71 71
Partials 109 109
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseRequest.get_extra_info()provides a shortcut for accessing extrainformation from the underlying protocols' transport
Add versionadded to get_extra_info() documentation
(cherry picked from commit fbc9cf6)
Co-authored-by: Raphael Bialon rbialon@users.noreply.github.com