Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early finish fix #1544

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Early finish fix #1544

merged 4 commits into from
Aug 19, 2024

Conversation

jreidinger
Copy link
Contributor

Problem

See #1542

Solution

After debugging it shows that queries work, but when query gets invalidated it reread data and it wrongly parse json data and set busy status as undefined.

Testing

  • Added a new unit test
  • Tested manually

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 71.298%. remained the same
when pulling c447cdd on early_finish_fix
into fc0f3a2 on master.

@jreidinger jreidinger marked this pull request as ready for review August 19, 2024 11:53
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate if anyone with more knowledge of the web UI would be around. But it's August. :-) Personally, this LGTM.

@jreidinger
Copy link
Contributor Author

If there is anyone with more web knowledge I would be happy to let him do request instead of me 😂

@jreidinger jreidinger merged commit 5f2b96b into master Aug 19, 2024
2 checks passed
@jreidinger jreidinger deleted the early_finish_fix branch August 19, 2024 12:20
@jreidinger
Copy link
Contributor Author

@ancorgs sadly fix is wrong...basically it looks like SLE16 uses old rust backend! the change was done by imo afef47b and this PR breaks opensuse build :( ... we have some issue with auto submission to IBS project :(

jreidinger added a commit that referenced this pull request Aug 20, 2024
Reverts #1544

The change is wrong as it was tested/debugged against old version of
backend that does not have
afef47b
... The result is that new sources are now broken.
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants