feat(web): start using TypeScript #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
commented
Jul 12, 2024
Comment on lines
-126
to
+129
| const [ | ||
| { data: config }, | ||
| { data: locales }, | ||
| { data: keymaps }, | ||
| { data: timezones } | ||
| ] = useSuspenseQueries({ | ||
| queries: [ | ||
| configQuery(), | ||
| localesQuery(), | ||
| keymapsQuery(), | ||
| timezonesQuery() | ||
| ] | ||
| }); | ||
| const [{ data: config }, { data: locales }, { data: keymaps }, { data: timezones }] = | ||
| useSuspenseQueries({ | ||
| queries: [configQuery(), localesQuery(), keymapsQuery(), timezonesQuery()] | ||
| }); |
There was a problem hiding this comment.
Ouch, I didn't realize I sent these (and others) format changes made by Zed editor which I'm testing. Will revert them in a new commit.
There was a problem hiding this comment.
After a short discussion with @imobachgs, I will keep it as it is because we're gonna format all the code base for consistence.
There was a problem hiding this comment.
BTW, the format change was not because Zed but because Zed applying the rules we have at .prettierrc file
There was a problem hiding this comment.
we're gonna format all the code base for consistence.
Done at #1460
dgdavid
changed the title
imobachgs
approved these changes
Jul 12, 2024
3 tasks
imobachgs
added a commit
that referenced
this pull request
Jul 12, 2024
## Problem After merging #1456, the build task is failing when running it for the production environment (`NODE_ENV=production npm run build`). ## Solution Fix these problems having in mind that most of the complaints will be solved in a better way when migrating components to TypeScript. ## Testing - [x] `npm run server` succeed. - [x] `npm run tests` succeed. - [x] `NODE_ENV=production npm run build` succeed.
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Agama web UI is using plain JavaScript but relying in TypeDoc for performing type checking. It is ok, but as the project grows looks like would be easier and straight forward to use TypeScript instead.
Solution
Start using TypeScript and migrate the current code little by little as the files are touched.
Testing