Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): Improve printing the Agama URL in the console #1515

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jul 30, 2024

Improvements

  • Hide Avahi/mDNS URL if network is not configured (displaying https://agama.local URL is confusing if the network is not available, in that case the URL simply cannot work)
  • Display only configured interfaces (original code printed empty https:// URL for not configured devices, like not configured/not connected Wifi adapters)
  • Refresh the URLs when a device is changed (it also detects cable connecting/disconnecting)
  • Display a warning if the network is not available. Originally I wanted to display some hint like "Press Alt+F7 to switch to the local installer" but that does not work on some architectures (S390) or in some situations (serial console). So to avoid confusion I have dropped that feature.

Notes

  • Use the NetworkManager backend instead of udev. Udev works on the hardware level and does not detect network configuration changes (configuring Wifi) or changing the connection (unplugging/plugging in the network cable). The NetworkManager provides more details.

Testing

  • Tested manually

Screenshots

  • Video recording of a session where the virtual network cable in a VirtualBox VM was disconnected and then reconnected again
Agama-screen0.webm

- Use the NetworkManager backend
- Hide Avahi URL if network is not configured
- Display only configured interfaces
- Refresh the URLs when a device is changed (or connected/disconnected)
- Display a warning if the network is not available
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👌

@lslezak lslezak merged commit 55cbc90 into master Jul 31, 2024
@lslezak lslezak deleted the better_console_URLs branch July 31, 2024 06:29
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants