refactor(web): use queries for dealing with software #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which allows to move some business logic from the UI to the queries, helping to simplify the SoftwarePatternsSelection component.
Based on a query and as a replacement of client.software.onSelectedPatternsChange.
Otherwise does not work as expected. This changes, however, will force to export all types in the file which was not the case until now. Something to learn about and change or improve.
To avoid TS complaints after exporting the SelectedBy enum. Something to re-check.
To avoid complaint about > Property 'toBeChecked' does not exist on type 'Matchers<void, Element>' See testing-library/jest-dom#442 (comment) and https://github.com/testing-library/jest-dom/releases/tag/v6.2.0
dgdavid
commented
Jul 18, 2024
By using the useQueryClient hook instead of creating a new QueryClient instance. Needed to make it work better when invalidating queries.
To make the export explicit but using the same approach as it is already in use in JS files: exporting things at the end of file.
To avoid below error when running tests for tsx components > Cannot read properties of undefined (reading 'createElement') To know more see * https://dev.to/kkazala/jest-errors-1in7 * https://www.typescriptlang.org/tsconfig/#esModuleInterop
Needed to make tests works as expected. See https://stackoverflow.com/a/61636112
Along with other small changes detected while resurrecting such tests.
dgdavid
force-pushed
the
software-queries
branch
from
2b535d7
to
3706d25
Compare
teclator
added a commit
that referenced
this pull request
Jul 23, 2024
imobachgs
reviewed
Jul 23, 2024
dgdavid
force-pushed
the
software-queries
branch
from
6aa1a2b
to
ac594f7
Compare
It was not invalidating software product query nor triggering the probing when changing the selected product.
|
I have no idea why the |
#1493 should fix the issue. |
imobachgs
approved these changes
Jul 23, 2024
dgdavid
added a commit
that referenced
this pull request
Jul 24, 2024
#1483 didn't drop dead software client methods that were replaced by queries. Let's do it now.
imobachgs
added a commit
that referenced
this pull request
Jul 25, 2024
At this moment, the code for working with product registration is not used. Moreover, it has to be migrated to a TanStack Query approach because reasons stated at #1439 Thus, we've agreed to drop it meanwhile in order to have less dead/unused/pending to adapt code. Please, note that changes were done on top of #1498, reason why would be nice to merge this after it. Additionally, it includes a removal of software typedef comments that were forgotten at #1483 and #1496.
dgdavid
added a commit
that referenced
this pull request
Aug 2, 2024
By mistake, #1483 introduced a tiny bug in the `useProductChanges` query hook by checking the `event.type` against an empty string instead of the exepected `ProductChanged` event. https://github.com/openSUSE/agama/pull/1483/files#diff-e671c06f4a1cefe3bef4af838681c780f2ba41356d44f72f5ce97be1b6eead66R172-R185 This PR fixes it for properly performs the software config query invalidation.
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1439, #1452, and #1470, this set of changes aims to replace the client/software with TanStack queries.
Note that was not possible to fully drop the software client. It has to wait until migration of
WithStatusandWithProgressmixins too.