refactor(web): UI code pruning and clean up round #2
#1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
By moving them from ~/components/{namespace}/routs.js to
~/routes/{namespace}.tsx
It also adds a constant PATHS per namespace and uses them instead of
directly typing the route path again when needed.
Using it as a wrapper for PF/PageGroup accepting children instead of a wrapper for a router <Outlet>. The latest is already rendered by the layout. Please, not that this change is just the starting point of a bigger Page component refactor that should help to improve both, the DX experience and the resulting DOM output.
dgdavid
force-pushed
the
frontend-cleanup-2
branch
from
9386bbe
to
6c21d01
Compare
Because Loading component should be an standalone component agnostic to the layout. Moreover, the SimpleLayout is already importing the Loading component which was kind of circular dependency.
By using functions instead of variables in router.js to prevent the execution of code while importing the file.
Needed to avoid type errors in subsequent changes because not known types of `handle` object values.
For wrapping the Loading component with SimpleLayout. Related to 888830a
Although it could be drop in a future.
dgdavid
changed the title
round #2round #2
imobachgs
approved these changes
Jul 29, 2024
dgdavid
added a commit
that referenced
this pull request
Aug 13, 2024
…ttons (#1536) #1494 introduced a typo when migrating former and temporary _src/components/core/ButtonLink_ to TypeScript, making it to stop looking as a button. Although the fix was ridicously simple, just adding the missing `e` to `scondary`, this PR takes the opportunity for improving the whole component, getting ride of a pending FIXME, using a better name for it, and also adding simple but useful unit tests.
dgdavid
added a commit
that referenced
this pull request
Sep 13, 2024
**Apart from a bit of clean up, this PR is intended for start writing better core components** that has been on hold for a few months already. It's the case of _core/Page_ component, which has been rewritten almost for scratch and now makes the weird _core/CardField transitioning component_ obsolete. Please, note that this set of changes **continues with the migration to TypeScript for touched files** and also **introduce a PatternFly/Flex wrapper** in order to ease the work with its responsive props. It's a bit complex because the (ab)use of advanced types but it does the job without introducing props unknown by PF/Flex. As said in the file comments, ideally > would be better to add these responsive props shortcuts direclty in PF/Flex to allow the consumer to just set the `default` value when not needed to change it depending on the breakpoint. But at this moment we're a bit short of time for creating and testing such an elaborated PR against upstream. --- Related to #1441 and #1494
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1441, just another round of UI code improvements and clean up.