Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Posts template #31

Merged
merged 13 commits into from
Sep 28, 2021
Merged

All Posts template #31

merged 13 commits into from
Sep 28, 2021

Conversation

coreymckrill
Copy link
Contributor

@coreymckrill coreymckrill commented Sep 14, 2021 •
edited
Loading

Adds the index.html template, along with accompanying template parts and styles. This gets close to matching the All Posts mockup page in the design, but a few things have been omitted:

  • The "brush stroke" edge at the bottom of the "All Posts" header. This will be added in when The Blue Bar #32 is addressed.
  • The "Load More Posts" link has been replaced with query pagination, as shown in this amendment.
  • The "Subscribe to WordPress News" box has been left out of the footer, because block templates do not support rendering shortcodes, which is currently the only way to render Jetpack's subscription form. Jetpack: subscription form shortcode not rendered #35
  • Some of the podcast player icons in the WP Briefing footer box are generic links because the Social Icons block does not currently support all the necessary brands/services. Gutenberg: Missing icons for the WP Briefing callout #36

Fixes #22

@coreymckrill coreymckrill added this to the Initial Launch milestone Sep 14, 2021
@coreymckrill coreymckrill self-assigned this Sep 14, 2021
@coreymckrill coreymckrill force-pushed the fix/22/archive-template branch from 858029a to 37e1c63 Compare September 24, 2021 23:22
@coreymckrill coreymckrill changed the title All Posts template and baseline for other archives All Posts template Sep 28, 2021
@coreymckrill coreymckrill marked this pull request as ready for review September 28, 2021 22:37
iandunn
iandunn approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

source/wp-content/themes/wporg-news-2021/block-templates/index.html Outdated Show resolved Hide resolved
source/wp-content/themes/wporg-news-2021/block-template-parts/footer-archive.html
<!-- /wp:heading -->
<!-- wp:paragraph -->
<p>Check out the <a href="https://central.wordcamp.org/">WordCamp schedule</a> and find your <a href="https://www.meetup.com/pro/wordpress">local Meetup group</a>! For more WordPress news, check out the <a href="http://planet.wordpress.org/">WordPress Planet</a>.</p>
<!-- /wp:paragraph -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we could maybe use the Events Widget to show actual events here instead, but that'd definitely be a separate pr

@coreymckrill coreymckrill merged commit 5f52207 into trunk Sep 28, 2021
@iandunn iandunn mentioned this pull request Sep 29, 2021
Merged
@iandunn iandunn deleted the fix/22/archive-template branch November 5, 2021 20:25
@iandunn iandunn removed this from the Initial Launch: Functionality milestone Nov 5, 2021
@StevenDufresne StevenDufresne mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iandunn iandunn iandunn approved these changes

Assignees

@coreymckrill coreymckrill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement design for All Posts archive
2 participants
@coreymckrill @iandunn