Refine padding/margin, override block gap #28
Conversation
iandunn
force-pushed
the
head-foot-styles
branch
2 times, most recently
from
0ee2a9a to
c2f4c2c
Compare
iandunn
changed the title
iandunn
force-pushed
the
head-foot-styles
branch
4 times, most recently
from
dce3a2e to
3a3b057
Compare
iandunn
force-pushed
the
head-foot-styles
branch
from
3a3b057 to
7ebb98e
Compare
| <!-- wp:group {"tagName":"nav","align":"wide","className":"post-navigation"} --> | ||
| <nav class="wp-block-group alignwide post-navigation"> | ||
| <!-- wp:group {"tagName":"nav","align":"full","className":"post-navigation"} --> | ||
| <nav class="wp-block-group alignfull post-navigation"> |
There was a problem hiding this comment.
Why change this to full? Won't this make it so the previous/next links are out on the edges of the viewport instead of staying within the content column?
There was a problem hiding this comment.
🤔 , good point. IIRC I did it so that the content would line up w/ the footer content, but i'll take a closer look.
There was a problem hiding this comment.
yeah, i think this works fine. we could also change it to work w/ alignwide, but i think this makes more sense semantically, since post navigation isn't part of the content of a post
(at least it's not in the DOM; philosophically i can see it either way, but would personally learn towards it being outside)
There was a problem hiding this comment.
I went ahead and merged to keep the # active branches low, but I'm happy to continue discussing if you have any other thoughts
There was a problem hiding this comment.
Just checked this on a super wide screen, and it looks like it does make the previous/next links sit too far out. My read on the design mockup is that the "previous" link should line up with the post date and author on the left side, and the "next" link should be justified right and line up with the edge of the post title and content column on the right side.
There was a problem hiding this comment.
Ah, I see what you're saying.
I wonder if it should be aligned with the post content and the header/footer, and that the real problem here is that there isn't a "max width" of sorts on the header/footer. I'm guessing we don't want those to grow endlessly.
@beafialho can you add a Figma example of what a whole page should look like when the browser is 2000px wide?
There was a problem hiding this comment.
thanks!
moved discussion to #37 since this pr is already merged
|
merged |
See #6
Interconnected with WordPress/wporg-mu-plugins#5