Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement design for All Posts archive #22

Closed
coreymckrill opened this issue Aug 25, 2021 · 1 comment · Fixed by #31
Closed

Implement design for All Posts archive #22

coreymckrill opened this issue Aug 25, 2021 · 1 comment · Fixed by #31
Assignees
@coreymckrill
Milestone
Initial Launch: F...

Comments

@coreymckrill
Copy link
Contributor

all-posts
@coreymckrill coreymckrill added this to the Initial Launch milestone Aug 25, 2021
@coreymckrill coreymckrill self-assigned this Aug 25, 2021
@coreymckrill coreymckrill mentioned this issue Aug 25, 2021
Closed
21 tasks
@coreymckrill coreymckrill mentioned this issue Sep 14, 2021
Merged
@beafialho
Copy link
Collaborator

Because the functionality to "Load More Posts" at the bottom of the screen is from Jetpack’s Infinite Scroll module, an alternative would be to have “Older Posts” / “Newer Posts”, as exemplified here.

In pages with a center-aligned listing, the pagination would be centered:

Captura de ecrã 2021-09-24, às 17 49 54

In pages with a different alignment, the pagination would be left-aligned, according to the page's grid:

Captura de ecrã 2021-09-24, às 17 50 06

coreymckrill added a commit that referenced this issue Sep 28, 2021
@coreymckrill
All Posts template (#31)
5f52207 
Adds the index.html template, along with accompanying template parts and styles. This gets close to matching the All Posts mockup page in the design, but a few things have been omitted:

* The "brush stroke" edge at the bottom of the "All Posts" header. This will be added in when #32 is addressed.
* The "Load More Posts" link has been replaced with query pagination.
* The "Subscribe to WordPress News" box has been left out of the footer, because block templates do not support rendering shortcodes, which is currently the only way to render Jetpack's subscription form.
* Some of the podcast player icons in the WP Briefing footer box are generic links because the Social Icons block does not currently support all the necessary brands/services.

Fixes #22
iandunn added a commit that referenced this issue Nov 10, 2021
@iandunn
Theme: Show pagination controls on mobile.
58e0767 
It appears in the mockup, and it seems wrong to hide it based on device. Similar to #46.

Aside: See #22 (comment) for an adjustment to the pagination that doesn't appear in the mockup, but is treated as final.
iandunn added a commit that referenced this issue Nov 10, 2021
@iandunn
Theme: Show pagination controls on mobile.
cc7f98d 
It appears in the mockup, and it seems wrong to hide it based on device. Similar to #46.

Aside: See #22 (comment) for an adjustment to the pagination that doesn't appear in the mockup, but is treated as final.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreymckrill coreymckrill

Labels
None yet
Projects
None yet
Milestone
Initial Launch: Functionality
Development

Successfully merging a pull request may close this issue.

All Posts template WordPress/wporg-news-2021
3 participants
@iandunn @coreymckrill @beafialho