Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipses from CSS looks unnecessary on post excerpt #366

Closed
vijayhardaha opened this issue Mar 18, 2022 · 2 comments · Fixed by #370
Closed

Ellipses from CSS looks unnecessary on post excerpt #366

vijayhardaha opened this issue Mar 18, 2022 · 2 comments · Fixed by #370

Comments

@vijayhardaha
Copy link

.wp-block-post-excerpt__excerpt {
// Add an ellipses so that excerpts are not just cut off mid-sentence.
// Necessary since we're making the "more text" a link on a separate line.
&::after {

https://wordpress.org/news/category/interviews/
https://wordpress.org/news/category/releases/page/2/

Screenshot 2022-03-18 at 11 55 04 AM
Screenshot 2022-03-18 at 12 05 26 PM

@StevenDufresne
Copy link
Collaborator

This was introduced in #31

@coreymckrill It isn't clear looking through the PR why the ellipses are necessary since they are already truncated. Thoughts?

@coreymckrill
Copy link
Contributor

🤔 That's odd. I'm guessing that something about the way the excerpt block was implemented by the theme changed later. Or something about the way they are implemented in Gutenberg changed. Either way, seems safe now to assume we can remove the CSS rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants