Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Missing icons for the WP Briefing callout #36

Closed
3 tasks
coreymckrill opened this issue Sep 28, 2021 · 5 comments
Closed
3 tasks

Gutenberg: Missing icons for the WP Briefing callout #36

coreymckrill opened this issue Sep 28, 2021 · 5 comments
Labels
Help Wanted Extra attention is needed [Status] Blocked (external) Blocked by something outside our direct control

Comments

@coreymckrill
Copy link
Contributor

The design calls for a row of icons representing the different services where you can listen to the WP Briefing podcast. At present, the Social Icons block only supports Spotify and RSS, so the following services only get a generic link icon:

  • Apple Podcasts
  • Pocket Casts
  • Stitcher

We should either add some custom SVGs for those icons or submit a PR to Gutenberg to get those icons added.

@tellyworth
Copy link
Contributor

@kellychoffman @beafialho can Design help with this?

@beafialho
Copy link
Collaborator

Maybe these would be useful for users in Gutenberg as well, but I'm fine with whatever you think works best.

Here are the SVG files: podcast_icons.zip

@iandunn iandunn changed the title Missing icons for the WP Briefing callout Gutenberg: Missing icons for the WP Briefing callout Nov 4, 2021
@iandunn iandunn added the [Status] Blocked (external) Blocked by something outside our direct control label Nov 4, 2021
@iandunn iandunn self-assigned this Nov 22, 2021
iandunn added a commit that referenced this issue Nov 22, 2021
These should be removed once Gutenberg adds them to the block.

See #36
@iandunn
Copy link
Member

iandunn commented Nov 22, 2021

I overwrote the "chain" icon in 616100d, as a workaround until Gutenberg adds them.

Moving to the post-launch iteration milestone so that they can be removed once they're no longer needed.

@iandunn iandunn removed their assignment Nov 22, 2021
@iandunn iandunn mentioned this issue Nov 22, 2021
20 tasks
@iandunn
Copy link
Member

iandunn commented Nov 22, 2021

xref WordPress/gutenberg#36755

@iandunn
Copy link
Member

iandunn commented Dec 14, 2021

I opened #131 for the remaining work

@iandunn iandunn closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed [Status] Blocked (external) Blocked by something outside our direct control
Projects
None yet
Development

No branches or pull requests

4 participants