Improve `Dockerfile` and enable pipeline to automate docker image generation #388

rbadillap · 2021-10-29T01:00:59Z

Description

In this PR I'm implementing the following features:

Stabilize the Dockerfile to follow common standards and allow us to create a docker image of the application that can be uploaded in a registry
Enable two GitHub Actions workflows:
- pre-build that runs npm run lint to make sure the code follows our existing code standards
- build that generates a docker image and pushes in a registry when a pre-released has been created

Testing Instructions

This is under development, a documentation about how to test this workflow will be provided soon

…lease has been created

zackkrida

Very excited to see the GitHub action for publishing images Ronny!

The Dockerfile you edited is used in development. We will need separate Dockerfiles for development and production. Please make two Dockerfiles with different names, restoring the original, and perhaps moving them into a docker/ directory.

Please see my note about the get-translations script too.

Dockerfile

* main: Replace PDM logo (#411) Add playwright e2e tests (#394) Update breakpoints to the new Tailwind config (#408) Create a global audio player (amongst many smaller improvements) (#399) Create Skeleton components (#392) Tailwind breakpoints (#403) Avoid error using only local translation files (#367) Add base Button component (#372) Use Tailwind RTL styles everywhere (#355) Add a dependencies section and remove the redundant title (#379) 🔄 Synced file(s) with WordPress/openverse (#384) Fix filters not being set on SSR (#386)

…low the use of this stage

rbadillap · 2021-11-13T06:22:20Z

Details of features integrated in latest commits:

Created a .dockerignore file which is different than .gitignore, the docker image is lighter now
Fixed the Dockerfile that makes impossible to run the application after running npm run build in previous stage
Created a multistage strategy, to reduce the size of the image and to unify in a single file the different modes we can operate this application, e.g: production and development modes
Added a new stage called dev, with this method we don't need to create an additional file with different name, we just indicate the target in our docker-compose.yml file. The team only need to run docker compose build in their local machines to make this working.

To improve:

A couple of points I'm still considering we can improve:

core-js dependency was moved to dependencies instead of devDependencies in the package.json because part of the code require it. Do we need it?
I'm using node:16 for production stage, should I replace it to node-alpine? I believe so because the dependencies are already installed and the package was properly created in the builder stage.

Dockerfile

* main: Create the `InputField` and `SearchBar` components (#380) Add VPopover component (#397) Search and media store refactoring (#398) Node 16 and NPM 8 (#413)

* main: Fix state errors (#417) Add Checkbox component (#406) Fix package-lock.json engines (#430) Make Homepage and Searchbar RTL-compatible (#427)

sarayourfriend

RE core-js: I'm confused why we have it declared as an explicit dependency. We don't reference it anywhere in the app as far as I can tell, and it would be included anyway as a dependency of several other (mostly storybook as far as I can tell) libraries.

Added a new stage called dev, with this method we don't need to create an additional file with different name, we just indicate the target in our docker-compose.yml file. The team only need to run docker compose build in their local machines to make this working.

This is really cool! I didn't know it was possible to do that but it is so much nicer than maintaining separate files for each environment.

sarayourfriend · 2021-11-19T19:56:23Z

Dockerfile

+# copy the nuxt configuration file
+COPY --from=builder /usr/app/nuxt.config.js .
+
+# copy distribution directory with the static content
+COPY --from=builder /usr/app/.nuxt /usr/app/.nuxt
+
+# copy some files required by nuxt.config.js
+COPY --from=builder /usr/app/src/locales /usr/app/src/locales
+COPY --from=builder /usr/app/src/utils  /usr/app/src/utils


This is so cool!

sarayourfriend · 2021-11-19T19:56:24Z

Dockerfile

+# production
+# ==
+# application package (for production)
+FROM node:16 AS app


Should we use node-alpine for the app (result) image so that the final payload is smaller? I'm not totally sure we need the regular node image at all but if we can get away with using node-alpine for the release at least that would be nice.

@sarayourfriend done, tests worked perfectly

zackkrida · 2021-11-28T22:26:32Z

~~Currently blocked by #415, can we get that reviewed asap @WordPress/openverse-frontend ?~~ Merged!

* Remove `nuxt-ssr-cache` and `patch-package` * Correct dependencies placement * Change `dropdown.spec.js` to use testing-library * Add `VIcon` to stubs in audio-track.spec.js This removes its warnings when running the test. * Bump node version to 16.13.0 on ci workflow * Keep prettier at v2.2.1 * Move `vue-i18n-extract` and `babel-jest` to devDependencies

zackkrida · 2021-11-29T22:52:22Z

@rbadillap could you add some testing instructions here? I tried testing this two ways and ran into issues. By the way, I tried with node:16 and node:16-alpine and get the same results:

Running docker-compose up in the root to test the dev configuration. The app looked like it was running correctly but I wasn't able to view localhost:8443 in my browser. Perhaps some issue about exposing the port? Here's my terminal output from this testing:

front on  ci/pipelines +0/-0 [$] via  v16.13.0
❯ docker-compose up
[+] Building 2.7s (6/9)
 => [internal] load build definition from Dockerfile                                                                                                     0.0s
 => => transferring dockerfile: 1.81kB                                                                                                                   0.0s
 => [internal] load .dockerignore                                                                                                                        0.0s
 => => transferring context: 430B                                                                                                                        0.0s
 => [internal] load metadata for docker.io/library/node:16                                                                                               1.1s
 => [auth] library/node:pull token for registry-1.docker.io                                                                                              0.0s
 => ERROR [internal] load build context                                                                                                                  1.5s
 => => transferring context: 16.20MB                                                                                                                     1.5s
 => CANCELED [dev 1/4] FROM docker.io/library/node:16@sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba                            1.5s
 => => resolve docker.io/library/node:16@sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba                                         0.0s
 => => sha256:bbdd5360e7c6d855d09d5bb772bdb8d96e2252ba210a5939638d8fa9305418b9 7.62kB / 7.62kB                                                           0.0s
 => => sha256:d3a9ec6dcb7756c65db951b3a0723ca0e49e83b344f01f9eff4c1dddf626f521 2.21kB / 2.21kB                                                           0.0s
 => => sha256:626979e62c56e192812e818d52b82f063d9f9514b1b7bae14e534e4a7c98117a 18.87MB / 49.22MB                                                         1.5s
 => => sha256:134a528370d5dcbf5b6ba2d8c20f576504448e8f2d1debb5d2a4950a38a3ff2d 7.70MB / 7.70MB                                                           0.5s
 => => sha256:92e12e3364b52ad043d8e79f750863ed4ca2878c4fdf45ded974508febc55fdd 9.77MB / 9.77MB                                                           0.6s
 => => sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba 1.21kB / 1.21kB                                                           0.0s
 => => sha256:1a7f2500f9574b0a495bfb031c2d52e83c96dd545ef2185737f8032567e70677 15.73MB / 52.17MB                                                         1.5s
 => => sha256:16922d4fa4f2c649c56a586e06135309b0cc7e160a17c909e5eb349988df61aa 15.73MB / 183.99MB                                                        1.5s
------
 > [internal] load build context:
------
canceled

front on  ci/pipelines +0/-0 [$] via  v16.13.0 took 3s
❯ docker-compose up
[+] Building 110.1s (9/9) FINISHED
 => [internal] load build definition from Dockerfile                                                                                                     0.0s
 => => transferring dockerfile: 1.82kB                                                                                                                   0.0s
 => [internal] load .dockerignore                                                                                                                        0.0s
 => => transferring context: 35B                                                                                                                         0.0s
 => [internal] load metadata for docker.io/library/node:16                                                                                               0.2s
 => [dev 1/4] FROM docker.io/library/node:16@sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba                                    14.9s
 => => resolve docker.io/library/node:16@sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba                                         0.0s
 => => sha256:d3a9ec6dcb7756c65db951b3a0723ca0e49e83b344f01f9eff4c1dddf626f521 2.21kB / 2.21kB                                                           0.0s
 => => sha256:bbdd5360e7c6d855d09d5bb772bdb8d96e2252ba210a5939638d8fa9305418b9 7.62kB / 7.62kB                                                           0.0s
 => => sha256:626979e62c56e192812e818d52b82f063d9f9514b1b7bae14e534e4a7c98117a 49.22MB / 49.22MB                                                         2.6s
 => => sha256:134a528370d5dcbf5b6ba2d8c20f576504448e8f2d1debb5d2a4950a38a3ff2d 7.70MB / 7.70MB                                                           0.7s
 => => sha256:92e12e3364b52ad043d8e79f750863ed4ca2878c4fdf45ded974508febc55fdd 9.77MB / 9.77MB                                                           0.7s
 => => sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba 1.21kB / 1.21kB                                                           0.0s
 => => sha256:1a7f2500f9574b0a495bfb031c2d52e83c96dd545ef2185737f8032567e70677 52.17MB / 52.17MB                                                         4.1s
 => => sha256:16922d4fa4f2c649c56a586e06135309b0cc7e160a17c909e5eb349988df61aa 183.99MB / 183.99MB                                                       8.7s
 => => sha256:84cc5e80e64366a68273e2ac1ca25095412df33cb46159d00b8a87993fbecf8c 4.09kB / 4.09kB                                                           2.8s
 => => sha256:83f93887ffb88aa526b22aab7eda03959f4bcd05f9f5ba3956a4ddc1be3d7afc 33.49MB / 33.49MB                                                         4.9s
 => => extracting sha256:626979e62c56e192812e818d52b82f063d9f9514b1b7bae14e534e4a7c98117a                                                                3.2s
 => => sha256:914230f868db471e02be87534053a8a49c54657e093c419893e1021e955e0fe5 2.27MB / 2.27MB                                                           4.5s
 => => sha256:b39fc254b321c6e3013710f7943fee19573b2d372fbdb8c13997bc9bdfa55b94 453B / 453B                                                               4.6s
 => => extracting sha256:134a528370d5dcbf5b6ba2d8c20f576504448e8f2d1debb5d2a4950a38a3ff2d                                                                0.4s
 => => extracting sha256:92e12e3364b52ad043d8e79f750863ed4ca2878c4fdf45ded974508febc55fdd                                                                0.4s
 => => extracting sha256:1a7f2500f9574b0a495bfb031c2d52e83c96dd545ef2185737f8032567e70677                                                                1.6s
 => => extracting sha256:16922d4fa4f2c649c56a586e06135309b0cc7e160a17c909e5eb349988df61aa                                                                4.3s
 => => extracting sha256:84cc5e80e64366a68273e2ac1ca25095412df33cb46159d00b8a87993fbecf8c                                                                0.1s
 => => extracting sha256:83f93887ffb88aa526b22aab7eda03959f4bcd05f9f5ba3956a4ddc1be3d7afc                                                                0.9s
 => => extracting sha256:914230f868db471e02be87534053a8a49c54657e093c419893e1021e955e0fe5                                                                0.1s
 => => extracting sha256:b39fc254b321c6e3013710f7943fee19573b2d372fbdb8c13997bc9bdfa55b94                                                                0.0s
 => [internal] load build context                                                                                                                        7.1s
 => => transferring context: 101.90MB                                                                                                                    7.1s
 => [dev 2/4] WORKDIR /usr/app                                                                                                                           0.1s
 => [dev 3/4] COPY . /usr/app                                                                                                                            0.3s
 => [dev 4/4] RUN npm install                                                                                                                           73.1s
 => exporting to image                                                                                                                                  21.3s
 => => exporting layers                                                                                                                                 21.3s
 => => writing image sha256:922b39fb6f7e99d735d25f06b52bf51971a8e53b766ea0aa5d5ee8d2af9da547                                                             0.0s
 => => naming to docker.io/library/front_web                                                                                                             0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
[+] Running 2/2
 ⠿ Network front_default  Created                                                                                                                        0.0s
 ⠿ Container front-web-1  Created                                                                                                                        0.1s
Attaching to front-web-1
front-web-1  |
front-web-1  | > openverse-frontend@2.2.1 dev
front-web-1  | > npm run i18n:get-valid-locales && cross-env ENABLE_AUDIO=true nuxt
front-web-1  |
front-web-1  |
front-web-1  | > openverse-frontend@2.2.1 i18n:get-valid-locales
front-web-1  | > node src/locales/scripts/get-validated-locales
front-web-1  |
front-web-1  | /usr/app
front-web-1  | > Wrote locale metadata for @nuxt/i18n.
front-web-1  | ℹ Merging Tailwind config from ~/../tailwind.config.js
front-web-1  | ✔ Sentry reporting is enabled (client side: enabled, server side: enabled)
front-web-1  | Cache updated from undefined to 2.2.1
front-web-1  | ℹ Listening on: http://172.22.0.2:8433/
front-web-1  | ℹ Preparing project for development
front-web-1  | ℹ Initial build may take a while
front-web-1  | ℹ Discovered Components: .nuxt/components/readme.md
front-web-1  | ✔ Builder initialized
front-web-1  | ✔ Nuxt files generated
front-web-1  | ℹ Compiling Server
front-web-1  | ℹ Compiling Client
front-web-1  | ℹ Compiling Modern
front-web-1  | ✔ Server: Compiled successfully in 35.98s
front-web-1  | ✔ Client: Compiled successfully in 38.54s
front-web-1  |
front-web-1  |  WARN  Compiled with 1 warnings
front-web-1  |
front-web-1  | "export 'default' (reexported as 'VPopoverContentTypes') was not found in '../../src/components/VPopover/VPopoverContent.types.js'
front-web-1  |
front-web-1  |
front-web-1  |  WARN  in ./.nuxt/components/index.js
front-web-1  |
front-web-1  | ✔ Modern: Compiled successfully in 38.59s
front-web-1  |
front-web-1  |  WARN  Compiled with 1 warnings
front-web-1  |
front-web-1  |
front-web-1  |  WARN  in ./.nuxt/components/index.js
front-web-1  |
front-web-1  | "export 'default' (reexported as 'VPopoverContentTypes') was not found in '../../src/components/VPopover/VPopoverContent.types.js'
front-web-1  |
front-web-1  | ℹ Waiting for file changes
front-web-1  | ℹ Memory usage: 736 MB (RSS: 1.29 GB)
front-web-1  | ℹ Listening on: http://172.22.0.2:8433/

Building and running an image. This gave an error that No build files found in /usr/app/8443:8443/.nuxt/dist/server. Here's that terminal output:

front on  ci/pipelines +1/-1 [$!] via  v16.13.0
❯ docker build . -f Dockerfile -t front
[+] Building 159.3s (21/21) FINISHED
 => [internal] load build definition from Dockerfile                                                                                                     0.0s
 => => transferring dockerfile: 1.83kB                                                                                                                   0.0s
 => [internal] load .dockerignore                                                                                                                        0.0s
 => => transferring context: 35B                                                                                                                         0.0s
 => [internal] load metadata for docker.io/library/node:16-alpine                                                                                        1.0s
 => [internal] load metadata for docker.io/library/node:16                                                                                               0.6s
 => [auth] library/node:pull token for registry-1.docker.io                                                                                              0.0s
 => [builder 1/6] FROM docker.io/library/node:16@sha256:580a0850049c59a48f06090edd48c9f966c5e6572bbbabc369ba3ecbc4855dba                                 0.0s
 => [internal] load build context                                                                                                                        5.6s
 => => transferring context: 93.08MB                                                                                                                     5.1s
 => [app 1/8] FROM docker.io/library/node:16-alpine@sha256:60ef0bed1dc2ec835cfe3c4226d074fdfaba571fd619c280474cc04e93f0ec5b                              2.7s
 => => resolve docker.io/library/node:16-alpine@sha256:60ef0bed1dc2ec835cfe3c4226d074fdfaba571fd619c280474cc04e93f0ec5b                                  0.0s
 => => sha256:60ef0bed1dc2ec835cfe3c4226d074fdfaba571fd619c280474cc04e93f0ec5b 1.43kB / 1.43kB                                                           0.0s
 => => sha256:dfa34389d7202cbe7fa82869b9f4c6743c428e8f624136ea8b1783b7aa854fcd 1.16kB / 1.16kB                                                           0.0s
 => => sha256:36c50d7333516a6caa0ab9889df00d9d09b1f8a7c34f1eb399ded7c1a1916f75 6.55kB / 6.55kB                                                           0.0s
 => => sha256:b0e166648ff59d555a8f6c3dd0f24f730d74951c2ef091cbd9825184c4c980b2 34.87MB / 34.87MB                                                         1.3s
 => => sha256:6d3f0f01fe604d82f6d3c79be141c5eca357aaf3761637c2ff4b7f2195147c6a 2.41MB / 2.41MB                                                           0.4s
 => => sha256:50a2cb941575490726f78d2eb81d4c909b27690959f82028a80beab035034256 450B / 450B                                                               0.2s
 => => extracting sha256:b0e166648ff59d555a8f6c3dd0f24f730d74951c2ef091cbd9825184c4c980b2                                                                0.9s
 => => extracting sha256:6d3f0f01fe604d82f6d3c79be141c5eca357aaf3761637c2ff4b7f2195147c6a                                                                0.1s
 => => extracting sha256:50a2cb941575490726f78d2eb81d4c909b27690959f82028a80beab035034256                                                                0.0s
 => CACHED [builder 2/6] WORKDIR /usr/app                                                                                                                0.0s
 => [app 2/8] WORKDIR /usr/app                                                                                                                           0.0s
 => [app 3/8] COPY package*.json .                                                                                                                       0.1s
 => [builder 3/6] COPY package*.json .                                                                                                                   0.1s
 => [builder 4/6] RUN npm install                                                                                                                       68.6s
 => [builder 5/6] COPY . /usr/app                                                                                                                        0.3s
 => [builder 6/6] RUN npm run build                                                                                                                     44.2s
 => [app 4/8] COPY --from=builder /usr/app/nuxt.config.js .                                                                                              0.0s
 => [app 5/8] COPY --from=builder /usr/app/.nuxt /usr/app/.nuxt                                                                                          0.2s
 => [app 6/8] COPY --from=builder /usr/app/src/locales /usr/app/src/locales                                                                              0.0s
 => [app 7/8] COPY --from=builder /usr/app/src/utils  /usr/app/src/utils                                                                                 0.0s
 => [app 8/8] RUN npm ci --only=production --ignore-script                                                                                              32.6s
 => exporting to image                                                                                                                                   4.1s
 => => exporting layers                                                                                                                                  4.1s
 => => writing image sha256:1e97a4526998b1b74d4dbdbf491339bc77ee274af0a52ffea8d5551ff8eea841                                                             0.0s
 => => naming to docker.io/library/front                                                                                                                 0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them

front on  ci/pipelines +1/-1 [$!] via  v16.13.0 took 2m39s
❯ docker run front -p 8443:8443

> openverse-frontend@2.2.1 start
> nuxt start "8443:8443"


 FATAL  No build files found in /usr/app/8443:8443/.nuxt/dist/server.
Use either `nuxt build` or `builder.build()` or start nuxt in development mode.

  Use either `nuxt build` or `builder.build()` or start nuxt in development mode.
  at VueRenderer._ready (node_modules/@nuxt/vue-renderer/dist/vue-renderer.js:758:13)
  at async Server.ready (node_modules/@nuxt/server/dist/server.js:637:5)
  at async Nuxt._init (node_modules/@nuxt/core/dist/core.js:482:7)


╭──────────────────────────────────────────────────────────────────────────────╮│                                                                              ││   ✖ Nuxt Fatal Error                                                         ││                                                                              ││   Error: No build files found in /usr/app/8443:8443/.nuxt/dist/server.       ││   Use either `nuxt build` or `builder.build()` or start nuxt in              ││   development mode.                                                          ││                                                                              │╰──────────────────────────────────────────────────────────────────────────────╯

changes requested are no longer accurate

obulat · 2021-11-30T06:45:12Z

Dockerfile

+# install dependencies including local development tools
+RUN npm install
+
+# copy the rest of the content


This copy command does not copy the node_modules folder because it's in the dockerignore file, right?

Correct, and as per the official docs, if the .dockerignore file is not present, docker ignores the files present in the .gitignore

obulat · 2021-11-30T06:56:36Z

I have the same problems as in Zack's comment :(

dhruvkb

LGTM for the concept, except some files containing several blank lines at EOF. I did not get the errors when I built the images.

* main: Update Sass breakpoints to match tailwind (#455) Converge `NavSection` components (#454) Use a unique `SearchGridFilter` component (#439) Set explicit ltr direction for pages untranslated in rtl languages (#434) Add VItemGroup component (#410) Update video demos for Meta Search (#420) Fix Search form on smaller viewports (#437) Make Header RTL-compatible (#429) 🔄 Synced file(s) with WordPress/openverse (#449) Removed unused image assets (#404) Restore husky (#444) Bump axios from 0.21.1 to 0.21.2 (#441) Remove husky

rbadillap · 2021-11-30T08:03:24Z

I have the same problems as in Zack's comment :(

@obulat, fixed in the latest commit

rbadillap · 2021-11-30T08:05:48Z

@zackkrida @obulat @sarayourfriend worked in your feedback, fixed the issues when building the image

zackkrida

This is excellent. The new image is much smaller than the original and we now have a unified Dockerfile for development and production 🥳 The new image is much smaller than the original too, coming in at around 452MB.

sarayourfriend

Awesome!

One question: what is the docker-improvements branch this PR targets? Should this PR be targeting main?

zackkrida · 2021-11-30T14:59:44Z

@sarayourfriend the reason this PR and #415 are based on their own branch is that they rely on the removal of nuxt-ssr-cache which we don't have a replacement solution for. Because we now have some time until we need to redeploy the frontend, however, I think it would be a fine idea to merge docker-improvements into main.

zackkrida · 2021-11-30T17:33:01Z

Dockerfile

+
+WORKDIR /usr/app
+
+ENV NODE_ENV=production


Suggested change

ENV NODE_ENV=production

We'll actually want to remove this, related to #450. We want to be able to use NODE_ENV as staging or as production. Can this be moved to the actions, maybe @rbadillap ? By the way, Nuxt builds the app the same in staging or prod mode, so you don't have to worry about differences in the built files based on this key.

based on internal conversations, this should be kept as it

AetherUnbound

This is great! Just one comment about environment variables, but mostly because I'm not sure what scope we're looking for 🙂

AetherUnbound · 2021-11-30T18:20:33Z

.github/workflows/pre-build.yaml

+  push:
+    branches:
+      - 'main'
+      - 'ci/*' # branches that follows the pattern ci/* can access this workflow too


Really solid idea! I always hate troubleshooting issues with commits to main, this is a great workaround.

AetherUnbound · 2021-11-30T18:23:57Z

Dockerfile

-# which could cause issues with native binaries such as node_sass.
-RUN rm -rf /usr/app/node_modules/
+# disable telemetry when building the app
+ENV NUXT_TELEMETRY_DISABLED=1


Is this something we're okay having disabled within the container too? I believe if we make this an ARG, it won't be present for the image's runtime environment (if that's important). ¹

Footnotes

https://vsupalov.com/docker-arg-vs-env/ ↩

I think we want telemetry disabled both places, that's a great question though.

rbadillap added 2 commits October 28, 2021 18:50

feat: added a new workflow to create a docker image when a new pre-re…

a4100a4

…lease has been created

feat: added a new workflow: pre-build

321ebfe

krysal added 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 29, 2021

rbadillap requested review from zackkrida and sarayourfriend November 5, 2021 05:16

rbadillap marked this pull request as ready for review November 5, 2021 05:16

rbadillap requested a review from a team as a code owner November 5, 2021 05:16

zackkrida previously requested changes Nov 5, 2021

View reviewed changes

Dockerfile Show resolved Hide resolved

sarayourfriend reviewed Nov 5, 2021

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

zackkrida mentioned this pull request Nov 5, 2021

Fix dependencies vs devDependencies #401

Closed

7 tasks

rbadillap added 5 commits November 8, 2021 22:53

feat: remove node alpine to allow node gyp installation libraries

4b61e82

feat: fixing some issues in Dockerfile

0b779c5

feat: added dockerignore file and fix Dockerfile multi-stage

6a383ba

feat: added dev mode stage in Dockerfile and fix docker compose to al…

9c8704b

…low the use of this stage

krysal mentioned this pull request Nov 15, 2021

Remove nuxt-ssr-cache and move dependencies #415

Merged

7 tasks

obulat reviewed Nov 16, 2021

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

zackkrida self-requested a review November 16, 2021 18:25

rbadillap added 3 commits November 17, 2021 09:12

Merge branch 'main' into ci/pipelines

53c0d26

* main: Create the `InputField` and `SearchBar` components (#380) Add VPopover component (#397) Search and media store refactoring (#398) Node 16 and NPM 8 (#413)

feat: replace env variable and start using playwright

b9a5396

Merge branch 'main' into ci/pipelines

81b9430

* main: Fix state errors (#417) Add Checkbox component (#406) Fix package-lock.json engines (#430) Make Homepage and Searchbar RTL-compatible (#427)

zackkrida changed the base branch from main to docker-improvements November 19, 2021 19:49

zackkrida requested review from sarayourfriend and obulat November 19, 2021 19:49

sarayourfriend reviewed Nov 19, 2021

View reviewed changes

obulat deleted the branch main November 26, 2021 07:02

obulat reviewed Nov 30, 2021

View reviewed changes

dhruvkb approved these changes Nov 30, 2021

View reviewed changes

rbadillap added 2 commits November 30, 2021 01:39

fix: port reference in dockerfile and docker-compose.yaml

a860038

Merge branch 'docker-improvements' into ci/pipelines

80fd7f4

zackkrida added 3 commits November 30, 2021 07:58

Merge branch 'main' into docker-improvements

e1c0523

Remove duplicated browse page mocked field

8d812c3

Merge branch 'docker-improvements' into ci/pipelines

262fda7

zackkrida approved these changes Nov 30, 2021

View reviewed changes

zackkrida requested review from obulat and sarayourfriend November 30, 2021 13:17

sarayourfriend approved these changes Nov 30, 2021

View reviewed changes

zackkrida reviewed Nov 30, 2021

View reviewed changes

AetherUnbound approved these changes Nov 30, 2021

View reviewed changes

zackkrida changed the base branch from docker-improvements to main November 30, 2021 21:00

Merge main; fix package-lock differences

bb31002

rbadillap merged commit 10fa808 into main Nov 30, 2021

rbadillap deleted the ci/pipelines branch November 30, 2021 21:20

zackkrida mentioned this pull request Feb 22, 2023

Add a new environment variable for Sentry environment management WordPress/openverse#641

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve `Dockerfile` and enable pipeline to automate docker image generation #388

Improve `Dockerfile` and enable pipeline to automate docker image generation #388

rbadillap commented Oct 29, 2021

zackkrida left a comment •

edited

Loading

rbadillap commented Nov 13, 2021

sarayourfriend left a comment •

edited

Loading

sarayourfriend Nov 19, 2021

sarayourfriend Nov 19, 2021

rbadillap Nov 30, 2021

zackkrida commented Nov 28, 2021 •

edited

Loading

zackkrida commented Nov 29, 2021 •

edited

Loading

obulat Nov 30, 2021

rbadillap Nov 30, 2021

obulat commented Nov 30, 2021

dhruvkb left a comment •

edited

Loading

rbadillap commented Nov 30, 2021

rbadillap commented Nov 30, 2021

zackkrida left a comment

sarayourfriend left a comment

zackkrida commented Nov 30, 2021

zackkrida Nov 30, 2021

rbadillap Nov 30, 2021

AetherUnbound left a comment

AetherUnbound Nov 30, 2021

AetherUnbound Nov 30, 2021

zackkrida Nov 30, 2021

Improve Dockerfile and enable pipeline to automate docker image generation #388

Improve Dockerfile and enable pipeline to automate docker image generation #388

Conversation

rbadillap commented Oct 29, 2021

Description

Testing Instructions

zackkrida left a comment • edited Loading

Choose a reason for hiding this comment

rbadillap commented Nov 13, 2021

sarayourfriend left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackkrida commented Nov 28, 2021 • edited Loading

zackkrida commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

obulat commented Nov 30, 2021

dhruvkb left a comment • edited Loading

Choose a reason for hiding this comment

rbadillap commented Nov 30, 2021

rbadillap commented Nov 30, 2021

zackkrida left a comment

Choose a reason for hiding this comment

sarayourfriend left a comment

Choose a reason for hiding this comment

zackkrida commented Nov 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AetherUnbound left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Footnotes

Choose a reason for hiding this comment

Improve `Dockerfile` and enable pipeline to automate docker image generation #388

Improve `Dockerfile` and enable pipeline to automate docker image generation #388

zackkrida left a comment •

edited

Loading

sarayourfriend left a comment •

edited

Loading

zackkrida commented Nov 28, 2021 •

edited

Loading

zackkrida commented Nov 29, 2021 •

edited

Loading

dhruvkb left a comment •

edited

Loading