Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Set explicit ltr direction for pages untranslated in rtl languages #434

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Part of #421 by @sarayourfriend
Fixes #431 by @sarayourfriend

Description

Based on a conversation with @dlind1 we'll temporarily force certain untranslated pages back to ltr direction for RTL languages. As long as these pages are still falling back to English for RTL languages then we'll keep this around. If we find that some RTL languages are getting translated (or even some pages for it) then we revisit this and do it conditionally based on the locale and page.

This also stops toLocaleString for provider resource count using Eastern Arabic numerals in a context when Western Arabic numerals would typically be used.

Testing Instructions

Checkout this branch and run npm run dev. Set your locale to an RTL locale and verify that the pages modified by this PR all have their direction set to LTR.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner November 18, 2021 17:49
@obulat obulat added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix labels Nov 19, 2021
getProviderImageCount(imageCount) {
return imageCount.toLocaleString(this.$i18n.locale)
// Always use EN, most sites with RTL language with numbers continue to use Western Arabic Numerals whereas `toLocaleString` will use Eastern Arabic Numerals for Arabic and Hebrew by default
return imageCount.toLocaleString('en')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should check for Arabic specifically, because toLocaleString(en) uses a comma as a thousands separator, and some European languages use comma as decimal separator, and a period or a space for thousands separator:

const num = 25000
num.toLocaleString('en')
"25,000"
num.toLocaleString('de')
"25.000"
num.toLocaleString('ru')
"25 000"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes definitely, good call. Hebrew was also using Eastern Arabic Numerals, but I solved this problem previously for Gutenberg so I will find that PR and apply a similar logic here. I can't believe I forgot about that!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Really cool that you have prior experience fixing that issue.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarayourfriend sarayourfriend added the 🟩 priority: low Low priority and doesn't need to be rushed label Nov 29, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarayourfriend sarayourfriend merged commit a821eb0 into main Nov 29, 2021
@sarayourfriend sarayourfriend deleted the fix/sources-rtl branch November 29, 2021 18:55
rbadillap added a commit that referenced this pull request Nov 30, 2021
* main:
  Update Sass breakpoints to match tailwind (#455)
  Converge `NavSection` components (#454)
  Use a unique `SearchGridFilter` component (#439)
  Set explicit ltr direction for pages untranslated in rtl languages (#434)
  Add VItemGroup component (#410)
  Update video demos for Meta Search (#420)
  Fix Search form on smaller viewports (#437)
  Make Header RTL-compatible (#429)
  🔄 Synced file(s) with WordPress/openverse (#449)
  Removed unused image assets (#404)
  Restore husky (#444)
  Bump axios from 0.21.1 to 0.21.2 (#441)
  Remove husky
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sources page
4 participants