Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Use Tailwind RTL styles everywhere #355

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

sarayourfriend
Copy link
Contributor

Description

Updates all existing tailwind styles that used one of the direction specific styles to use the start/end styles introduced by the Tailwind CSS RTL plugin

Testing Instructions

Run the app and ensure that the styles still work in LTR mode. Go ahead and switch the dir on the root HTML element to be rtl but know that a vast majority of the site has not been converted to have proper RTL support so most of it will be broken. The Tailwind CSS RTL plugin definitely works fine based on the PR that introduced it and what you can see in Storybook so we don't have to test that those styles work correctly, but do check that I've switched the l styles to s and the r styles to e. For good measure check that I didn't miss anything (I think my searches worked to catch all the instances of it but I might have missed some).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Oct 25, 2021
@sarayourfriend sarayourfriend requested a review from a team as a code owner October 25, 2021 21:28
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you for these changes.
This PR highlights the need to convert components using custom SCSS styles to the new style system.

@sarayourfriend sarayourfriend merged commit 380ffae into main Nov 4, 2021
@sarayourfriend sarayourfriend deleted the fix/use-rtl-styles branch November 4, 2021 11:56
rbadillap added a commit that referenced this pull request Nov 12, 2021
* main:
  Replace PDM logo (#411)
  Add playwright e2e tests (#394)
  Update breakpoints to the new Tailwind config (#408)
  Create a global audio player (amongst many smaller improvements) (#399)
  Create Skeleton components (#392)
  Tailwind breakpoints (#403)
  Avoid error using only local translation files (#367)
  Add base Button component (#372)
  Use Tailwind RTL styles everywhere (#355)
  Add a dependencies section and remove the redundant title (#379)
  🔄 Synced file(s) with WordPress/openverse (#384)
  Fix filters not being set on SSR (#386)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants