-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
@dhruvkb I added the icon from Font Awesome as you suggested but changing only the viewBox naively breaks it. What do you do to add these icons correctly? |
Yeah, sorry for the wrong resource I shared @krysal. I think using the SVG from Vocabulary might be better as it matches the |
I was thinking there was a specific process of scaling, transforming and/or repositioning the SVG, lol! Glad that it is a more straightforward solution. Thanks! Fixed and ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
* main: Replace PDM logo (#411) Add playwright e2e tests (#394) Update breakpoints to the new Tailwind config (#408) Create a global audio player (amongst many smaller improvements) (#399) Create Skeleton components (#392) Tailwind breakpoints (#403) Avoid error using only local translation files (#367) Add base Button component (#372) Use Tailwind RTL styles everywhere (#355) Add a dependencies section and remove the redundant title (#379) 🔄 Synced file(s) with WordPress/openverse (#384) Fix filters not being set on SSR (#386)
Fixes
Fixes #409 by @krysal
Description
This PR changes the icon for the Public Domain Mark tool (this is not exactly a license) and prefixes the
<License>
component with aV
as per our new standard to follow Vue recommendation to not name components with a single word. Also, adds the CC logo for the CC0 tool, like the rest of the licenses.Testing Instructions
Run storybook and observe changes in Components > VLicense > PDM route.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin