Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Replace PDM logo #411

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Replace PDM logo #411

merged 4 commits into from
Nov 12, 2021

Conversation

krysal
Copy link
Member

@krysal krysal commented Nov 11, 2021

Fixes

Fixes #409 by @krysal

Description

This PR changes the icon for the Public Domain Mark tool (this is not exactly a license) and prefixes the <License> component with a V as per our new standard to follow Vue recommendation to not name components with a single word. Also, adds the CC logo for the CC0 tool, like the rest of the licenses.

Testing Instructions

Run storybook and observe changes in Components > VLicense > PDM route.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Nov 11, 2021
@krysal
Copy link
Member Author

krysal commented Nov 11, 2021

@dhruvkb I added the icon from Font Awesome as you suggested but changing only the viewBox naively breaks it. What do you do to add these icons correctly?

@dhruvkb
Copy link
Member

dhruvkb commented Nov 12, 2021

Yeah, sorry for the wrong resource I shared @krysal. I think using the SVG from Vocabulary might be better as it matches the viewBox of the other icons. I suspect they were taken from Vocabulary as well 😆.

@krysal
Copy link
Member Author

krysal commented Nov 12, 2021

I was thinking there was a specific process of scaling, transforming and/or repositioning the SVG, lol! Glad that it is a more straightforward solution. Thanks!

Fixed and ready to review.

@krysal krysal marked this pull request as ready for review November 12, 2021 13:59
@krysal krysal requested a review from a team as a code owner November 12, 2021 13:59
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks great!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@krysal krysal merged commit f8fb6f0 into main Nov 12, 2021
@krysal krysal deleted the pdm_logo_fix branch November 12, 2021 19:00
rbadillap added a commit that referenced this pull request Nov 12, 2021
* main:
  Replace PDM logo (#411)
  Add playwright e2e tests (#394)
  Update breakpoints to the new Tailwind config (#408)
  Create a global audio player (amongst many smaller improvements) (#399)
  Create Skeleton components (#392)
  Tailwind breakpoints (#403)
  Avoid error using only local translation files (#367)
  Add base Button component (#372)
  Use Tailwind RTL styles everywhere (#355)
  Add a dependencies section and remove the redundant title (#379)
  🔄 Synced file(s) with WordPress/openverse (#384)
  Fix filters not being set on SSR (#386)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong icon for Public Domain tool
4 participants